You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/05 11:01:54 UTC
[GitHub] [ignite-3] tkalkirill opened a new pull request, #981: IGNITE-17225 Page replacement for persistent data region is not fully ported
tkalkirill opened a new pull request, #981:
URL: https://github.com/apache/ignite-3/pull/981
https://issues.apache.org/jira/browse/IGNITE-17225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #981: IGNITE-17225 Page replacement for persistent data region is not fully ported
Posted by GitBox <gi...@apache.org>.
SammyVimes commented on code in PR #981:
URL: https://github.com/apache/ignite-3/pull/981#discussion_r940034835
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/replacement/DelayedDirtyPageWrite.java:
##########
@@ -44,13 +46,10 @@ public class DelayedDirtyPageWrite implements WriteDirtyPage {
/** Replacing pages tracker, used to register & unregister pages being written. */
private final DelayedPageReplacementTracker tracker;
- /** Full page id to be written on {@link #finishReplacement} or null if nothing to write. */
+ /** Full page id to be written on {@link #finishReplacement} or {@code null} if nothing to write. */
private @Nullable FullPageId fullPageId;
- /** Byte buffer with page data to be written on {@link #finishReplacement} or null if nothing to write. */
- private @Nullable ByteBuffer byteBuf;
-
- /** Partition update tag to be used in{@link #finishReplacement} or null if nothing to write. */
+ /** Partition update tag to be used in{@link #finishReplacement} or {@code null} if nothing to write. */
Review Comment:
PersistentPageMemory -- partition update tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] SammyVimes merged pull request #981: IGNITE-17225 Page replacement for persistent data region is not fully ported
Posted by GitBox <gi...@apache.org>.
SammyVimes merged PR #981:
URL: https://github.com/apache/ignite-3/pull/981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #981: IGNITE-17225 Page replacement for persistent data region is not fully ported
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on code in PR #981:
URL: https://github.com/apache/ignite-3/pull/981#discussion_r940072663
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/replacement/DelayedDirtyPageWrite.java:
##########
@@ -44,13 +46,10 @@ public class DelayedDirtyPageWrite implements WriteDirtyPage {
/** Replacing pages tracker, used to register & unregister pages being written. */
private final DelayedPageReplacementTracker tracker;
- /** Full page id to be written on {@link #finishReplacement} or null if nothing to write. */
+ /** Full page id to be written on {@link #finishReplacement} or {@code null} if nothing to write. */
private @Nullable FullPageId fullPageId;
- /** Byte buffer with page data to be written on {@link #finishReplacement} or null if nothing to write. */
- private @Nullable ByteBuffer byteBuf;
-
- /** Partition update tag to be used in{@link #finishReplacement} or null if nothing to write. */
+ /** Partition update tag to be used in{@link #finishReplacement} or {@code null} if nothing to write. */
Review Comment:
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org