You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/05/05 14:40:31 UTC
[PR] test(frontend): re-enable 4 user-workflow / dashboard / list-item specs [texera]
Yicong-Huang opened a new pull request, #4944:
URL: https://github.com/apache/texera/pull/4944
### What changes were proposed in this PR?
Drop 4 entries from the spec exclusion lists in `tsconfig.spec.json` and `angular.json`'s test target, port their TestBed setups to the standalone-component shape, and fix one malformed template attribute that jsdom won't tolerate.
**Specs re-enabled:**
- `dashboard.component.spec.ts` — extends `socialAuthServiceMock` with `initState` (the Google sign-in directive subscribes to it in its constructor) and adds an `AdminSettingsService` stub; switches to `imports: [DashboardComponent]` so its standalone graph carries `GoogleSigninButtonModule` instead of relying on `NO_ERRORS_SCHEMA`.
- `user-project-list-item.component.spec.ts` — wraps the component in a `TestHostComponent` template `<nz-list><texera-user-project-list-item .../></nz-list>` so the `<nz-list-item>`-rooted component finds an `NzListComponent` provider; adds `provideRouter([])` for the embedded `[routerLink]`.
- `user-workflow-list-item.component.spec.ts` — same `<nz-list>` host wrapper.
- `user-workflow.component.spec.ts` — switches `declarations: [...]` to `imports: [...]` for the now-standalone children; converts `beforeEach(waitForAsync(...))` to `beforeEach(async () => ...)` so the setup runs outside the per-`it` ProxyZone wrapper.
**Drive-by template fix:**
`user-workflow.component.html` had a stray `]="true"` line — left over from #4873's `[nzBorderless]="true"` → `nzVariant="borderless"` rewrite. Browsers silently tolerate the malformed attribute, but jsdom throws `InvalidCharacterError: "]" did not match the Name production` during `setAttribute`, which is why the spec couldn't run under Vitest.
After this PR, the exclude list contains only specs gated on Vitest browser mode (#4866) or specs whose body is still a placeholder.
### Any related issues, documentation, discussions?
Part of #4880.
### How was this PR tested?
`yarn install && yarn ng test --watch=false` exits 0 locally; `yarn format:ci` is clean. CI exercises the same test command on the ubuntu / windows / macos frontend matrices.
```
Test Files 56 passed | 3 skipped (59)
Tests 248 passed | 8 skipped | 2 todo (258)
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7 (1M context)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): re-enable 4 user-workflow / dashboard / list-item specs [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4944:
URL: https://github.com/apache/texera/pull/4944#issuecomment-4380380706
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4944?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 42.44%. Comparing base ([`d837578`](https://app.codecov.io/gh/apache/texera/commit/d837578fa4e943ce30c855108a1da458a0bb4efe?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c4e68a5`](https://app.codecov.io/gh/apache/texera/commit/c4e68a55bb1b2bd6448508f51fa321cb72b29d01?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #4944 +/- ##
============================================
+ Coverage 42.17% 42.44% +0.27%
Complexity 2180 2180
============================================
Files 980 1005 +25
Lines 36305 37447 +1142
Branches 3783 3914 +131
============================================
+ Hits 15312 15896 +584
- Misses 20066 20587 +521
- Partials 927 964 +37
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/4944/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [frontend](https://app.codecov.io/gh/apache/texera/pull/4944/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.27% <ø> (+1.73%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4944?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): re-enable 4 user-workflow / dashboard / list-item specs [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #4944:
URL: https://github.com/apache/texera/pull/4944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org