You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2024/01/26 10:11:59 UTC
[PR] [refactor](join) remove unused RowRefListType from join [doris]
mrhhsg opened a new pull request, #30442:
URL: https://github.com/apache/doris/pull/30442
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](join) remove unused RowRefListType from join [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30442:
URL: https://github.com/apache/doris/pull/30442#issuecomment-1911809285
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](join) remove unused RowRefListType from join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30442:
URL: https://github.com/apache/doris/pull/30442#issuecomment-1911903775
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 3da9136e0b0c922abceaa961d88290b8e7d7c981 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.5 seconds inserted 10000000 Rows, about 740K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](join) remove unused RowRefListType from join [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30442:
URL: https://github.com/apache/doris/pull/30442#issuecomment-1911823233
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](join) remove unused RowRefListType from join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30442:
URL: https://github.com/apache/doris/pull/30442#issuecomment-1911899435
<details>
<summary>ClickBench: <b>Total hot run time: 30.76 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3da9136e0b0c922abceaa961d88290b8e7d7c981, data reload: false
query1 0.03 0.03 0.03
query2 0.06 0.02 0.02
query3 0.23 0.05 0.05
query4 1.68 0.06 0.07
query5 0.54 0.52 0.53
query6 1.28 0.63 0.63
query7 0.01 0.01 0.02
query8 0.04 0.02 0.03
query9 0.55 0.50 0.50
query10 0.54 0.56 0.56
query11 0.12 0.10 0.08
query12 0.12 0.09 0.08
query13 0.62 0.61 0.60
query14 0.78 0.81 0.80
query15 0.80 0.78 0.78
query16 0.38 0.39 0.37
query17 1.02 1.03 1.00
query18 0.27 0.22 0.26
query19 1.79 1.80 1.75
query20 0.01 0.01 0.02
query21 15.43 0.59 0.58
query22 2.46 2.34 1.77
query23 17.33 0.85 0.78
query24 2.68 1.18 0.91
query25 0.34 0.25 0.14
query26 0.47 0.13 0.14
query27 0.09 0.05 0.05
query28 11.03 0.75 0.75
query29 12.60 3.17 3.22
query30 0.58 0.47 0.45
query31 2.78 0.35 0.36
query32 3.34 0.48 0.48
query33 3.25 3.24 3.20
query34 15.82 4.39 4.28
query35 4.30 4.36 4.32
query36 1.13 1.07 1.08
query37 0.06 0.04 0.04
query38 0.04 0.03 0.03
query39 0.02 0.02 0.02
query40 0.15 0.13 0.12
query41 0.08 0.02 0.01
query42 0.03 0.02 0.01
query43 0.02 0.01 0.02
Total cold run time: 104.9 s
Total hot run time: 30.76 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](join) remove unused RowRefListType from join [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #30442:
URL: https://github.com/apache/doris/pull/30442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](join) remove unused RowRefListType from join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30442:
URL: https://github.com/apache/doris/pull/30442#issuecomment-1911854644
<details>
<summary>TPC-H: <b>Total hot run time: 39593 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3da9136e0b0c922abceaa961d88290b8e7d7c981, data reload: false
------ Round 1 ----------------------------------
q1 19447 5521 5411 5411
q2 2612 143 139 139
q3 11207 972 965 965
q4 6295 838 828 828
q5 7694 2984 2977 2977
q6 190 120 120 120
q7 1093 742 735 735
q8 9301 2043 2038 2038
q9 7755 6483 6368 6368
q10 8136 2448 2473 2448
q11 417 214 199 199
q12 781 282 284 282
q13 18008 3353 3348 3348
q14 290 265 260 260
q15 542 511 505 505
q16 467 414 432 414
q17 949 563 533 533
q18 7741 6971 6941 6941
q19 1564 1345 1465 1345
q20 611 334 316 316
q21 6948 3124 3191 3124
q22 813 297 308 297
Total cold run time: 112861 ms
Total hot run time: 39593 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5364 5256 5381 5256
q2 321 214 206 206
q3 3337 3271 3248 3248
q4 2083 2069 2036 2036
q5 6079 5954 5866 5866
q6 200 118 117 117
q7 2324 1823 1841 1823
q8 3235 3379 3394 3379
q9 9050 8978 8941 8941
q10 5483 3812 3794 3794
q11 554 456 475 456
q12 814 623 626 623
q13 16894 3175 3152 3152
q14 289 252 272 252
q15 562 501 503 501
q16 511 444 476 444
q17 1900 1891 1847 1847
q18 9579 19800 9776 9776
q19 24294 1533 1535 1533
q20 4640 1935 1924 1924
q21 14415 5350 5402 5350
q22 1003 561 588 561
Total cold run time: 112931 ms
Total hot run time: 61085 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](join) remove unused RowRefListType from join [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #30442:
URL: https://github.com/apache/doris/pull/30442#issuecomment-1911796719
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](join) remove unused RowRefListType from join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30442:
URL: https://github.com/apache/doris/pull/30442#issuecomment-1911890575
<details>
<summary>TPC-DS: <b>Total hot run time: 176163 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3da9136e0b0c922abceaa961d88290b8e7d7c981, data reload: false
query1 928 335 322 322
query2 6562 2043 1969 1969
query3 6689 208 201 201
query4 30404 22223 22205 22205
query5 4447 432 439 432
query6 244 153 148 148
query7 4628 267 257 257
query8 219 184 177 177
query9 8359 2528 2495 2495
query10 408 215 228 215
query11 16883 15624 15596 15596
query12 119 68 67 67
query13 1667 391 377 377
query14 9821 6752 6779 6752
query15 208 175 189 175
query16 5700 250 246 246
query17 973 489 465 465
query18 1794 249 246 246
query19 169 129 126 126
query20 68 73 65 65
query21 192 126 128 126
query22 4938 4800 4493 4493
query23 31448 31061 30686 30686
query24 12582 2864 2835 2835
query25 595 315 312 312
query26 1935 142 142 142
query27 3173 288 290 288
query28 7575 1830 1823 1823
query29 2227 597 594 594
query30 286 133 138 133
query31 932 745 745 745
query32 84 55 55 55
query33 709 206 212 206
query34 1183 451 459 451
query35 866 794 747 747
query36 1330 1168 1191 1168
query37 89 57 59 57
query38 3338 3248 3274 3248
query39 1312 1253 1257 1253
query40 344 80 85 80
query41 37 33 34 33
query42 93 85 80 80
query43 529 473 456 456
query44 1074 678 690 678
query45 199 174 174 174
query46 1050 662 659 659
query47 1680 1450 1495 1450
query48 377 313 304 304
query49 1236 289 275 275
query50 694 311 303 303
query51 5325 5207 5139 5139
query52 89 81 73 73
query53 332 247 254 247
query54 250 181 185 181
query55 84 78 73 73
query56 174 174 158 158
query57 1008 905 912 905
query58 190 168 157 157
query59 2946 2789 2771 2771
query60 206 181 179 179
query61 83 85 82 82
query62 602 356 347 347
query63 270 259 262 259
query64 6036 1783 1755 1755
query65 3305 3262 3233 3233
query66 1475 314 309 309
query67 15625 15091 15074 15074
query68 14567 525 529 525
query69 614 311 285 285
query70 2256 1470 1442 1442
query71 494 221 209 209
query72 4896 2861 2881 2861
query73 3827 313 311 311
query74 7057 6373 6379 6373
query75 5048 2304 2306 2304
query76 6322 1041 1016 1016
query77 723 226 229 226
query78 9084 8781 8693 8693
query79 2435 503 510 503
query80 578 324 326 324
query81 450 207 202 202
query82 199 78 82 78
query83 164 112 115 112
query84 273 68 70 68
query85 1107 356 334 334
query86 371 394 395 394
query87 3511 3351 3323 3323
query88 2806 2227 2222 2222
query89 442 355 338 338
query90 2024 184 186 184
query91 146 125 122 122
query92 59 43 40 40
query93 1320 456 441 441
query94 1327 161 160 160
query95 503 456 445 445
query96 613 321 328 321
query97 4260 4104 4130 4104
query98 205 192 184 184
query99 1010 709 687 687
Total cold run time: 299088 ms
Total hot run time: 176163 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](join) remove unused RowRefListType from join [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30442:
URL: https://github.com/apache/doris/pull/30442#issuecomment-1911823279
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org