You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Benjamin Reed (Commented) (JIRA)" <ji...@apache.org> on 2011/12/07 20:02:40 UTC

[jira] [Commented] (ZOOKEEPER-1292) FLETest is flaky

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164622#comment-13164622 ] 

Benjamin Reed commented on ZOOKEEPER-1292:
------------------------------------------

can you a comment to the LEThread class to explain more how it works, especially how the rounds work?

also i think we should lower the wait() times 2 secs seem a bit pessimistic. is there a way to make the Thread.sleep(1000) smaller and actually check a condition to avoid any race?
                
> FLETest is flaky
> ----------------
>
>                 Key: ZOOKEEPER-1292
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1292
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: leaderElection
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1292.patch, ZOOKEEPER-1292.patch
>
>
> testLE in FLETest is convoluted, difficult to read, and doesn't test FLE appropriately. The goal of this jira is to clean it up and propose a more reasonable test case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira