You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/16 05:54:40 UTC
[GitHub] [dubbo-go] jack15083 opened a new pull request #940: Add GetInvoker function for referenceConfig
jack15083 opened a new pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
Add GetInvoker function for referenceConfig
**Which issue(s) this PR fixes**:
网关项目缓存泛化调用referenceConfig时需要检查invkoer是不是可用，所以需要将invoker返回出来。
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (9193690) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/04fa9b0e278af644393d30c7d9587abc482beca9?el=desc) (04fa9b0) will **decrease** coverage by `0.18%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
- Coverage 60.20% 60.02% -0.19%
===========================================
Files 260 260
Lines 12886 12889 +3
===========================================
- Hits 7758 7736 -22
- Misses 4170 4190 +20
- Partials 958 963 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.80% <0.00%> (-0.83%)` | :arrow_down: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `46.15% <0.00%> (-3.85%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `68.54% <0.00%> (-1.62%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [04fa9b0...9193690](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron commented on a change in pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
cityiron commented on a change in pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#discussion_r560220096
##########
File path: config/reference_config.go
##########
@@ -248,3 +248,8 @@ func (c *ReferenceConfig) GenericLoad(id string) {
c.Refer(genericService)
c.Implement(genericService)
}
+
+// GetInvoker get invoker from ReferenceConfig
+func (c *ReferenceConfig) GetInvoker() protocol.Invoker {
Review comment:
我也觉得直接暴露不好，这个是个内部的对象，参考 Java 的实现也是不暴露的
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] jack15083 closed pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
jack15083 closed pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] jack15083 closed pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
jack15083 closed pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (9193690) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/425c03f7ef6214ff1387594fd4b47206a449261b?el=desc) (425c03f) will **increase** coverage by `0.11%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
+ Coverage 59.90% 60.02% +0.11%
===========================================
Files 261 260 -1
Lines 12912 12889 -23
===========================================
+ Hits 7735 7736 +1
+ Misses 4224 4190 -34
- Partials 953 963 +10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.80% <0.00%> (+0.61%)` | :arrow_up: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `46.15% <0.00%> (-3.85%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [config\_center/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9saXN0ZW5lci5nbw==) | `47.36% <0.00%> (-5.27%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.40%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [425c03f...5a8c599](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (e16c552) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/69ca021d5f38f99029e29940cbc287628499325e?el=desc) (69ca021) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
+ Coverage 60.00% 60.05% +0.05%
===========================================
Files 260 260
Lines 12795 12841 +46
===========================================
+ Hits 7677 7712 +35
- Misses 4159 4172 +13
+ Partials 959 957 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.80% <ø> (+0.80%)` | :arrow_up: |
| [metadata/definition/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-bWV0YWRhdGEvZGVmaW5pdGlvbi9tb2NrLmdv) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [remoting/getty/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcmVhZHdyaXRlci5nbw==) | `42.85% <0.00%> (-11.43%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `52.17% <0.00%> (-8.70%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <0.00%> (-4.62%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `58.52% <0.00%> (-2.97%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `48.78% <0.00%> (-2.39%)` | :arrow_down: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `41.08% <0.00%> (-1.88%)` | :arrow_down: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (-1.52%)` | :arrow_down: |
| ... and [39 more](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [69ca021...d154f55](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig && Fix refresh invoker nil when zk reconnect
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (5a8c599) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/425c03f7ef6214ff1387594fd4b47206a449261b?el=desc) (425c03f) will **decrease** coverage by `0.15%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
- Coverage 59.90% 59.75% -0.16%
===========================================
Files 261 261
Lines 12912 12915 +3
===========================================
- Hits 7735 7717 -18
- Misses 4224 4245 +21
Partials 953 953
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.41% <0.00%> (-0.79%)` | :arrow_down: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `46.15% <0.00%> (-3.85%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [425c03f...9b94fb0](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (9240689) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/04fa9b0e278af644393d30c7d9587abc482beca9?el=desc) (04fa9b0) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
- Coverage 60.20% 60.14% -0.06%
===========================================
Files 260 260
Lines 12886 12887 +1
===========================================
- Hits 7758 7751 -7
- Misses 4170 4173 +3
- Partials 958 963 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.80% <0.00%> (-0.83%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `64.31% <0.00%> (-5.29%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `49.15% <0.00%> (+19.49%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [04fa9b0...9193690](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#discussion_r549006114
##########
File path: config/reference_config.go
##########
@@ -248,3 +248,8 @@ func (c *ReferenceConfig) GenericLoad(id string) {
c.Refer(genericService)
c.Implement(genericService)
}
+
+// GetInvoker get invoker from ReferenceConfig
+func (c *ReferenceConfig) GetInvoker() protocol.Invoker {
Review comment:
why do you add `GetInvoker`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig && Fix refresh invoker nil when zk reconnect
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (5a8c599) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/425c03f7ef6214ff1387594fd4b47206a449261b?el=desc) (425c03f) will **decrease** coverage by `0.15%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
- Coverage 59.90% 59.75% -0.16%
===========================================
Files 261 261
Lines 12912 12915 +3
===========================================
- Hits 7735 7717 -18
- Misses 4224 4245 +21
Partials 953 953
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.41% <0.00%> (-0.79%)` | :arrow_down: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `46.15% <0.00%> (-3.85%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [425c03f...e981df8](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (9240689) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/04fa9b0e278af644393d30c7d9587abc482beca9?el=desc) (04fa9b0) will **increase** coverage by `0.19%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
+ Coverage 60.20% 60.40% +0.19%
===========================================
Files 260 260
Lines 12886 12887 +1
===========================================
+ Hits 7758 7784 +26
+ Misses 4170 4144 -26
- Partials 958 959 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.80% <0.00%> (-0.83%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `55.78% <0.00%> (+2.10%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `78.78% <0.00%> (+3.03%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `49.15% <0.00%> (+19.49%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [04fa9b0...9193690](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (d154f55) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/69ca021d5f38f99029e29940cbc287628499325e?el=desc) (69ca021) will **increase** coverage by `0.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
+ Coverage 60.00% 60.24% +0.24%
===========================================
Files 260 260
Lines 12795 12885 +90
===========================================
+ Hits 7677 7762 +85
- Misses 4159 4165 +6
+ Partials 959 958 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.80% <ø> (+0.80%)` | :arrow_up: |
| [metadata/definition/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-bWV0YWRhdGEvZGVmaW5pdGlvbi9tb2NrLmdv) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [remoting/getty/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcmVhZHdyaXRlci5nbw==) | `42.85% <0.00%> (-11.43%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <0.00%> (-4.62%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `48.78% <0.00%> (-2.39%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.36% <0.00%> (-2.13%)` | :arrow_down: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (-1.52%)` | :arrow_down: |
| [metadata/service/inmemory/service.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9pbm1lbW9yeS9zZXJ2aWNlLmdv) | `85.22% <0.00%> (-1.38%)` | :arrow_down: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `41.62% <0.00%> (-1.34%)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [69ca021...d154f55](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron commented on a change in pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
cityiron commented on a change in pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#discussion_r546184668
##########
File path: config/reference_config.go
##########
@@ -252,3 +252,8 @@ func (c *ReferenceConfig) GenericLoad(id string) {
c.Refer(genericService)
c.Implement(genericService)
}
+
+// Get invoker
Review comment:
Comment start with GetInvoker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (d154f55) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/04fa9b0e278af644393d30c7d9587abc482beca9?el=desc) (04fa9b0) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
+ Coverage 60.20% 60.24% +0.03%
===========================================
Files 260 260
Lines 12886 12885 -1
===========================================
+ Hits 7758 7762 +4
+ Misses 4170 4165 -5
Partials 958 958
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.80% <ø> (-0.83%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `68.54% <0.00%> (-1.62%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.36% <0.00%> (-0.26%)` | :arrow_down: |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `41.62% <0.00%> (+0.54%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `71.36% <0.00%> (+1.76%)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.84% <0.00%> (+3.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [04fa9b0...9193690](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (d154f55) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/69ca021d5f38f99029e29940cbc287628499325e?el=desc) (69ca021) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
- Coverage 60.00% 59.97% -0.03%
===========================================
Files 260 260
Lines 12795 12885 +90
===========================================
+ Hits 7677 7728 +51
- Misses 4159 4200 +41
+ Partials 959 957 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.80% <ø> (+0.80%)` | :arrow_up: |
| [metadata/definition/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-bWV0YWRhdGEvZGVmaW5pdGlvbi9tb2NrLmdv) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [remoting/getty/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcmVhZHdyaXRlci5nbw==) | `42.85% <0.00%> (-11.43%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <0.00%> (-4.62%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `48.78% <0.00%> (-2.39%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.36% <0.00%> (-2.13%)` | :arrow_down: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `41.08% <0.00%> (-1.88%)` | :arrow_down: |
| ... and [39 more](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [69ca021...d154f55](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#discussion_r549007282
##########
File path: config/reference_config.go
##########
@@ -248,3 +248,8 @@ func (c *ReferenceConfig) GenericLoad(id string) {
c.Refer(genericService)
c.Implement(genericService)
}
+
+// GetInvoker get invoker from ReferenceConfig
+func (c *ReferenceConfig) GetInvoker() protocol.Invoker {
Review comment:
是为了检查是否可用，那么是否可以封装一个检查服务是否有效的方法？个人建议不要直接把invoker暴露出去
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (d154f55) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/04fa9b0e278af644393d30c7d9587abc482beca9?el=desc) (04fa9b0) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
+ Coverage 60.20% 60.24% +0.03%
===========================================
Files 260 260
Lines 12886 12885 -1
===========================================
+ Hits 7758 7762 +4
+ Misses 4170 4165 -5
Partials 958 958
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.80% <ø> (-0.83%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `68.54% <0.00%> (-1.62%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.36% <0.00%> (-0.26%)` | :arrow_down: |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `41.62% <0.00%> (+0.54%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `71.36% <0.00%> (+1.76%)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.84% <0.00%> (+3.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [04fa9b0...9240689](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (e981df8) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/425c03f7ef6214ff1387594fd4b47206a449261b?el=desc) (425c03f) will **decrease** coverage by `0.33%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
- Coverage 59.90% 59.57% -0.34%
===========================================
Files 261 261
Lines 12912 12904 -8
===========================================
- Hits 7735 7687 -48
- Misses 4224 4250 +26
- Partials 953 967 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.41% <0.00%> (-0.79%)` | :arrow_down: |
| [filter/filter\_impl/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvc2lnbl91dGlsLmdv) | `54.54% <0.00%> (-7.36%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `63.34% <0.00%> (-5.38%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `73.49% <0.00%> (-4.82%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [protocol/dubbo/hessian2/hessian\_request.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaGVzc2lhbjIvaGVzc2lhbl9yZXF1ZXN0Lmdv) | `55.44% <0.00%> (-3.15%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `76.92% <0.00%> (-2.43%)` | :arrow_down: |
| [protocol/jsonrpc/http.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9odHRwLmdv) | `70.66% <0.00%> (-2.31%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [425c03f...d1011d2](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (e981df8) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/425c03f7ef6214ff1387594fd4b47206a449261b?el=desc) (425c03f) will **decrease** coverage by `0.33%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
- Coverage 59.90% 59.57% -0.34%
===========================================
Files 261 261
Lines 12912 12904 -8
===========================================
- Hits 7735 7687 -48
- Misses 4224 4250 +26
- Partials 953 967 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.41% <0.00%> (-0.79%)` | :arrow_down: |
| [filter/filter\_impl/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvc2lnbl91dGlsLmdv) | `54.54% <0.00%> (-7.36%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `63.34% <0.00%> (-5.38%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `73.49% <0.00%> (-4.82%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [protocol/dubbo/hessian2/hessian\_request.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaGVzc2lhbjIvaGVzc2lhbl9yZXF1ZXN0Lmdv) | `55.44% <0.00%> (-3.15%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `76.92% <0.00%> (-2.43%)` | :arrow_down: |
| [protocol/jsonrpc/http.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9odHRwLmdv) | `70.66% <0.00%> (-2.31%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [425c03f...e981df8](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (5a8c599) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/425c03f7ef6214ff1387594fd4b47206a449261b?el=desc) (425c03f) will **decrease** coverage by `0.15%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
- Coverage 59.90% 59.75% -0.16%
===========================================
Files 261 261
Lines 12912 12915 +3
===========================================
- Hits 7735 7717 -18
- Misses 4224 4245 +21
Partials 953 953
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.41% <0.00%> (-0.79%)` | :arrow_down: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `46.15% <0.00%> (-3.85%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [425c03f...5a8c599](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#issuecomment-748427398
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=h1) Report
> Merging [#940](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=desc) (5a8c599) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/425c03f7ef6214ff1387594fd4b47206a449261b?el=desc) (425c03f) will **decrease** coverage by `0.15%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
- Coverage 59.90% 59.75% -0.16%
===========================================
Files 261 261
Lines 12912 12915 +3
===========================================
- Hits 7735 7717 -18
- Misses 4224 4245 +21
Partials 953 953
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.41% <0.00%> (-0.79%)` | :arrow_down: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `46.15% <0.00%> (-3.85%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/940/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=footer). Last update [425c03f...2ea37cc](https://codecov.io/gh/apache/dubbo-go/pull/940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #940: Add GetInvoker function for referenceConfig
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#discussion_r549006114
##########
File path: config/reference_config.go
##########
@@ -248,3 +248,8 @@ func (c *ReferenceConfig) GenericLoad(id string) {
c.Refer(genericService)
c.Implement(genericService)
}
+
+// GetInvoker get invoker from ReferenceConfig
+func (c *ReferenceConfig) GetInvoker() protocol.Invoker {
Review comment:
why do you add `GetInvoker`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] jack15083 commented on a change in pull request #940: Add GetInvoker function for referenceConfig && Fix refresh invoker nil when zk reconnect
Posted by GitBox <gi...@apache.org>.
jack15083 commented on a change in pull request #940:
URL: https://github.com/apache/dubbo-go/pull/940#discussion_r550948732
##########
File path: config/reference_config.go
##########
@@ -248,3 +248,8 @@ func (c *ReferenceConfig) GenericLoad(id string) {
c.Refer(genericService)
c.Implement(genericService)
}
+
+// GetInvoker get invoker from ReferenceConfig
+func (c *ReferenceConfig) GetInvoker() protocol.Invoker {
Review comment:
为啥不能暴露出去，暴露出去的话可能以后更方便扩展吧
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org