[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #86: Add bucketVersioningEnabled helper methods

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #86:
URL: https://github.com/apache/incubator-pekko-connectors/pull/86#discussion_r1181651467


##########
s3/src/main/scala/org/apache/pekko/stream/connectors/s3/model.scala:
##########
@@ -194,6 +200,12 @@ final class BucketVersioning private (val status: Option[BucketVersioningStatus]
   /** Java API */
   def getMfaDelete: java.util.Optional[MFAStatus] = mfaDelete.asJava
 
+  /** Java API */
+  def getBucketVersioningEnabled: Boolean = bucketVersioningEnabled

Review Comment:
   With Java APIs, it is more common to use 'is' instead of 'get' for the names of getters that return booleans.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org