[GitHub] [airflow] RosterIn commented on issue #7452: [AIRFLOW-6831] Support for various ssh keys and certificates

[GitBox <gi...@apache.org>]

RosterIn commented on issue #7452: [AIRFLOW-6831] Support for various ssh keys and certificates
URL: https://github.com/apache/airflow/pull/7452#issuecomment-605927371
 
 
   @biertie there are issues with the tests:
   
   ```
   tests/providers/ssh/hooks/test_ssh.py:110: 
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   /usr/local/lib/python3.6/site-packages/mock/mock.py:926: in assert_called_once_with
       return self.assert_called_with(*args, **kwargs)
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   _mock_self = <MagicMock name='SSHClient().connect' id='140108173859080'>
   args = ()
   kwargs = {'compress': True, 'hostname': 'remote_host', 'key_filename': 'fake.file', 'password': 'password', ...}
   expected = call(hostname='remote_host', username='username', password='password', key_filename='fake.file', timeout=10, compress=True, port='port', sock=None)
   actual = call(hostname='remote_host', username='username', timeout=10, compress=True, port='port', sock=None, password='password')
   _error_message = <function NonCallableMock.assert_called_with.<locals>._error_message at 0x7f6d8d1b2c80>
   cause = None
       def assert_called_with(_mock_self, *args, **kwargs):
           """assert that the last call was made with the specified arguments.
       
           Raises an AssertionError if the args and keyword args passed in are
           different to the last call to the mock."""
           self = _mock_self
           if self.call_args is None:
               expected = self._format_mock_call_signature(args, kwargs)
               actual = 'not called.'
               error_message = ('expected call not found.\nExpected: %s\nActual: %s'
                       % (expected, actual))
               raise AssertionError(error_message)
       
           def _error_message():
               msg = self._format_mock_failure_message(args, kwargs)
               return msg
           expected = self._call_matcher(_Call((args, kwargs), two=True))
           actual = self._call_matcher(self.call_args)
           if actual != expected:
               cause = expected if isinstance(expected, Exception) else None
   >           raise AssertionError(_error_message()) from cause
   E           AssertionError: expected call not found.
   E           Expected: connect(hostname='remote_host', username='username', password='password', key_filename='fake.file', timeout=10, compress=True, port='port', sock=None)
   E           Actual: connect(hostname='remote_host', username='username', timeout=10, compress=True, port='port', sock=None, password='password')
   /usr/local/lib/python3.6/site-packages/mock/mock.py:913: AssertionError
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services