You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/13 03:31:39 UTC

[GitHub] [flink] WeiZhong94 opened a new pull request #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

WeiZhong94 opened a new pull request #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076
 
 
   ## What is the purpose of the change
   
   *This pull request adds description of support 'pip install' to 1.9.x documents.*
   
   
   ## Brief change log
   
     - *adds description of support 'pip install' to `python_table_api.md`.*
     - *adds description of support 'pip install' to `python_table_api.zh.md`.*
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076#issuecomment-585541734
 
 
   <!--
   Meta data
   Hash:e2fc04377969fe59ba6de22e47d93050ead27d6a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148717893 TriggerType:PUSH TriggerID:e2fc04377969fe59ba6de22e47d93050ead27d6a
   -->
   ## CI report:
   
   * e2fc04377969fe59ba6de22e47d93050ead27d6a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148717893) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076#issuecomment-585541734
 
 
   <!--
   Meta data
   Hash:e2fc04377969fe59ba6de22e47d93050ead27d6a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e2fc04377969fe59ba6de22e47d93050ead27d6a
   -->
   ## CI report:
   
   * e2fc04377969fe59ba6de22e47d93050ead27d6a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076#discussion_r378668403
 
 

 ##########
 File path: docs/tutorials/python_table_api.md
 ##########
 @@ -31,10 +31,14 @@ to running a Python Table API program.
 
 ## Setting up a Python Project
 
-Firstly, you can fire up your favorite IDE and create a Python project and then
-you need to install the PyFlink package. Please
-see [Build PyFlink]({{ site.baseurl }}/flinkDev/building.html#build-pyflink)
-for more details about this.
+You can begin by creating a Python project and installing the PyFlink package.
+PyFlink is available via PyPi and can be easily installed using `pip`.
 
 Review comment:
   Add a link to Pypi

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076#discussion_r378664262
 
 

 ##########
 File path: docs/tutorials/python_table_api.md
 ##########
 @@ -31,10 +31,14 @@ to running a Python Table API program.
 
 ## Setting up a Python Project
 
-Firstly, you can fire up your favorite IDE and create a Python project and then
-you need to install the PyFlink package. Please
-see [Build PyFlink]({{ site.baseurl }}/flinkDev/building.html#build-pyflink)
-for more details about this.
+You can begin by creating a Python project and installing the PyFlink package.
+PyFlink is available via PyPi and can be easily installed using `pip`.
+
+{% highlight bash %}
+$ python -m pip install apache-flink
 
 Review comment:
   For the version of 1.9 series, maybe it's better to specify the version, for example:
   ```
   # install the latest 1.9 version of PyFlink
   python -m pip install apache-flink==1.9.*
   ```
   The command will download the latest 1.9 pyflink.
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076#issuecomment-585541734
 
 
   <!--
   Meta data
   Hash:e2fc04377969fe59ba6de22e47d93050ead27d6a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148717893 TriggerType:PUSH TriggerID:e2fc04377969fe59ba6de22e47d93050ead27d6a
   -->
   ## CI report:
   
   * e2fc04377969fe59ba6de22e47d93050ead27d6a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148717893) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076#discussion_r378664746
 
 

 ##########
 File path: docs/tutorials/python_table_api.zh.md
 ##########
 @@ -30,8 +30,8 @@ under the License.
 
 ## 创建一个Python Table API项目
 
-首先，你可以使用你最熟悉的IDE，创建一个Python项目。然后，你需要安装PyFlink包，
-请参考[构建PyFlink]({{ site.baseurl }}/zh/flinkDev/building.html#build-pyflink)了解详细信息。
+首先，使用您最熟悉的IDE创建一个Python项目。之后执行命令`python -m pip install apache-flink`从PyPI下载安装PyFlink包。
 
 Review comment:
   ditto

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076#issuecomment-585533515
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit e2fc04377969fe59ba6de22e47d93050ead27d6a (Thu Feb 13 03:34:13 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076#issuecomment-585580060
 
 
   Merging...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 merged pull request #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] WeiZhong94 commented on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.

Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on issue #11076: [FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents.
URL: https://github.com/apache/flink/pull/11076#issuecomment-585576235
 
 
   @hequn8128 Thanks for your review! I have updated this PR according to your comments. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services