[GitHub] [ignite-3] zstan commented on a diff in pull request #2162: IGNITE-19493 Sql. Change query execution flow

["zstan (via GitHub)" <gi...@apache.org>]

zstan commented on code in PR #2162:
URL: https://github.com/apache/ignite-3/pull/2162#discussion_r1221610186


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -425,6 +421,18 @@ private CompletableFuture<AsyncSqlCursor<List<Object>>> querySingle0(
                 .thenCompose(sqlNode -> {
                     boolean rwOp = dataModificationOp(sqlNode);
 
+                    boolean implicitTxRequired = outerTx == null;
+
+                    tx.set(implicitTxRequired ? txManager.begin(!rwOp) : outerTx);
+
+                    SchemaPlus schema = sqlSchemaManager.schema(schemaName);

Review Comment:
   I can`t use this implementation for now :
   org.apache.ignite.internal.sql.engine.schema.SqlSchemaManagerImpl#activeSchema
   
   ```
       @Override
       public SchemaPlus activeSchema(@Nullable String name, long timestamp) {
           throw new UnsupportedOperationException();
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org