You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/22 03:49:12 UTC
[GitHub] [cordova-ios] bhariharan opened a new pull request #771: `(iOS)`
Making CDVUIWebViewDelegate a project-scoped header
bhariharan opened a new pull request #771: `(iOS)` Making CDVUIWebViewDelegate a project-scoped header
URL: https://github.com/apache/cordova-ios/pull/771
### Platforms affected
`iOS`
### Motivation and Context
Generated pure `Swift` apps with `WK_WEB_VIEW_ONLY` set to `true` will throw compilation errors since the `Swift` compiler won't accept incomplete umbrella headers (the `Cordova` module is deemed incomplete).
### Description
- `CDVUIWebViewDelegate.h` was a public-scoped header. However, in recent times (in [this PR](https://github.com/apache/cordova-ios/pull/715/files)), this class could get compiled out if the preprocessor directive `WK_WEB_VIEW_ONLY` is set to `true` (which is always the case for our apps, since we no longer support `UIWebView`).
- As a result, the umbrella header generated for `CordovaLib` is incomplete since it won't include this header.
- For `Obj C` apps, this is simply a warning. However, is a pure `Swift` app, this will cause a compilation failure.
- The only workaround is to make this file a project-scoped header instead.
### Testing
We have a plugin [here](https://github.com/forcedotcom/SalesforceMobileSDK-CordovaPlugin), where I applied the changes and verified it works. I have also verified that it works on our internal projects.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] jcesarmobile closed pull request #771: (iOS) Making
CDVUIWebViewDelegate a project-scoped header
Posted by GitBox <gi...@apache.org>.
jcesarmobile closed pull request #771: (iOS) Making CDVUIWebViewDelegate a project-scoped header
URL: https://github.com/apache/cordova-ios/pull/771
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] jcesarmobile commented on issue #771: (iOS) Making
CDVUIWebViewDelegate a project-scoped header
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on issue #771: (iOS) Making CDVUIWebViewDelegate a project-scoped header
URL: https://github.com/apache/cordova-ios/pull/771#issuecomment-583331930
thanks for the PR, but CDVUIWebViewDelegate is being removed (see https://github.com/apache/cordova-ios/pull/773)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org