You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by hbdeshmukh <gi...@git.apache.org> on 2016/07/25 17:27:37 UTC

[GitHub] incubator-quickstep pull request #65: Minor bug fix in QueryManager base.

GitHub user hbdeshmukh opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/65

    Minor bug fix in QueryManager base.

    Modified the order in which we check the completion of query and completion of an operator in the queryStatus function. Based on the semantics of the return value of ``queryStatus`` function, query completion return code takes precedence over operator completion. Hence changed the order in which we perform these checks. Note that this bug was present in the original code and was carried forward during the code refactoring of QueryManager. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep query-status-return-bugfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #65
    
----
commit 7d44e63bfc1dc51255bafbc9b3ffea386d5b229b
Author: Harshad Deshmukh <hb...@apache.org>
Date:   2016-07-25T17:23:34Z

    Minor bug fix in QueryManager base.
    
    - Modified the order in which we check the completion of query and
      completion of an operator in the queryStatus function.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #65: Minor bug fix in QueryManager base.

Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/65
  
    The main question is that why our unit test does not catch this bug, and how to prevent similar bugs in the future (i.e, by adding a new unit test)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #65: Minor bug fix in QueryManager base.

Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/65
  
    HI @pateljm 
    
    I have rebased with the master. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #65: Minor bug fix in QueryManager base.

Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/65
  
    The reason we did not encounter this bug was because there is only one place where this function is [called](https://github.com/apache/incubator-quickstep/blob/master/query_execution/PolicyEnforcerBase.cpp#L134). The call site is about removing a completed query and adding a waitlisted query. As there are no unit tests for multiple query execution yet, we did not catch this bug. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #65: Minor bug fix in QueryManager base.

Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/65
  
    Actually, we should use `QueryExecutionState::hasQueryExecutionFinished` directly, and remove `queryStatus` method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #65: Minor bug fix in QueryManager base.

Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/65
  
    Looks good. @hbdeshmukh  Can you rebase?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #65: Minor bug fix in QueryManager base.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/65


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---