You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:19:41 UTC

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #18807: [WIP]adding error message when attempting to use Large tensor with linalg_syevd

sandeep-krishnamurthy commented on a change in pull request #18807:
URL: https://github.com/apache/incubator-mxnet/pull/18807#discussion_r461673524



##########
File path: 3rdparty/mshadow/mshadow/base.h
##########
@@ -336,6 +336,8 @@ const float kPi = 3.1415926f;
   typedef int32_t index_t;
 #endif
 
+const index_t kInt32Limit = (int64_t{1} << 31) - 1;

Review comment:
       Can we add a comment to make it clear where is this being used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org