You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "jihun4452 (via GitHub)" <gi...@apache.org> on 2025/09/28 14:21:03 UTC
[PR] chore: bump @babel/runtime to ^7.27.0 [incubator-seata]
jihun4452 opened a new pull request, #7673:
URL: https://github.com/apache/incubator-seata/pull/7673
- [x] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [x] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
Update `console-fe/package.json` to bump `@babel/runtime` from `^7.26.10` to `^7.27.0`.
This aligns the direct dependency with the already resolved version in `package-lock.json` and addresses the potential security risk (CVE-2025-27789).
### Ⅱ. Does this pull request fix one issue?
fixes #7660
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Not applicable. This PR only updates a dependency version in `package.json`.
### Ⅳ. Describe how to verify it
1. Run `npm install` under `console-fe`.
2. Confirm that `node_modules/@babel/runtime` is installed at version `7.27.0`.
3. Build and run `console-fe` successfully without errors.
### Ⅴ. Special notes for reviews
None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#discussion_r2386987206
##########
console/src/main/resources/static/console-fe/package.json:
##########
@@ -106,6 +106,7 @@
"nanoid": "3.1.31",
"ip": "2.0.1",
"sha.js": "2.4.12",
- "cipher-base": "1.0.6"
+ "cipher-base": "1.0.6",
+ "@babel/runtime": "^7.27.0"
Review Comment:
The @babel/runtime entry is duplicated - it's already defined in the dependencies section at line 34. This duplication in what appears to be an overrides section could lead to confusion about which version takes precedence.
```suggestion
"cipher-base": "1.0.6"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly merged PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] chore: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#issuecomment-3343594093
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7673?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 61.19%. Comparing base ([`a977730`](https://app.codecov.io/gh/apache/incubator-seata/commit/a977730fc2647046fbf65427297a52f47e1d4825?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ae83727`](https://app.codecov.io/gh/apache/incubator-seata/commit/ae83727e41becc73476e634caa25d96f84651548?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7673 +/- ##
============================================
- Coverage 61.40% 61.19% -0.21%
Complexity 666 666
============================================
Files 1314 1314
Lines 49760 49760
Branches 5849 5849
============================================
- Hits 30553 30451 -102
- Misses 16474 16578 +104
+ Partials 2733 2731 -2
```
[see 12 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7673/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#issuecomment-3344640249
> package-lock.json을 업데이트해야 합니까?
I took a closer look and noticed that package-lock.json already resolves @babel/runtime to version 7.27.0,
so from my side there didn’t seem to be anything further required in that file.
Would it be necessary for me to commit the lock file as well in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#issuecomment-3344687037
Thank you for the clarification. I understand your point regarding the CVE notifications and version-locked dependencies.
I will update and commit the package-lock.json in this PR to ensure all relevant dependencies are upgraded to the patched version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#issuecomment-3344737227
Updated package-lock.json and added an `overrides` entry to enforce `@babel/runtime` ^7.27.0.
The lock now resolves `@babel/runtime` to 7.28.4, removing older prerelease copies (e.g., 7.0.0-beta.46 under dva/dva-core) and addressing CVE-2025-27789 across transitive dependencies.
If you prefer not to use `overrides`, I will revise this PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#issuecomment-3344611827
Hi, I have updated the changelog in both zh-cn/2.x.md and en-us/2.x.md as requested. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] chore: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "maple525866 (via GitHub)" <gi...@apache.org>.
maple525866 commented on PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#issuecomment-3343626811
Please register your PR in those two files :
https://github.com/apache/incubator-seata/blob/2.x/changes/zh-cn/2.x.md
https://github.com/apache/incubator-seata/blob/2.x/changes/en-us/2.x.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#issuecomment-3344615118
> Hi, I have updated the changelog in both zh-cn/2.x.md and en-us/2.x.md as requested. Thanks!
Add your Github ID at the bottom of the change logs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#issuecomment-3344592475
Hi,
Please register this PR in change logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#issuecomment-3344667040
> > Is it necessary to make an update in package-lock.json?
>
> I took a closer look and noticed that package-lock.json already resolves @babel/runtime to version 7.27.0, so from my side there didn’t seem to be anything further required in that file. Would it be necessary for me to commit the lock file as well in this PR?
package-lock.json is used to lock the version of the installation dependency. Some dependencies specify the version of @babel/runtime. Of course, some are cross-version. We need to upgrade the version-compatible dependencies to the patch-free version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: bump @babel/runtime to ^7.27.0 [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #7673:
URL: https://github.com/apache/incubator-seata/pull/7673#issuecomment-3344663099
> > Is it necessary to make an update in package-lock.json?
>
> I took a closer look and noticed that package-lock.json already resolves @babel/runtime to version 7.27.0, so from my side there didn’t seem to be anything further required in that file. Would it be necessary for me to commit the lock file as well in this PR?
Okay, I acknowledge your point. But, In order to address the CVE notifications, it wound be necessary to upgrade the @babel/runtimedependency version within the package-lock.json file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org