You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/18 07:33:04 UTC
[GitHub] [flink-table-store] JingsongLi opened a new pull request #11: [FLINK-25687] DropDelete is incorrect in CompactManager when outputLevel is zero
JingsongLi opened a new pull request #11:
URL: https://github.com/apache/flink-table-store/pull/11
When output level is zero, there may be have other files in level 0, we can not drop delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #11: [FLINK-25687] DropDelete is incorrect in CompactManager when outputLevel is zero
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #11:
URL: https://github.com/apache/flink-table-store/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] tsreaper commented on a change in pull request #11: [FLINK-25687] DropDelete is incorrect in CompactManager when outputLevel is zero
Posted by GitBox <gi...@apache.org>.
tsreaper commented on a change in pull request #11:
URL: https://github.com/apache/flink-table-store/pull/11#discussion_r786480063
##########
File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/CompactManager.java
##########
@@ -75,7 +75,8 @@ public void submitCompaction(Levels levels) {
return;
}
boolean dropDelete =
- unit.outputLevel() >= levels.nonEmptyHighestLevel();
+ unit.outputLevel() != 0
+ && unit.outputLevel() >= levels.nonEmptyHighestLevel();
Review comment:
add comments to explain the logic (for example level 0 is special because key ranges from different files may overlap, and that compaction are based on runs instead of files)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org