You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Eric Evans (JIRA)" <ji...@apache.org> on 2009/07/09 00:25:15 UTC
[jira] Created: (CASSANDRA-284) ant target(s) for thrift code
generation
ant target(s) for thrift code generation
----------------------------------------
Key: CASSANDRA-284
URL: https://issues.apache.org/jira/browse/CASSANDRA-284
Project: Cassandra
Issue Type: New Feature
Reporter: Eric Evans
Assignee: Eric Evans
Priority: Minor
It'd be handy if there were ant targets for generating thrift code (both python and java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-284) ant target(s) for thrift code
generation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731418#action_12731418 ]
Hudson commented on CASSANDRA-284:
----------------------------------
Integrated in Cassandra #138 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/138/])
added ant targets for thrift code generation
Path by Michael Greene; reviewed by eevans for
> ant target(s) for thrift code generation
> ----------------------------------------
>
> Key: CASSANDRA-284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-284
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Eric Evans
> Assignee: Michael Greene
> Priority: Minor
> Attachments: 284_v1.diff, 284_v2.diff
>
>
> It'd be handy if there were ant targets for generating thrift code (both python and java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-284) ant target(s) for thrift code
generation
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730546#action_12730546 ]
Eric Evans commented on CASSANDRA-284:
--------------------------------------
Sorry, I should have been more verbose when I opened the ticket. :)
The code generation targets should be split, one for java (invoked as a convenience by a developer making api changes), and one for python (invoked by anyone else that might be involved testing, reviewing, etc).
Neither of these targets should be depended on.
> ant target(s) for thrift code generation
> ----------------------------------------
>
> Key: CASSANDRA-284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-284
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Eric Evans
> Assignee: Eric Evans
> Priority: Minor
> Attachments: 284_v1.diff
>
>
> It'd be handy if there were ant targets for generating thrift code (both python and java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-284) ant target(s) for thrift code
generation
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-284:
-------------------------------------
Attachment: 284_v1.diff
Like this? Did you want any of the builds to depend on it?
> ant target(s) for thrift code generation
> ----------------------------------------
>
> Key: CASSANDRA-284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-284
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Eric Evans
> Assignee: Eric Evans
> Priority: Minor
> Attachments: 284_v1.diff
>
>
> It'd be handy if there were ant targets for generating thrift code (both python and java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-284) ant target(s) for thrift code
generation
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-284:
-------------------------------------
Attachment: 284_v2.diff
I'm not sure about the utility of this (`ant gen-thrift-py` is nearly as easy as `thrift --gen py interface/cassandra.thrift`) but this patch splits the targets as Eric suggests.
> ant target(s) for thrift code generation
> ----------------------------------------
>
> Key: CASSANDRA-284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-284
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Eric Evans
> Assignee: Eric Evans
> Priority: Minor
> Attachments: 284_v1.diff, 284_v2.diff
>
>
> It'd be handy if there were ant targets for generating thrift code (both python and java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-284) ant target(s) for thrift code
generation
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728939#action_12728939 ]
Jonathan Ellis commented on CASSANDRA-284:
------------------------------------------
I'm +1 for this but my ant skill level is negative. Someone else will have to scratch this itch. :)
> ant target(s) for thrift code generation
> ----------------------------------------
>
> Key: CASSANDRA-284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-284
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Eric Evans
> Assignee: Eric Evans
> Priority: Minor
>
> It'd be handy if there were ant targets for generating thrift code (both python and java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-284) ant target(s) for thrift code
generation
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans resolved CASSANDRA-284.
----------------------------------
Resolution: Fixed
Assignee: Michael Greene (was: Eric Evans)
committed, thanks!
> ant target(s) for thrift code generation
> ----------------------------------------
>
> Key: CASSANDRA-284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-284
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Eric Evans
> Assignee: Michael Greene
> Priority: Minor
> Attachments: 284_v1.diff, 284_v2.diff
>
>
> It'd be handy if there were ant targets for generating thrift code (both python and java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-284) ant target(s) for thrift code
generation
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730571#action_12730571 ]
Eric Evans commented on CASSANDRA-284:
--------------------------------------
You don't have command completion for ant targets? :)
I still think this is a worthwhile change since it provides us the ability to edit this in one place, like if for example the generated code needed to be relocated, or to be able to add new options (for example when THRIFT-537 is complete).
Perhaps someone will sound off with (shorter )alternatives to gen-thrift-{java,py}?
> ant target(s) for thrift code generation
> ----------------------------------------
>
> Key: CASSANDRA-284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-284
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Eric Evans
> Assignee: Eric Evans
> Priority: Minor
> Attachments: 284_v1.diff, 284_v2.diff
>
>
> It'd be handy if there were ant targets for generating thrift code (both python and java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-284) ant target(s) for thrift code
generation
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-284:
-------------------------------------
Component/s: Tools
> ant target(s) for thrift code generation
> ----------------------------------------
>
> Key: CASSANDRA-284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-284
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Eric Evans
> Assignee: Michael Greene
> Priority: Minor
> Fix For: 0.4
>
> Attachments: 284_v1.diff, 284_v2.diff
>
>
> It'd be handy if there were ant targets for generating thrift code (both python and java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.