[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126974#comment-14126974 ] 

ASF GitHub Bot commented on CB-7499:
------------------------------------

GitHub user mbillau opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/32

    Set dialog text dir to locale

    First part of the patch for CB-7499; sets the text direction on dialog messages to follow the locale. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mbillau/cordova-plugin-dialogs CB-7499

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit c88acd6ae9b4533d76605ee4876bf914ccd252e0
Author: mbillau <mi...@gmail.com>
Date:   2014-09-09T13:20:33Z

    Set dialog text dir to locale

----


> Cordova dialogs should support BIDI text
> ----------------------------------------
>
>                 Key: CB-7499
>                 URL: https://issues.apache.org/jira/browse/CB-7499
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin Dialogs
>    Affects Versions: Master
>            Reporter: Mike Billau
>            Assignee: Mike Billau
>            Priority: Minor
>              Labels: bidirectional, globalization
>
> Since API 19, Andorid has had the facilities to deal with bidirectional text, however, current Cordova notification implementation does not correctly handle bidirectional text in dialogs.
> We can see this is the case by first setting the language to Hebrew and then launching the following dialogs:
>     navigator.notification.confirm("Pure English !!!", function(){}, "7"); 
>     navigator.notification.confirm("עברית היא שפה מדוברת בIsrael !", function(){}, "8");
> Since we are in Hebrew, the base text direction will be RTL. This means that when we see the second notification with the Hebrew text, it will be right-justified. When we click and see the "Pure English !!!" notication, because locale is RTL, we should expect to see: "!!! Pure English" and it should be right-justified, however, we still see "Pure English !!!", left justified.
> http://w3-03.ibm.com/globalization/page/publish/4353
> Ideally you should be able to just add   android:supportsRtl="true" to the manifest, however, this is doesn't seem to ne enough without setting the text direction to the locale for all of the dialogs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)