You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/28 11:35:55 UTC

[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request, #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

mbalassi opened a new pull request, #417:
URL: https://github.com/apache/flink-kubernetes-operator/pull/417

   This refactor introduces a new module called `flink-kubernetes-operator-api` and moves the CRD in said module with the aim of making the transitive dependencies of it as slim as possible via removing flink from the compile time dependency tree.
   
   In order to keep API compatibility for existing Java clients I opted against appending `api` to the base package name which is the best practice in flink. (E.g. moving `org.apache.flink.kubernetes.operator.crd` to `org.apache.flink.kubernetes.operator.api.crd`), we can choose to do this in a later point.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #417:
URL: https://github.com/apache/flink-kubernetes-operator/pull/417#discussion_r1008039551


##########
flink-kubernetes-operator/pom.xml:
##########
@@ -195,32 +202,6 @@ under the License.
         </resources>
 
         <plugins>
-            <plugin>

Review Comment:
   We should also move the `maven-antrun-plugin` usages for the backward compatibility check to the api plugin



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #417:
URL: https://github.com/apache/flink-kubernetes-operator/pull/417#discussion_r1008028628


##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/crd/status/ReconciliationMetadata.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.flink.kubernetes.operator.reconciler;
+package org.apache.flink.kubernetes.operator.crd.status;

Review Comment:
   I suggest keeping this out of the `crd` package. It is internal to the operator logic and moving it under the CRD pollutes the CRD ref docs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

Posted by GitBox <gi...@apache.org>.
gyfora merged PR #417:
URL: https://github.com/apache/flink-kubernetes-operator/pull/417


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #417:
URL: https://github.com/apache/flink-kubernetes-operator/pull/417#issuecomment-1296153291

   @tweise has pointed out to me that we actually do not guarantee Java API compatibility at this point, and consequently it is best to make the changes now necessary to be able to provide said guarantee later.
   https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/operations/compatibility/#java-api-compatibility


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

Posted by GitBox <gi...@apache.org>.
mbalassi commented on code in PR #417:
URL: https://github.com/apache/flink-kubernetes-operator/pull/417#discussion_r1008430526


##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/crd/status/ReconciliationMetadata.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.flink.kubernetes.operator.reconciler;
+package org.apache.flink.kubernetes.operator.crd.status;

Review Comment:
   Good catch, done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #417:
URL: https://github.com/apache/flink-kubernetes-operator/pull/417#issuecomment-1296941883

   Thanks, @gyfora. Moved the packages as you suggested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

Posted by GitBox <gi...@apache.org>.
mbalassi commented on code in PR #417:
URL: https://github.com/apache/flink-kubernetes-operator/pull/417#discussion_r1008457144


##########
flink-kubernetes-operator/pom.xml:
##########
@@ -195,32 +202,6 @@ under the License.
         </resources>
 
         <plugins>
-            <plugin>

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org