You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/31 14:35:00 UTC
[jira] [Commented] (AIRFLOW-6693) Make page titles distinguishable
from another
[ https://issues.apache.org/jira/browse/AIRFLOW-6693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027544#comment-17027544 ]
ASF GitHub Bot commented on AIRFLOW-6693:
-----------------------------------------
baecher commented on pull request #7305: [AIRFLOW-6693] Make page titles distinguishable from another
URL: https://github.com/apache/airflow/pull/7305
Improve navigation in the browser history and when having many open
Airflow tabs in the browser. This patch includes the DAG name in the
title (where applicable) and puts it in front so that tabs can be
told apart even when having many tabs open. Likewise, if the index page
is filtered, the search term is added in front.
Before:
After:
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Make page titles distinguishable from another
> ---------------------------------------------
>
> Key: AIRFLOW-6693
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6693
> Project: Apache Airflow
> Issue Type: Improvement
> Components: webserver
> Affects Versions: 2.0.0
> Reporter: Paul Baecher
> Assignee: Paul Baecher
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: 2020-01-29-095730_1916x1041_scrot.png
>
>
> The web server's page titles are virtually indistinguishable from another. As a result, both the browser history and many open Airflow tabs are almost impossible to navigate. See the following screenshot from a browser history.
> !2020-01-29-095730_1916x1041_scrot.png!
> I created a patch to fix this issue and will link it in a comment as soon as I have a ticket number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)