[GitHub] [qpid-dispatch] jdanekrh commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests

[GitBox <gi...@apache.org>]

jdanekrh commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests
URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336064713
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang")
   add_compile_options(-Wno-gnu-statement-expression)
 endif()
 
-if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN))
+if (APPLE)
 
 Review comment:
   Thanks for the head's up. Would you be OK if this gets merged before you get done? For APPLE, the important thing is never to set `"-Wl,-z,defs"`, because then the compile fails. No other considerations I know about, so far.
   
   Btw, there is apparently special automagical setting to enable sanitizers with XCODE
   
   ```
   cmake_minimum_required(VERSION 3.13)
   set(CMAKE_XCODE_GENERATE_SCHEME ON)
   set(CMAKE_XCODE_SCHEME_ADDRESS_SANITIZER ON)
   set(CMAKE_XCODE_SCHEME_ADDRESS_SANITIZER_USE_AFTER_RETURN ON)
   ```
   
   https://stackoverflow.com/questions/44320465/whats-the-proper-way-to-enable-addresssanitizer-in-cmake-that-works-in-xcode
   
   Probably something that can be safely ignored for now.
   
   I was wondering if "modern" CMake has special support for Valgrind, and so on, but I found nothing. It has e.g. support for cppcheck, though, https://cmake.org/cmake/help/v3.10/prop_tgt/LANG_CPPCHECK.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org