You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "philipnee (via GitHub)" <gi...@apache.org> on 2023/02/15 04:17:05 UTC
[GitHub] [kafka] philipnee opened a new pull request, #13253: KAFKA-14253 - More informative logging
philipnee opened a new pull request, #13253:
URL: https://github.com/apache/kafka/pull/13253
Includes 2 requirements from the ticket:
- Include the number of members in the group (I.e., "15 members participating" and "to 15 clients as")
- sort the member ids (to help compare the membership and assignment across rebalances)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] philipnee commented on pull request #13253: KAFKA-14253 - More informative logging
Posted by "philipnee (via GitHub)" <gi...@apache.org>.
philipnee commented on PR #13253:
URL: https://github.com/apache/kafka/pull/13253#issuecomment-1433651333
Failures seem unrelated
```
Build / JDK 11 and Scala 2.13 / testReplicationIsCreatingTopicsUsingProvidedForwardingAdmin() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest
2m 15s
Build / JDK 11 and Scala 2.13 / testReplicationIsCreatingTopicsUsingProvidedForwardingAdmin() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest
2m 22s
Build / JDK 8 and Scala 2.12 / testCreatePartitionsUseProvidedForwardingAdmin() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest
2m 20s
Build / JDK 8 and Scala 2.12 / testConnectorReconfiguration – org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest
33s
Build / JDK 8 and Scala 2.12 / [1] Type=ZK, Name=testRegisterZkBrokerInKraft, MetadataVersion=3.4-IV0, Security=PLAINTEXT – kafka.server.KafkaServerKRaftRegistrationTest
8s
Build / JDK 8 and Scala 2.12 / [1] Type=ZK, Name=testRestartOldIbpZkBrokerInMigrationMode, MetadataVersion=3.3-IV0, Security=PLAINTEXT – kafka.server.KafkaServerKRaftRegistrationTest
4s
Build / JDK 8 and Scala 2.12 / [1] false – org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest
7m 15s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] philipnee commented on a diff in pull request #13253: KAFKA-14253 - More informative logging
Posted by "philipnee (via GitHub)" <gi...@apache.org>.
philipnee commented on code in PR #13253:
URL: https://github.com/apache/kafka/pull/13253#discussion_r1107866090
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -637,8 +638,12 @@ private boolean assignTasksToClients(final Cluster fullMetadata,
statefulTasks,
assignmentConfigs);
- log.info("Assigned tasks {} including stateful {} to clients as: \n{}.",
- allTasks, statefulTasks, clientStates.entrySet().stream()
+ log.info("{} assigned tasks {} including stateful {} to clients as: \n{}.",
Review Comment:
Ah, acked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on a diff in pull request #13253: KAFKA-14253 - More informative logging
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang commented on code in PR #13253:
URL: https://github.com/apache/kafka/pull/13253#discussion_r1107854555
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -637,8 +638,12 @@ private boolean assignTasksToClients(final Cluster fullMetadata,
statefulTasks,
assignmentConfigs);
- log.info("Assigned tasks {} including stateful {} to clients as: \n{}.",
- allTasks, statefulTasks, clientStates.entrySet().stream()
+ log.info("{} assigned tasks {} including stateful {} to clients as: \n{}.",
Review Comment:
nit: Assigned {} tasks including ... to {} clients as ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #13253: KAFKA-14253 - More informative logging
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang merged PR #13253:
URL: https://github.com/apache/kafka/pull/13253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] philipnee commented on pull request #13253: KAFKA-14253 - More informative logging
Posted by "philipnee (via GitHub)" <gi...@apache.org>.
philipnee commented on PR #13253:
URL: https://github.com/apache/kafka/pull/13253#issuecomment-1432116469
Ideally, we want "1 member" or "n member**s**". But we don't need this much grammatical optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org