[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #789: feat: Initial support for Gateway API

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #789:
URL: https://github.com/apache/apisix-ingress-controller/pull/789#discussion_r765371751



##########
File path: cmd/ingress/ingress.go
##########
@@ -158,6 +158,7 @@ For example, no available LB exists in the bare metal environment.`)
 	cmd.PersistentFlags().StringVar(&cfg.Kubernetes.IngressVersion, "ingress-version", config.IngressNetworkingV1, "the supported ingress api group version, can be \"networking/v1beta1\", \"networking/v1\" (for Kubernetes version v1.19.0 or higher) and \"extensions/v1beta1\"")
 	cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixRouteVersion, "apisix-route-version", config.ApisixRouteV2beta3, "the supported apisixroute api group version, can be \"apisix.apache.org/v2beta1\" or \"apisix.apache.org/v2beta2\" or \"apisix.apache.org/v2beta3\"")
 	cmd.PersistentFlags().BoolVar(&cfg.Kubernetes.WatchEndpointSlices, "watch-endpointslices", false, "whether to watch endpointslices rather than endpoints")
+	cmd.PersistentFlags().BoolVar(&cfg.Kubernetes.EnableGateway, "enable-gateway", false, "whether to enable support for Gateway API")

Review comment:
       ```suggestion
   	cmd.PersistentFlags().BoolVar(&cfg.Kubernetes.EnableGateway, "enable-gateway-api", false, "whether to enable support for Gateway API")
   ```

##########
File path: conf/config-default.yaml
##########
@@ -72,6 +72,12 @@ kubernetes:
 
   apisix_route_version: "apisix.apache.org/v2beta3"  # the supported apisixroute api group version.
                                                      # the latest version is "apisix.apache.org/v2beta3".
+
+  enable_gateway: false                # whether to enable support for Gateway API.

Review comment:
       ```suggestion
     enable_gateway_api: false                # whether to enable support for Gateway API.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org