You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Weiwei Yang <ch...@hotmail.com> on 2016/11/28 12:59:14 UTC
Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/
-----------------------------------------------------------
Review request for Ambari and Di Li.
Repository: ambari
Description
-------
Improve the logic of yarn service check, let it work as long as active RM is working fine
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
Diff: https://reviews.apache.org/r/54121/diff/
Testing
-------
HA environment
1. Both active & standby RMs are up : SUCCESS
2. Shutdown standby RM, active remains up : SUCCESS
3. Shutdown active RM, active transited to the other RM : SUCCESS
4. Shutdown zookeeper, both RMs are standby : FAIL
5. Both RMs are down : FAIL
Non-HA environment
1. RM is up : SUCCESS
2. RM is down : FAIL
Thanks,
Weiwei Yang
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Weiwei Yang <ch...@hotmail.com>.
> On \u5341\u4e00\u6708 28, 2016, 3:51 p.m., Di Li wrote:
> > Hello Wei Wei,
> >
> > Could you please add "AMBARI-18929" to the "Bugs:" field ?
Sure, just added that. Thank you.
- Weiwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review157039
-----------------------------------------------------------
On \u5341\u4e00\u6708 28, 2016, 3:55 p.m., Weiwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e00\u6708 28, 2016, 3:55 p.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Bugs: AMBARI-18929
> https://issues.apache.org/jira/browse/AMBARI-18929
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve the logic of yarn service check, let it work as long as active RM is working fine
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
>
> Diff: https://reviews.apache.org/r/54121/diff/
>
>
> Testing
> -------
>
> HA environment
> 1. Both active & standby RMs are up : SUCCESS
> 2. Shutdown standby RM, active remains up : SUCCESS
> 3. Shutdown active RM, active transited to the other RM : SUCCESS
> 4. Shutdown zookeeper, both RMs are standby : FAIL
> 5. Both RMs are down : FAIL
>
> Non-HA environment
> 1. RM is up : SUCCESS
> 2. RM is down : FAIL
>
>
> Thanks,
>
> Weiwei Yang
>
>
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review157039
-----------------------------------------------------------
Hello Wei Wei,
Could you please add "AMBARI-18929" to the "Bugs:" field ?
- Di Li
On Nov. 28, 2016, 12:59 p.m., Weiwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 12:59 p.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve the logic of yarn service check, let it work as long as active RM is working fine
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
>
> Diff: https://reviews.apache.org/r/54121/diff/
>
>
> Testing
> -------
>
> HA environment
> 1. Both active & standby RMs are up : SUCCESS
> 2. Shutdown standby RM, active remains up : SUCCESS
> 3. Shutdown active RM, active transited to the other RM : SUCCESS
> 4. Shutdown zookeeper, both RMs are standby : FAIL
> 5. Both RMs are down : FAIL
>
> Non-HA environment
> 1. RM is up : SUCCESS
> 2. RM is down : FAIL
>
>
> Thanks,
>
> Weiwei Yang
>
>
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review157036
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On Nov. 28, 2016, 12:59 p.m., Weiwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 12:59 p.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve the logic of yarn service check, let it work as long as active RM is working fine
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
>
> Diff: https://reviews.apache.org/r/54121/diff/
>
>
> Testing
> -------
>
> HA environment
> 1. Both active & standby RMs are up : SUCCESS
> 2. Shutdown standby RM, active remains up : SUCCESS
> 3. Shutdown active RM, active transited to the other RM : SUCCESS
> 4. Shutdown zookeeper, both RMs are standby : FAIL
> 5. Both RMs are down : FAIL
>
> Non-HA environment
> 1. RM is up : SUCCESS
> 2. RM is down : FAIL
>
>
> Thanks,
>
> Weiwei Yang
>
>
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Weiwei Yang <ch...@hotmail.com>.
> On \u5341\u4e00\u6708 28, 2016, 7:07 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py, line 134
> > <https://reviews.apache.org/r/54121/diff/1/?file=1571048#file1571048line134>
> >
> > Please put this into its own function.
> > get_active_rm_webapp_address
Hello Alejandro
I have addressed your comment and uploaded a new patch. Please helo to review, thanks a lot.
- Weiwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review157111
-----------------------------------------------------------
On \u5341\u4e00\u6708 29, 2016, 3:56 a.m., Weiwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e00\u6708 29, 2016, 3:56 a.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Bugs: AMBARI-18929
> https://issues.apache.org/jira/browse/AMBARI-18929
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve the logic of yarn service check, let it work as long as active RM is working fine
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
>
> Diff: https://reviews.apache.org/r/54121/diff/
>
>
> Testing
> -------
>
> HA environment
> 1. Both active & standby RMs are up : SUCCESS
> 2. Shutdown standby RM, active remains up : SUCCESS
> 3. Shutdown active RM, active transited to the other RM : SUCCESS
> 4. Shutdown zookeeper, both RMs are standby : FAIL
> 5. Both RMs are down : FAIL
>
> Non-HA environment
> 1. RM is up : SUCCESS
> 2. RM is down : FAIL
>
>
> Thanks,
>
> Weiwei Yang
>
>
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review157111
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py (line 134)
<https://reviews.apache.org/r/54121/#comment227529>
Please put this into its own function.
get_active_rm_webapp_address
- Alejandro Fernandez
On Nov. 28, 2016, 3:55 p.m., Weiwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 3:55 p.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Bugs: AMBARI-18929
> https://issues.apache.org/jira/browse/AMBARI-18929
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve the logic of yarn service check, let it work as long as active RM is working fine
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
>
> Diff: https://reviews.apache.org/r/54121/diff/
>
>
> Testing
> -------
>
> HA environment
> 1. Both active & standby RMs are up : SUCCESS
> 2. Shutdown standby RM, active remains up : SUCCESS
> 3. Shutdown active RM, active transited to the other RM : SUCCESS
> 4. Shutdown zookeeper, both RMs are standby : FAIL
> 5. Both RMs are down : FAIL
>
> Non-HA environment
> 1. RM is up : SUCCESS
> 2. RM is down : FAIL
>
>
> Thanks,
>
> Weiwei Yang
>
>
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review157397
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On Nov. 29, 2016, 3:56 a.m., Weiwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 3:56 a.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Bugs: AMBARI-18929
> https://issues.apache.org/jira/browse/AMBARI-18929
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve the logic of yarn service check, let it work as long as active RM is working fine
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
>
> Diff: https://reviews.apache.org/r/54121/diff/
>
>
> Testing
> -------
>
> HA environment
> 1. Both active & standby RMs are up : SUCCESS
> 2. Shutdown standby RM, active remains up : SUCCESS
> 3. Shutdown active RM, active transited to the other RM : SUCCESS
> 4. Shutdown zookeeper, both RMs are standby : FAIL
> 5. Both RMs are down : FAIL
>
> Non-HA environment
> 1. RM is up : SUCCESS
> 2. RM is down : FAIL
>
>
> Thanks,
>
> Weiwei Yang
>
>
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review157441
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Nov. 29, 2016, 3:56 a.m., Weiwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 3:56 a.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Bugs: AMBARI-18929
> https://issues.apache.org/jira/browse/AMBARI-18929
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve the logic of yarn service check, let it work as long as active RM is working fine
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
>
> Diff: https://reviews.apache.org/r/54121/diff/
>
>
> Testing
> -------
>
> HA environment
> 1. Both active & standby RMs are up : SUCCESS
> 2. Shutdown standby RM, active remains up : SUCCESS
> 3. Shutdown active RM, active transited to the other RM : SUCCESS
> 4. Shutdown zookeeper, both RMs are standby : FAIL
> 5. Both RMs are down : FAIL
>
> Non-HA environment
> 1. RM is up : SUCCESS
> 2. RM is down : FAIL
>
>
> Thanks,
>
> Weiwei Yang
>
>
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Weiwei Yang <ch...@hotmail.com>.
> On \u5341\u4e8c\u6708 7, 2016, 5:08 p.m., Di Li wrote:
> > hi Wei Wei,
> >
> > Can you close this one ? The corresponding JIRA is resolved now.
Done, thanks.
- Weiwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review158350
-----------------------------------------------------------
On \u5341\u4e00\u6708 29, 2016, 3:56 a.m., Weiwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e00\u6708 29, 2016, 3:56 a.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Bugs: AMBARI-18929
> https://issues.apache.org/jira/browse/AMBARI-18929
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve the logic of yarn service check, let it work as long as active RM is working fine
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
>
> Diff: https://reviews.apache.org/r/54121/diff/
>
>
> Testing
> -------
>
> HA environment
> 1. Both active & standby RMs are up : SUCCESS
> 2. Shutdown standby RM, active remains up : SUCCESS
> 3. Shutdown active RM, active transited to the other RM : SUCCESS
> 4. Shutdown zookeeper, both RMs are standby : FAIL
> 5. Both RMs are down : FAIL
>
> Non-HA environment
> 1. RM is up : SUCCESS
> 2. RM is down : FAIL
>
>
> Thanks,
>
> Weiwei Yang
>
>
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review158350
-----------------------------------------------------------
hi Wei Wei,
Can you close this one ? The corresponding JIRA is resolved now.
- Di Li
On Nov. 29, 2016, 3:56 a.m., Weiwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 3:56 a.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Bugs: AMBARI-18929
> https://issues.apache.org/jira/browse/AMBARI-18929
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve the logic of yarn service check, let it work as long as active RM is working fine
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
>
> Diff: https://reviews.apache.org/r/54121/diff/
>
>
> Testing
> -------
>
> HA environment
> 1. Both active & standby RMs are up : SUCCESS
> 2. Shutdown standby RM, active remains up : SUCCESS
> 3. Shutdown active RM, active transited to the other RM : SUCCESS
> 4. Shutdown zookeeper, both RMs are standby : FAIL
> 5. Both RMs are down : FAIL
>
> Non-HA environment
> 1. RM is up : SUCCESS
> 2. RM is down : FAIL
>
>
> Thanks,
>
> Weiwei Yang
>
>
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Weiwei Yang <ch...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/
-----------------------------------------------------------
(Updated \u5341\u4e00\u6708 29, 2016, 3:56 a.m.)
Review request for Ambari and Di Li.
Changes
-------
Add a function get_active_rm_webapp_address to get active RM address.
Bugs: AMBARI-18929
https://issues.apache.org/jira/browse/AMBARI-18929
Repository: ambari
Description
-------
Improve the logic of yarn service check, let it work as long as active RM is working fine
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
Diff: https://reviews.apache.org/r/54121/diff/
Testing
-------
HA environment
1. Both active & standby RMs are up : SUCCESS
2. Shutdown standby RM, active remains up : SUCCESS
3. Shutdown active RM, active transited to the other RM : SUCCESS
4. Shutdown zookeeper, both RMs are standby : FAIL
5. Both RMs are down : FAIL
Non-HA environment
1. RM is up : SUCCESS
2. RM is down : FAIL
Thanks,
Weiwei Yang
Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when
either resource manager is down in HA enabled cluster
Posted by Weiwei Yang <ch...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/
-----------------------------------------------------------
(Updated \u5341\u4e00\u6708 28, 2016, 3:55 p.m.)
Review request for Ambari and Di Li.
Bugs: AMBARI-18929
https://issues.apache.org/jira/browse/AMBARI-18929
Repository: ambari
Description
-------
Improve the logic of yarn service check, let it work as long as active RM is working fine
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py c0bd480
ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py bb671aa
Diff: https://reviews.apache.org/r/54121/diff/
Testing
-------
HA environment
1. Both active & standby RMs are up : SUCCESS
2. Shutdown standby RM, active remains up : SUCCESS
3. Shutdown active RM, active transited to the other RM : SUCCESS
4. Shutdown zookeeper, both RMs are standby : FAIL
5. Both RMs are down : FAIL
Non-HA environment
1. RM is up : SUCCESS
2. RM is down : FAIL
Thanks,
Weiwei Yang