You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/28 16:31:12 UTC

[GitHub] [flink] aljoscha commented on a change in pull request #13828: [FLINK-19835] Don't emit intermediate watermarks from sources in BATCH execution mode

aljoscha commented on a change in pull request #13828:
URL: https://github.com/apache/flink/pull/13828#discussion_r513588833



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -254,4 +269,10 @@ private void registerReader() {
 	ListState<SplitT> getReaderState() {
 		return readerState;
 	}
+
+	// Not really meant to be here, this is an example.
+	// TODO: Should we use RuntimeExecutionMode here? I don't like that that one has AUTOMATIC.
+	public enum RuntimeMode {
+		BATCH, STREAMING

Review comment:
       I lately try to use more enums than boolean because it's easier to maintain and understand at a glance. Compare `doSomething(13, true, false)` vs. `doSomething(13, STREAMING, EXACTLY_ONCE)`. But yes, here it's just a "custom" boolean. 😅 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org