You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/02/05 16:33:00 UTC

[jira] [Commented] (KNOX-2224) KnoxLine and KnoxShell DataSource and Select Command Alignment

    [ https://issues.apache.org/jira/browse/KNOX-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030785#comment-17030785 ] 

ASF subversion and git services commented on KNOX-2224:
-------------------------------------------------------

Commit 4c79ca3eb1f4d0a42712255200049406d173a0c8 in knox's branch refs/heads/master from Larry McCay
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=4c79ca3 ]

KNOX-2224 - KnoxLine and KnoxShell DataSource and Select Command Alignment (#255)

* KNOX-1742 - add to knoxshell usage rendering

* KNOX-2204 - KnoxLine NPE list datasources when directories don't exist

* KNOX-2224 - KnoxLine and KnoxShell DataSource and Select Command Alignment

Change-Id: I55aef2dd7617baf10c5f9eb7706f61436aa3ad7d


> KnoxLine and KnoxShell DataSource and Select Command Alignment
> --------------------------------------------------------------
>
>                 Key: KNOX-2224
>                 URL: https://issues.apache.org/jira/browse/KNOX-2224
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: KnoxShell
>            Reporter: Larry McCay
>            Assignee: Larry McCay
>            Priority: Major
>             Fix For: 1.4.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The KnoxLine shell environment datasource selection creates the connection for the session. The connection is kept for the session or until datasource select is used to create a connection to a new datasource. Each SQL query continues to use the same connection. The connections are cleaned up and closed through a shutdown hook for the KnoxLine environment.
> In the interactive KnoxShell there are Custom Groovy Commands for datasource management and SQL queries submission. The life of the connection is limited to each command rather than being able to be used again in subsequent queries. Connections are closed for each query. This requires a new connection and login per query - since login isn't done at datasource selection time like it is in KnoxLine.
> This change aligns the two environments. Connections are managed at the shell environment level rather than at the command level. Connections are created when selecting datasources rather than and SQL query invocation. Connections are cleaned up in the interactive shell through a shutdown hook.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)