You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flagon.apache.org by GitBox <gi...@apache.org> on 2022/04/28 15:02:44 UTC
[GitHub] [incubator-flagon] brucearctor opened a new pull request, #25: typos
brucearctor opened a new pull request, #25:
URL: https://github.com/apache/incubator-flagon/pull/25
Resolved a couple things in docs that seemed like typos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@flagon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon] brucearctor commented on pull request #25: typos
Posted by GitBox <gi...@apache.org>.
brucearctor commented on PR #25:
URL: https://github.com/apache/incubator-flagon/pull/25#issuecomment-1155342004
I don't know Flagon's conventions ... What have we arrived at for when is OK to merge? Even if a committer [ and innocuous change ] -- should I get a LGTM from a committer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@flagon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon] brucearctor commented on pull request #25: typos
Posted by GitBox <gi...@apache.org>.
brucearctor commented on PR #25:
URL: https://github.com/apache/incubator-flagon/pull/25#issuecomment-1155626110
@UncleGedd -- I think I'll take that to dev list, so we have an archive of a discussion/resolution of when OK to merge. We should formalize general community conventions. Thinking ahead to potential community growth ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@flagon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon] UncleGedd commented on pull request #25: typos
Posted by GitBox <gi...@apache.org>.
UncleGedd commented on PR #25:
URL: https://github.com/apache/incubator-flagon/pull/25#issuecomment-1155623184
LGTM 😄
Sorry for the slow response on this @brucearctor. I'd recommend making a PR for all changes to solicit community feedback. That said, on small changes like this you can use your best judgement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@flagon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon] brucearctor merged pull request #25: typos
Posted by GitBox <gi...@apache.org>.
brucearctor merged PR #25:
URL: https://github.com/apache/incubator-flagon/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@flagon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org