You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@calcite.apache.org by Fan Liya <li...@apache.org> on 2022/03/05 09:56:40 UTC

[VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Hi all,

I have created a build for Apache Calcite 1.30.0, release
candidate 0.

Thanks to everyone who has contributed to this release.

You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md

The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e

Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e

Tag:
https://github.com/apache/calcite/tree/calcite-1.30.0-rc0

The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0
(revision 52873)

The hashes of the artifacts are as follows:
339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5
*apache-calcite-1.30.0-src.tar.gz

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/COMMITTER_ID.asc
https://www.apache.org/dist/calcite/KEYS

To create the jars and test Apache Calcite: "gradle build"
(requires an appropriate Gradle/JDK installation)

Please vote on releasing this package as Apache Calcite 1.30.0.

The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.

[ ] +1 Release this package as Apache Calcite 1.30.0
[ ]  0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...

Here is my vote:

+1 (binding)

Best,
Liya Fan

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Posted by Fan Liya <li...@gmail.com>.

Hi Zhe,

Thanks for the feedback.
When preparing the build, the command seemed to finish successfully (no
error/exception reported, and the return value was 0).
However, by checking the log, it seems the pushRcTag failed to push the tag
to remote (maybe it is because I am using a different name for the apache
repository, which is not "origin").
Now I have manually pushed the tag, so it should be showing the release
note of 1.30.0. Please check.

Best,
Liya Fan


Zhe Hu <il...@163.com> 于2022年3月5日周六 19:11写道：

> Hi, Fan Liya.
> Thanks for your great job of releasing Calcite 1.30.0.
> I’m trying to read the release notes in
> https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md.
> However, the latest version of this page is still 1.29.0. I’m not sure if
> it’s my permission issue or not. But I can read it in your PR(
> https://github.com/apache/calcite/pull/2739/files).
> By the way, +1 for this release.
>
>
> Best,
> ZheHu
> On 03/5/2022 17:56，Fan Liya<li...@apache.org> wrote：
> Hi all,
>
> I have created a build for Apache Calcite 1.30.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
>
> Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
>
> Tag:
> https://github.com/apache/calcite/tree/calcite-1.30.0-rc0
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0
> (revision 52873)
>
> The hashes of the artifacts are as follows:
>
> 339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5
> *apache-calcite-1.30.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/COMMITTER_ID.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite: "gradle build"
> (requires an appropriate Gradle/JDK installation)
>
> Please vote on releasing this package as Apache Calcite 1.30.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.30.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Here is my vote:
>
> +1 (binding)
>
> Best,
> Liya Fan
>

Re:[VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Posted by Zhe Hu <il...@163.com>.

Hi, Fan Liya.
Thanks for your great job of releasing Calcite 1.30.0. 
I’m trying to read the release notes in https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md. However, the latest version of this page is still 1.29.0. I’m not sure if it’s my permission issue or not. But I can read it in your PR(https://github.com/apache/calcite/pull/2739/files).
By the way, +1 for this release.


Best,
ZheHu
On 03/5/2022 17:56，Fan Liya<li...@apache.org> wrote：
Hi all,

I have created a build for Apache Calcite 1.30.0, release
candidate 0.

Thanks to everyone who has contributed to this release.

You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md

The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e

Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e

Tag:
https://github.com/apache/calcite/tree/calcite-1.30.0-rc0

The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0
(revision 52873)

The hashes of the artifacts are as follows:
339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5
*apache-calcite-1.30.0-src.tar.gz

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/COMMITTER_ID.asc
https://www.apache.org/dist/calcite/KEYS

To create the jars and test Apache Calcite: "gradle build"
(requires an appropriate Gradle/JDK installation)

Please vote on releasing this package as Apache Calcite 1.30.0.

The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.

[ ] +1 Release this package as Apache Calcite 1.30.0
[ ]  0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...

Here is my vote:

+1 (binding)

Best,
Liya Fan

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Posted by Fan Liya <li...@gmail.com>.

Since it is during the weekend, let's extend the voting period to at least
96 hours.

Best,
Liya Fan


Fan Liya <li...@apache.org> 于2022年3月5日周六 17:56写道：

> Hi all,
>
> I have created a build for Apache Calcite 1.30.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
>
> Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
>
> Tag:
> https://github.com/apache/calcite/tree/calcite-1.30.0-rc0
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0
> (revision 52873)
>
> The hashes of the artifacts are as follows:
>
> 339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5
> *apache-calcite-1.30.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/COMMITTER_ID.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite: "gradle build"
> (requires an appropriate Gradle/JDK installation)
>
> Please vote on releasing this package as Apache Calcite 1.30.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.30.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Here is my vote:
>
> +1 (binding)
>
> Best,
> Liya Fan
>
>

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Posted by Fan Liya <li...@gmail.com>.

Hi Ruben,

Thanks for your suggestion. Let's go ahead with it.

Best,
Liya Fan


Ruben Q L <ru...@gmail.com> 于2022年3月8日周二 07:49写道：

> Hello Liya Fan,
>
> please be aware that, normally, when there are issues ONLY on the release
> notes, we do not require a new RC (they can be amended afterwards with a
> commit right after the release).
> So, I'd say that for the moment we can just cancel RC0 vote (an email
> "[CANCEL] [VOTE] Release Apache Calcite1.30.0 (release candidate 0)" should
> be sent to make it official), and keep RC1 vote open.
>
> Best,
> Ruben
>
>
> On Mon, Mar 7, 2022 at 11:34 PM Fan Liya <li...@gmail.com> wrote:
>
> > Hi Julian,
> >
> > Thanks for your feedback. I will prepare another build, after addressing
> > these issues.
> >
> > Best,
> > Liya Fan
> >
> >
> > Julian Hyde <jh...@gmail.com> 于2022年3月8日周二 04:50写道：
> >
> > > Liya, in the next iteration can you go back to the usual sections e.g
> > > “Bug-fixes, API changes and minor enhancements”. Also remove the “Fix”
> > > prefix from messages.
> > >
> > > Quite a few cases, e.g “ Fix the problem that JDBC adapter incorrectly
> > > adds ORDER BY columns to the SELECT list of generated SQL query” are in
> > the
> > > gray area between bug and missing feature, and using the original
> message
> > > helps people make their own decision.
> > >
> > > I also think there’s value in putting changes to build and test in a
> > > separate section, as we used to do. But please move my “Fluent test
> > > fixtures” into the “new features” section - because it is a major new
> > > feature.
> > >
> > > Julian
> > >
> > > > On Mar 6, 2022, at 10:31 PM, Francis Chuang <
> francischuang@apache.org>
> > > wrote:
> > > >
> > > > Thanks so much Liya! Please cancel this vote by sending a [CANCEL]
> > > message as well, to formalize the cancellation of this vote.
> > > >
> > > > Francis
> > > >
> > > >> On 7/03/2022 5:27 pm, Fan Liya wrote:
> > > >> After some investigation, I could not resolve the 404 issue of the
> > > commit
> > > >> link (In my computer, it is not 404, but an error with XML format).
> > > >> So I have created a new build, which has resolved all the above
> issues
> > > >> (according to the test on my local computer).
> > > >> Let's start another vote based on the new build. Thanks.
> > > >> Best,
> > > >> Liya Fan
> > > >> Fan Liya <li...@gmail.com> 于2022年3月7日周一 09:53写道：
> > > >>> Thanks for your feedback, Francis.
> > > >>> I will check.
> > > >>>
> > > >>> Best,
> > > >>> Liya Fan
> > > >>>
> > > >>>
> > > >>> Francis Chuang <fr...@apache.org> 于2022年3月7日周一 09:36写道：
> > > >>>
> > > >>>> Hey Liya,
> > > >>>>
> > > >>>> Thanks for being RM for this release.
> > > >>>>
> > > >>>> Can you check the commit to be voted upon?
> > > >>>>
> > > >>>>
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> > > >>>> returns a 404
> > > >>>>
> > > >>>> Also, tag calcite-1.30.0-rc0 points to a39b9bf
> > > >>>> (
> https://github.com/apache/calcite/releases/tag/calcite-1.30.0-rc0
> > ),
> > > >>>> which does not seem to be in the Calcite repository, see:
> > > >>>>
> > > >>>>
> > >
> >
> https://github.com/apache/calcite/commit/a39b9bf8b1cbab8f4462c41f6b4506753f859f96
> > > >>>>
> > > >>>> Thanks!
> > > >>>> Francis
> > > >>>>
> > > >>>> On 5/03/2022 8:56 pm, Fan Liya wrote:
> > > >>>>> Hi all,
> > > >>>>>
> > > >>>>> I have created a build for Apache Calcite 1.30.0, release
> > > >>>>> candidate 0.
> > > >>>>>
> > > >>>>> Thanks to everyone who has contributed to this release.
> > > >>>>>
> > > >>>>> You can read the release notes here:
> > > >>>>>
> > > >>>>
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md
> > > >>>>>
> > > >>>>> The commit to be voted upon:
> > > >>>>>
> > > >>>>
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> > > >>>>>
> > > >>>>> Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> > > >>>>>
> > > >>>>> Tag:
> > > >>>>> https://github.com/apache/calcite/tree/calcite-1.30.0-rc0
> > > >>>>>
> > > >>>>> The artifacts to be voted on are located here:
> > > >>>>>
> > > >>>>
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0
> > > >>>>> (revision 52873)
> > > >>>>>
> > > >>>>> The hashes of the artifacts are as follows:
> > > >>>>>
> > > >>>>
> > >
> >
> 339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5
> > > >>>>> *apache-calcite-1.30.0-src.tar.gz
> > > >>>>>
> > > >>>>> A staged Maven repository is available for review at:
> > > >>>>>
> > > >>>>
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/
> > > >>>>>
> > > >>>>> Release artifacts are signed with the following key:
> > > >>>>> https://people.apache.org/keys/committer/COMMITTER_ID.asc
> > > >>>>> https://www.apache.org/dist/calcite/KEYS
> > > >>>>>
> > > >>>>> To create the jars and test Apache Calcite: "gradle build"
> > > >>>>> (requires an appropriate Gradle/JDK installation)
> > > >>>>>
> > > >>>>> Please vote on releasing this package as Apache Calcite 1.30.0.
> > > >>>>>
> > > >>>>> The vote is open for the next 72 hours and passes if a majority
> of
> > at
> > > >>>>> least three +1 PMC votes are cast.
> > > >>>>>
> > > >>>>> [ ] +1 Release this package as Apache Calcite 1.30.0
> > > >>>>> [ ]  0 I don't feel strongly about it, but I'm okay with the
> > release
> > > >>>>> [ ] -1 Do not release this package because...
> > > >>>>>
> > > >>>>> Here is my vote:
> > > >>>>>
> > > >>>>> +1 (binding)
> > > >>>>>
> > > >>>>> Best,
> > > >>>>> Liya Fan
> > > >>>>>
> > > >>>>
> > > >>>
> > >
> >
>

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Posted by Ruben Q L <ru...@gmail.com>.

Hello Liya Fan,

please be aware that, normally, when there are issues ONLY on the release
notes, we do not require a new RC (they can be amended afterwards with a
commit right after the release).
So, I'd say that for the moment we can just cancel RC0 vote (an email
"[CANCEL] [VOTE] Release Apache Calcite1.30.0 (release candidate 0)" should
be sent to make it official), and keep RC1 vote open.

Best,
Ruben


On Mon, Mar 7, 2022 at 11:34 PM Fan Liya <li...@gmail.com> wrote:

> Hi Julian,
>
> Thanks for your feedback. I will prepare another build, after addressing
> these issues.
>
> Best,
> Liya Fan
>
>
> Julian Hyde <jh...@gmail.com> 于2022年3月8日周二 04:50写道：
>
> > Liya, in the next iteration can you go back to the usual sections e.g
> > “Bug-fixes, API changes and minor enhancements”. Also remove the “Fix”
> > prefix from messages.
> >
> > Quite a few cases, e.g “ Fix the problem that JDBC adapter incorrectly
> > adds ORDER BY columns to the SELECT list of generated SQL query” are in
> the
> > gray area between bug and missing feature, and using the original message
> > helps people make their own decision.
> >
> > I also think there’s value in putting changes to build and test in a
> > separate section, as we used to do. But please move my “Fluent test
> > fixtures” into the “new features” section - because it is a major new
> > feature.
> >
> > Julian
> >
> > > On Mar 6, 2022, at 10:31 PM, Francis Chuang <fr...@apache.org>
> > wrote:
> > >
> > > Thanks so much Liya! Please cancel this vote by sending a [CANCEL]
> > message as well, to formalize the cancellation of this vote.
> > >
> > > Francis
> > >
> > >> On 7/03/2022 5:27 pm, Fan Liya wrote:
> > >> After some investigation, I could not resolve the 404 issue of the
> > commit
> > >> link (In my computer, it is not 404, but an error with XML format).
> > >> So I have created a new build, which has resolved all the above issues
> > >> (according to the test on my local computer).
> > >> Let's start another vote based on the new build. Thanks.
> > >> Best,
> > >> Liya Fan
> > >> Fan Liya <li...@gmail.com> 于2022年3月7日周一 09:53写道：
> > >>> Thanks for your feedback, Francis.
> > >>> I will check.
> > >>>
> > >>> Best,
> > >>> Liya Fan
> > >>>
> > >>>
> > >>> Francis Chuang <fr...@apache.org> 于2022年3月7日周一 09:36写道：
> > >>>
> > >>>> Hey Liya,
> > >>>>
> > >>>> Thanks for being RM for this release.
> > >>>>
> > >>>> Can you check the commit to be voted upon?
> > >>>>
> > >>>>
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> > >>>> returns a 404
> > >>>>
> > >>>> Also, tag calcite-1.30.0-rc0 points to a39b9bf
> > >>>> (https://github.com/apache/calcite/releases/tag/calcite-1.30.0-rc0
> ),
> > >>>> which does not seem to be in the Calcite repository, see:
> > >>>>
> > >>>>
> >
> https://github.com/apache/calcite/commit/a39b9bf8b1cbab8f4462c41f6b4506753f859f96
> > >>>>
> > >>>> Thanks!
> > >>>> Francis
> > >>>>
> > >>>> On 5/03/2022 8:56 pm, Fan Liya wrote:
> > >>>>> Hi all,
> > >>>>>
> > >>>>> I have created a build for Apache Calcite 1.30.0, release
> > >>>>> candidate 0.
> > >>>>>
> > >>>>> Thanks to everyone who has contributed to this release.
> > >>>>>
> > >>>>> You can read the release notes here:
> > >>>>>
> > >>>>
> >
> https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md
> > >>>>>
> > >>>>> The commit to be voted upon:
> > >>>>>
> > >>>>
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> > >>>>>
> > >>>>> Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> > >>>>>
> > >>>>> Tag:
> > >>>>> https://github.com/apache/calcite/tree/calcite-1.30.0-rc0
> > >>>>>
> > >>>>> The artifacts to be voted on are located here:
> > >>>>>
> > >>>>
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0
> > >>>>> (revision 52873)
> > >>>>>
> > >>>>> The hashes of the artifacts are as follows:
> > >>>>>
> > >>>>
> >
> 339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5
> > >>>>> *apache-calcite-1.30.0-src.tar.gz
> > >>>>>
> > >>>>> A staged Maven repository is available for review at:
> > >>>>>
> > >>>>
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/
> > >>>>>
> > >>>>> Release artifacts are signed with the following key:
> > >>>>> https://people.apache.org/keys/committer/COMMITTER_ID.asc
> > >>>>> https://www.apache.org/dist/calcite/KEYS
> > >>>>>
> > >>>>> To create the jars and test Apache Calcite: "gradle build"
> > >>>>> (requires an appropriate Gradle/JDK installation)
> > >>>>>
> > >>>>> Please vote on releasing this package as Apache Calcite 1.30.0.
> > >>>>>
> > >>>>> The vote is open for the next 72 hours and passes if a majority of
> at
> > >>>>> least three +1 PMC votes are cast.
> > >>>>>
> > >>>>> [ ] +1 Release this package as Apache Calcite 1.30.0
> > >>>>> [ ]  0 I don't feel strongly about it, but I'm okay with the
> release
> > >>>>> [ ] -1 Do not release this package because...
> > >>>>>
> > >>>>> Here is my vote:
> > >>>>>
> > >>>>> +1 (binding)
> > >>>>>
> > >>>>> Best,
> > >>>>> Liya Fan
> > >>>>>
> > >>>>
> > >>>
> >
>

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Posted by Fan Liya <li...@gmail.com>.

Hi Julian,

Thanks for your feedback. I will prepare another build, after addressing
these issues.

Best,
Liya Fan


Julian Hyde <jh...@gmail.com> 于2022年3月8日周二 04:50写道：

> Liya, in the next iteration can you go back to the usual sections e.g
> “Bug-fixes, API changes and minor enhancements”. Also remove the “Fix”
> prefix from messages.
>
> Quite a few cases, e.g “ Fix the problem that JDBC adapter incorrectly
> adds ORDER BY columns to the SELECT list of generated SQL query” are in the
> gray area between bug and missing feature, and using the original message
> helps people make their own decision.
>
> I also think there’s value in putting changes to build and test in a
> separate section, as we used to do. But please move my “Fluent test
> fixtures” into the “new features” section - because it is a major new
> feature.
>
> Julian
>
> > On Mar 6, 2022, at 10:31 PM, Francis Chuang <fr...@apache.org>
> wrote:
> >
> > Thanks so much Liya! Please cancel this vote by sending a [CANCEL]
> message as well, to formalize the cancellation of this vote.
> >
> > Francis
> >
> >> On 7/03/2022 5:27 pm, Fan Liya wrote:
> >> After some investigation, I could not resolve the 404 issue of the
> commit
> >> link (In my computer, it is not 404, but an error with XML format).
> >> So I have created a new build, which has resolved all the above issues
> >> (according to the test on my local computer).
> >> Let's start another vote based on the new build. Thanks.
> >> Best,
> >> Liya Fan
> >> Fan Liya <li...@gmail.com> 于2022年3月7日周一 09:53写道：
> >>> Thanks for your feedback, Francis.
> >>> I will check.
> >>>
> >>> Best,
> >>> Liya Fan
> >>>
> >>>
> >>> Francis Chuang <fr...@apache.org> 于2022年3月7日周一 09:36写道：
> >>>
> >>>> Hey Liya,
> >>>>
> >>>> Thanks for being RM for this release.
> >>>>
> >>>> Can you check the commit to be voted upon?
> >>>>
> >>>>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> >>>> returns a 404
> >>>>
> >>>> Also, tag calcite-1.30.0-rc0 points to a39b9bf
> >>>> (https://github.com/apache/calcite/releases/tag/calcite-1.30.0-rc0),
> >>>> which does not seem to be in the Calcite repository, see:
> >>>>
> >>>>
> https://github.com/apache/calcite/commit/a39b9bf8b1cbab8f4462c41f6b4506753f859f96
> >>>>
> >>>> Thanks!
> >>>> Francis
> >>>>
> >>>> On 5/03/2022 8:56 pm, Fan Liya wrote:
> >>>>> Hi all,
> >>>>>
> >>>>> I have created a build for Apache Calcite 1.30.0, release
> >>>>> candidate 0.
> >>>>>
> >>>>> Thanks to everyone who has contributed to this release.
> >>>>>
> >>>>> You can read the release notes here:
> >>>>>
> >>>>
> https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md
> >>>>>
> >>>>> The commit to be voted upon:
> >>>>>
> >>>>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> >>>>>
> >>>>> Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> >>>>>
> >>>>> Tag:
> >>>>> https://github.com/apache/calcite/tree/calcite-1.30.0-rc0
> >>>>>
> >>>>> The artifacts to be voted on are located here:
> >>>>>
> >>>>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0
> >>>>> (revision 52873)
> >>>>>
> >>>>> The hashes of the artifacts are as follows:
> >>>>>
> >>>>
> 339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5
> >>>>> *apache-calcite-1.30.0-src.tar.gz
> >>>>>
> >>>>> A staged Maven repository is available for review at:
> >>>>>
> >>>>
> https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/
> >>>>>
> >>>>> Release artifacts are signed with the following key:
> >>>>> https://people.apache.org/keys/committer/COMMITTER_ID.asc
> >>>>> https://www.apache.org/dist/calcite/KEYS
> >>>>>
> >>>>> To create the jars and test Apache Calcite: "gradle build"
> >>>>> (requires an appropriate Gradle/JDK installation)
> >>>>>
> >>>>> Please vote on releasing this package as Apache Calcite 1.30.0.
> >>>>>
> >>>>> The vote is open for the next 72 hours and passes if a majority of at
> >>>>> least three +1 PMC votes are cast.
> >>>>>
> >>>>> [ ] +1 Release this package as Apache Calcite 1.30.0
> >>>>> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> >>>>> [ ] -1 Do not release this package because...
> >>>>>
> >>>>> Here is my vote:
> >>>>>
> >>>>> +1 (binding)
> >>>>>
> >>>>> Best,
> >>>>> Liya Fan
> >>>>>
> >>>>
> >>>
>

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Posted by Julian Hyde <jh...@gmail.com>.

Liya, in the next iteration can you go back to the usual sections e.g “Bug-fixes, API changes and minor enhancements”. Also remove the “Fix” prefix from messages.

Quite a few cases, e.g “ Fix the problem that JDBC adapter incorrectly adds ORDER BY columns to the SELECT list of generated SQL query” are in the gray area between bug and missing feature, and using the original message helps people make their own decision. 

I also think there’s value in putting changes to build and test in a separate section, as we used to do. But please move my “Fluent test fixtures” into the “new features” section - because it is a major new feature. 
  
Julian

> On Mar 6, 2022, at 10:31 PM, Francis Chuang <fr...@apache.org> wrote:
> 
> Thanks so much Liya! Please cancel this vote by sending a [CANCEL] message as well, to formalize the cancellation of this vote.
> 
> Francis
> 
>> On 7/03/2022 5:27 pm, Fan Liya wrote:
>> After some investigation, I could not resolve the 404 issue of the commit
>> link (In my computer, it is not 404, but an error with XML format).
>> So I have created a new build, which has resolved all the above issues
>> (according to the test on my local computer).
>> Let's start another vote based on the new build. Thanks.
>> Best,
>> Liya Fan
>> Fan Liya <li...@gmail.com> 于2022年3月7日周一 09:53写道：
>>> Thanks for your feedback, Francis.
>>> I will check.
>>> 
>>> Best,
>>> Liya Fan
>>> 
>>> 
>>> Francis Chuang <fr...@apache.org> 于2022年3月7日周一 09:36写道：
>>> 
>>>> Hey Liya,
>>>> 
>>>> Thanks for being RM for this release.
>>>> 
>>>> Can you check the commit to be voted upon?
>>>> 
>>>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
>>>> returns a 404
>>>> 
>>>> Also, tag calcite-1.30.0-rc0 points to a39b9bf
>>>> (https://github.com/apache/calcite/releases/tag/calcite-1.30.0-rc0),
>>>> which does not seem to be in the Calcite repository, see:
>>>> 
>>>> https://github.com/apache/calcite/commit/a39b9bf8b1cbab8f4462c41f6b4506753f859f96
>>>> 
>>>> Thanks!
>>>> Francis
>>>> 
>>>> On 5/03/2022 8:56 pm, Fan Liya wrote:
>>>>> Hi all,
>>>>> 
>>>>> I have created a build for Apache Calcite 1.30.0, release
>>>>> candidate 0.
>>>>> 
>>>>> Thanks to everyone who has contributed to this release.
>>>>> 
>>>>> You can read the release notes here:
>>>>> 
>>>> https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md
>>>>> 
>>>>> The commit to be voted upon:
>>>>> 
>>>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
>>>>> 
>>>>> Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
>>>>> 
>>>>> Tag:
>>>>> https://github.com/apache/calcite/tree/calcite-1.30.0-rc0
>>>>> 
>>>>> The artifacts to be voted on are located here:
>>>>> 
>>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0
>>>>> (revision 52873)
>>>>> 
>>>>> The hashes of the artifacts are as follows:
>>>>> 
>>>> 339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5
>>>>> *apache-calcite-1.30.0-src.tar.gz
>>>>> 
>>>>> A staged Maven repository is available for review at:
>>>>> 
>>>> https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/
>>>>> 
>>>>> Release artifacts are signed with the following key:
>>>>> https://people.apache.org/keys/committer/COMMITTER_ID.asc
>>>>> https://www.apache.org/dist/calcite/KEYS
>>>>> 
>>>>> To create the jars and test Apache Calcite: "gradle build"
>>>>> (requires an appropriate Gradle/JDK installation)
>>>>> 
>>>>> Please vote on releasing this package as Apache Calcite 1.30.0.
>>>>> 
>>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>>> least three +1 PMC votes are cast.
>>>>> 
>>>>> [ ] +1 Release this package as Apache Calcite 1.30.0
>>>>> [ ]  0 I don't feel strongly about it, but I'm okay with the release
>>>>> [ ] -1 Do not release this package because...
>>>>> 
>>>>> Here is my vote:
>>>>> 
>>>>> +1 (binding)
>>>>> 
>>>>> Best,
>>>>> Liya Fan
>>>>> 
>>>> 
>>>

[CANCEL][VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Posted by Fan Liya <li...@gmail.com>.

Cancel this thread, due to some problems in the build.
Thanks to Francis for the kind reminder.
Will start another vote based a new build soon.

Best,
Liya Fan

Francis Chuang <fr...@apache.org> 于2022年3月7日周一 14:31写道：

> Thanks so much Liya! Please cancel this vote by sending a [CANCEL]
> message as well, to formalize the cancellation of this vote.
>
> Francis
>
> On 7/03/2022 5:27 pm, Fan Liya wrote:
> > After some investigation, I could not resolve the 404 issue of the commit
> > link (In my computer, it is not 404, but an error with XML format).
> > So I have created a new build, which has resolved all the above issues
> > (according to the test on my local computer).
> >
> > Let's start another vote based on the new build. Thanks.
> >
> > Best,
> > Liya Fan
> >
> >
> > Fan Liya <li...@gmail.com> 于2022年3月7日周一 09:53写道：
> >
> >> Thanks for your feedback, Francis.
> >> I will check.
> >>
> >> Best,
> >> Liya Fan
> >>
> >>
> >> Francis Chuang <fr...@apache.org> 于2022年3月7日周一 09:36写道：
> >>
> >>> Hey Liya,
> >>>
> >>> Thanks for being RM for this release.
> >>>
> >>> Can you check the commit to be voted upon?
> >>>
> >>>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> >>> returns a 404
> >>>
> >>> Also, tag calcite-1.30.0-rc0 points to a39b9bf
> >>> (https://github.com/apache/calcite/releases/tag/calcite-1.30.0-rc0),
> >>> which does not seem to be in the Calcite repository, see:
> >>>
> >>>
> https://github.com/apache/calcite/commit/a39b9bf8b1cbab8f4462c41f6b4506753f859f96
> >>>
> >>> Thanks!
> >>> Francis
> >>>
> >>> On 5/03/2022 8:56 pm, Fan Liya wrote:
> >>>> Hi all,
> >>>>
> >>>> I have created a build for Apache Calcite 1.30.0, release
> >>>> candidate 0.
> >>>>
> >>>> Thanks to everyone who has contributed to this release.
> >>>>
> >>>> You can read the release notes here:
> >>>>
> >>>
> https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md
> >>>>
> >>>> The commit to be voted upon:
> >>>>
> >>>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> >>>>
> >>>> Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
> >>>>
> >>>> Tag:
> >>>> https://github.com/apache/calcite/tree/calcite-1.30.0-rc0
> >>>>
> >>>> The artifacts to be voted on are located here:
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0
> >>>> (revision 52873)
> >>>>
> >>>> The hashes of the artifacts are as follows:
> >>>>
> >>>
> 339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5
> >>>> *apache-calcite-1.30.0-src.tar.gz
> >>>>
> >>>> A staged Maven repository is available for review at:
> >>>>
> >>>
> https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/
> >>>>
> >>>> Release artifacts are signed with the following key:
> >>>> https://people.apache.org/keys/committer/COMMITTER_ID.asc
> >>>> https://www.apache.org/dist/calcite/KEYS
> >>>>
> >>>> To create the jars and test Apache Calcite: "gradle build"
> >>>> (requires an appropriate Gradle/JDK installation)
> >>>>
> >>>> Please vote on releasing this package as Apache Calcite 1.30.0.
> >>>>
> >>>> The vote is open for the next 72 hours and passes if a majority of at
> >>>> least three +1 PMC votes are cast.
> >>>>
> >>>> [ ] +1 Release this package as Apache Calcite 1.30.0
> >>>> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> >>>> [ ] -1 Do not release this package because...
> >>>>
> >>>> Here is my vote:
> >>>>
> >>>> +1 (binding)
> >>>>
> >>>> Best,
> >>>> Liya Fan
> >>>>
> >>>
> >>
> >
>

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Posted by Francis Chuang <fr...@apache.org>.

Thanks so much Liya! Please cancel this vote by sending a [CANCEL] 
message as well, to formalize the cancellation of this vote.

Francis

On 7/03/2022 5:27 pm, Fan Liya wrote:
> After some investigation, I could not resolve the 404 issue of the commit
> link (In my computer, it is not 404, but an error with XML format).
> So I have created a new build, which has resolved all the above issues
> (according to the test on my local computer).
> 
> Let's start another vote based on the new build. Thanks.
> 
> Best,
> Liya Fan
> 
> 
> Fan Liya <li...@gmail.com> 于2022年3月7日周一 09:53写道：
> 
>> Thanks for your feedback, Francis.
>> I will check.
>>
>> Best,
>> Liya Fan
>>
>>
>> Francis Chuang <fr...@apache.org> 于2022年3月7日周一 09:36写道：
>>
>>> Hey Liya,
>>>
>>> Thanks for being RM for this release.
>>>
>>> Can you check the commit to be voted upon?
>>>
>>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
>>> returns a 404
>>>
>>> Also, tag calcite-1.30.0-rc0 points to a39b9bf
>>> (https://github.com/apache/calcite/releases/tag/calcite-1.30.0-rc0),
>>> which does not seem to be in the Calcite repository, see:
>>>
>>> https://github.com/apache/calcite/commit/a39b9bf8b1cbab8f4462c41f6b4506753f859f96
>>>
>>> Thanks!
>>> Francis
>>>
>>> On 5/03/2022 8:56 pm, Fan Liya wrote:
>>>> Hi all,
>>>>
>>>> I have created a build for Apache Calcite 1.30.0, release
>>>> candidate 0.
>>>>
>>>> Thanks to everyone who has contributed to this release.
>>>>
>>>> You can read the release notes here:
>>>>
>>> https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md
>>>>
>>>> The commit to be voted upon:
>>>>
>>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
>>>>
>>>> Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e
>>>>
>>>> Tag:
>>>> https://github.com/apache/calcite/tree/calcite-1.30.0-rc0
>>>>
>>>> The artifacts to be voted on are located here:
>>>>
>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0
>>>> (revision 52873)
>>>>
>>>> The hashes of the artifacts are as follows:
>>>>
>>> 339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5
>>>> *apache-calcite-1.30.0-src.tar.gz
>>>>
>>>> A staged Maven repository is available for review at:
>>>>
>>> https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/
>>>>
>>>> Release artifacts are signed with the following key:
>>>> https://people.apache.org/keys/committer/COMMITTER_ID.asc
>>>> https://www.apache.org/dist/calcite/KEYS
>>>>
>>>> To create the jars and test Apache Calcite: "gradle build"
>>>> (requires an appropriate Gradle/JDK installation)
>>>>
>>>> Please vote on releasing this package as Apache Calcite 1.30.0.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release this package as Apache Calcite 1.30.0
>>>> [ ]  0 I don't feel strongly about it, but I'm okay with the release
>>>> [ ] -1 Do not release this package because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>>
>>>> Best,
>>>> Liya Fan
>>>>
>>>
>>
>