[GitHub] hughhhh commented on a change in pull request #5552: Add option for BigNumber to not start y-axis at 0

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #5552: Add option for BigNumber to not start y-axis at 0
URL: https://github.com/apache/incubator-superset/pull/5552#discussion_r207723249
 
 

 ##########
 File path: superset/assets/src/explore/controls.jsx
 ##########
 @@ -1479,6 +1479,14 @@ export const controls = {
     description: t('Whether to display the trend line'),
   },
 
+  do_not_start_y_axis_at_zero: {
+    type: 'CheckboxControl',
+    label: t('Do not start y-axis at 0'),
 
 Review comment:
   Can we use positive logic here. Instead of `do_not_start_y_axis_at_zero` can we make it `start_y_axis_at_zero`. Changing the name you can pull off the `!` https://github.com/apache/incubator-superset/pull/5552/files#diff-75b1598539b27c230eeef74daa95956cR165.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org