You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dejan2609 (via GitHub)" <gi...@apache.org> on 2026/08/01 13:10:02 UTC
[PR] KAFKA-20882 Reduce build time: use lazy creation for Gradle tasks (i.e. use `tasks.register` instead of `task` or `tasks.create`) [kafka]
dejan2609 opened a new pull request, #23016:
URL: https://github.com/apache/kafka/pull/23016
JIRA ticket: KAFKA-20882
:bulb: **How to test:** execute `./gradlew clean releaseTarGz --rerun-tasks --no-build-cache --no-configuration-cache --no-daemon`; results (on my box, that is):
- **trunk:** BUILD SUCCESSFUL in **4m 4s**
- **this PR:** BUILD SUCCESSFUL in **3m 54s**
:warning: **Note**: `allDepInsight` task is producing equivalent (not identical) results; I made some tests comparing output files for both trunk and this PR:
```
./gradlew allDepInsight --configuration runtimeClasspath --dependency com.fasterxml.jackson.core:jackson-databind > someTxtFileForTrunkOrThisPR.txt
```
:information_source: **Some related links:**
- https://docs.gradle.org/9.4.1/userguide/organizing_tasks.html
- https://docs.gradle.org/9.4.1/userguide/writing_tasks_intermediate.html
- https://docs.gradle.org/9.4.1/userguide/task_configuration_avoidance.html#task_configuration_avoidance
- https://docs.gradle.org/9.4.1/userguide/lazy_configuration.html
- https://docs.gradle.org/9.4.1/userguide/more_about_tasks.html
- https://docs.gradle.org/9.4.1/userguide/best_practices_tasks.html
- https://stackoverflow.com/questions/53654190/what-is-the-difference-between-registering-and-creating-in-gradle-kotlin-dsl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #23016:
URL: https://github.com/apache/kafka/pull/23016#issuecomment-5289167702
Update: rebased onto trunk (Github bot removed `needs-attention` label a few days ago, so now I'm trying to get that same label again for this PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register()` for Gradle tasks lazy creation instead of `task()` or `tasks.create()` [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #23016:
URL: https://github.com/apache/kafka/pull/23016#issuecomment-5256601496
I'll have to change title (number of characters has to be under 120).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register()` for Gradle tasks lazy creation instead of `task()` or `tasks.create()` [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #23016:
URL: https://github.com/apache/kafka/pull/23016#issuecomment-5195411078
Tested like this:
- distribution created: `./gradlew rTG`
- scenario described here: https://kafka.apache.org/quickstart works as expected :white_check_mark:
I'll also try other Gradle tasks (mentioned in `README.md` file) ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on code in PR #23016:
URL: https://github.com/apache/kafka/pull/23016#discussion_r3797154340
##########
build.gradle:
##########
@@ -1519,7 +1526,7 @@ project(':metadata') {
generator project(':generator')
}
- task processMessages(type:JavaExec) {
+ tasks.register('processMessages',JavaExec) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #23016:
URL: https://github.com/apache/kafka/pull/23016#issuecomment-5347194065
A pack of unrelated tests failed (this time for Java 17):
```
38232 PASSED ✅, 92 FAILED ❌, 0 FLAKY ⚠️ , 2 SKIPPED 🙈, 0 QUARANTINED 😷, and 0 errors
```
FYI @mimaison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register()` for Gradle tasks lazy creation instead of `task()` or `tasks.create()` [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23016:
URL: https://github.com/apache/kafka/pull/23016#issuecomment-5229595794
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #23016:
URL: https://github.com/apache/kafka/pull/23016#discussion_r3795193583
##########
build.gradle:
##########
@@ -1519,7 +1526,7 @@ project(':metadata') {
generator project(':generator')
}
- task processMessages(type:JavaExec) {
+ tasks.register('processMessages',JavaExec) {
Review Comment:
Should we add a space to match the others?
##########
build.gradle:
##########
@@ -769,7 +772,7 @@ kafkaPublicApiChecker {
task systemTestLibs(dependsOn: jar)
if (!sourceSets.test.allSource.isEmpty()) {
- task testJar(type: Jar) {
+ tasks.register('testJar', Jar) {
Review Comment:
Is there a reason we kept `task systemTestLibs` above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on code in PR #23016:
URL: https://github.com/apache/kafka/pull/23016#discussion_r3814523665
##########
build.gradle:
##########
@@ -1271,109 +1276,110 @@ project(':core') {
}
}
- tasks.create(name: "copyDependantLibs", type: Copy) {
+ tasks.register('copyDependantLibs', Copy) {
from (configurations.runtimeClasspath) {
exclude('kafka-clients*')
}
into "${layout.buildDirectory.get().asFile.path}/dependant-libs-${versions.scala}"
duplicatesStrategy = 'exclude'
}
- task genProtocolErrorDocs(type: JavaExec) {
+ tasks.register('genProtocolErrorDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.Errors'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_errors.html").newOutputStream()
}
- task genProtocolTypesDocs(type: JavaExec) {
+ tasks.register('genProtocolTypesDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.types.Type'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_types.html").newOutputStream()
}
- task genProtocolApiKeyDocs(type: JavaExec) {
+ tasks.register('genProtocolApiKeyDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.ApiKeys'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_api_keys.html").newOutputStream()
}
- task genProtocolMessageDocs(type: JavaExec) {
+ tasks.register('genProtocolMessageDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.Protocol'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_messages.html").newOutputStream()
}
- task genAdminClientConfigDocs(type: JavaExec) {
+ tasks.register('genAdminClientConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.clients.admin.AdminClientConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "admin_client_config.html").newOutputStream()
}
- task genProducerConfigDocs(type: JavaExec) {
+ tasks.register('genProducerConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.clients.producer.ProducerConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "producer_config.html").newOutputStream()
}
- task genConsumerConfigDocs(type: JavaExec) {
+ tasks.register('genConsumerConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.clients.consumer.ConsumerConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "consumer_config.html").newOutputStream()
}
- task genKafkaConfigDocs(type: JavaExec) {
+ tasks.register('genKafkaConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'kafka.server.KafkaConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "kafka_config.html").newOutputStream()
}
- task genTopicConfigDocs(type: JavaExec) {
+ tasks.register('genTopicConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.storage.internals.log.LogConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "topic_config.html").newOutputStream()
}
- task genGroupConfigDocs(type: JavaExec) {
+ tasks.register('genGroupConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.coordinator.group.GroupConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "group_config.html").newOutputStream()
}
- task genConsumerMetricsDocs(type: JavaExec) {
+ tasks.register('genConsumerMetricsDocs', JavaExec) {
classpath = sourceSets.test.runtimeClasspath
mainClass = 'org.apache.kafka.clients.consumer.internals.FetchMetricsRegistry'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "consumer_metrics.html").newOutputStream()
}
- task genProducerMetricsDocs(type: JavaExec) {
+ tasks.register('genProducerMetricsDocs', JavaExec) {
classpath = sourceSets.test.runtimeClasspath
mainClass = 'org.apache.kafka.clients.producer.internals.ProducerMetrics'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "producer_metrics.html").newOutputStream()
}
- task siteDocsTar(dependsOn: ['genProtocolErrorDocs', 'genProtocolTypesDocs', 'genProtocolApiKeyDocs', 'genProtocolMessageDocs',
- 'genAdminClientConfigDocs', 'genProducerConfigDocs', 'genConsumerConfigDocs',
- 'genKafkaConfigDocs', 'genTopicConfigDocs', 'genGroupConfigDocs',
- ':connect:runtime:genConnectConfigDocs', ':connect:runtime:genConnectTransformationDocs',
- ':connect:runtime:genConnectPredicateDocs',
- ':connect:runtime:genSinkConnectorConfigDocs', ':connect:runtime:genSourceConnectorConfigDocs',
- ':streams:genStreamsConfigDocs', 'genConsumerMetricsDocs', 'genProducerMetricsDocs',
- ':connect:runtime:genConnectMetricsDocs', ':connect:runtime:genConnectOpenAPIDocs',
- ':connect:mirror:genMirrorSourceConfigDocs', ':connect:mirror:genMirrorCheckpointConfigDocs',
- ':connect:mirror:genMirrorHeartbeatConfigDocs', ':connect:mirror:genMirrorConnectorConfigDocs',
- ':storage:genRemoteLogManagerConfigDoc', ':storage:genRemoteLogMetadataManagerConfigDoc'], type: Tar) {
+ tasks.register('siteDocsTar', Tar) {
+ dependsOn(['genProtocolErrorDocs', 'genProtocolTypesDocs', 'genProtocolApiKeyDocs', 'genProtocolMessageDocs',
Review Comment:
Makes sense, solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use lazy creation for Gradle tasks (i.e. use `tasks.register` instead of `task` or `tasks.create`) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #23016:
URL: https://github.com/apache/kafka/pull/23016#issuecomment-5195230774
I'll rebase this onto trunk (Gradle version changed from 9.4.1 to 9.6.1) and do some test locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #23016:
URL: https://github.com/apache/kafka/pull/23016#issuecomment-5301455921
FYI @mimaison, @chia7712, @clolov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #23016:
URL: https://github.com/apache/kafka/pull/23016#issuecomment-5452233186
Thank you @mimaison 🤝
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #23016:
URL: https://github.com/apache/kafka/pull/23016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #23016:
URL: https://github.com/apache/kafka/pull/23016#issuecomment-5326730094
A few minor things are sorted out.
@mimaison: feel free to review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #23016:
URL: https://github.com/apache/kafka/pull/23016#discussion_r3814010142
##########
build.gradle:
##########
@@ -1271,109 +1276,110 @@ project(':core') {
}
}
- tasks.create(name: "copyDependantLibs", type: Copy) {
+ tasks.register('copyDependantLibs', Copy) {
from (configurations.runtimeClasspath) {
exclude('kafka-clients*')
}
into "${layout.buildDirectory.get().asFile.path}/dependant-libs-${versions.scala}"
duplicatesStrategy = 'exclude'
}
- task genProtocolErrorDocs(type: JavaExec) {
+ tasks.register('genProtocolErrorDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.Errors'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_errors.html").newOutputStream()
}
- task genProtocolTypesDocs(type: JavaExec) {
+ tasks.register('genProtocolTypesDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.types.Type'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_types.html").newOutputStream()
}
- task genProtocolApiKeyDocs(type: JavaExec) {
+ tasks.register('genProtocolApiKeyDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.ApiKeys'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_api_keys.html").newOutputStream()
}
- task genProtocolMessageDocs(type: JavaExec) {
+ tasks.register('genProtocolMessageDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.common.protocol.Protocol'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "protocol_messages.html").newOutputStream()
}
- task genAdminClientConfigDocs(type: JavaExec) {
+ tasks.register('genAdminClientConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.clients.admin.AdminClientConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "admin_client_config.html").newOutputStream()
}
- task genProducerConfigDocs(type: JavaExec) {
+ tasks.register('genProducerConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.clients.producer.ProducerConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "producer_config.html").newOutputStream()
}
- task genConsumerConfigDocs(type: JavaExec) {
+ tasks.register('genConsumerConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.clients.consumer.ConsumerConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "consumer_config.html").newOutputStream()
}
- task genKafkaConfigDocs(type: JavaExec) {
+ tasks.register('genKafkaConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'kafka.server.KafkaConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "kafka_config.html").newOutputStream()
}
- task genTopicConfigDocs(type: JavaExec) {
+ tasks.register('genTopicConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.storage.internals.log.LogConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "topic_config.html").newOutputStream()
}
- task genGroupConfigDocs(type: JavaExec) {
+ tasks.register('genGroupConfigDocs', JavaExec) {
classpath = sourceSets.main.runtimeClasspath
mainClass = 'org.apache.kafka.coordinator.group.GroupConfig'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "group_config.html").newOutputStream()
}
- task genConsumerMetricsDocs(type: JavaExec) {
+ tasks.register('genConsumerMetricsDocs', JavaExec) {
classpath = sourceSets.test.runtimeClasspath
mainClass = 'org.apache.kafka.clients.consumer.internals.FetchMetricsRegistry'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "consumer_metrics.html").newOutputStream()
}
- task genProducerMetricsDocs(type: JavaExec) {
+ tasks.register('genProducerMetricsDocs', JavaExec) {
classpath = sourceSets.test.runtimeClasspath
mainClass = 'org.apache.kafka.clients.producer.internals.ProducerMetrics'
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOutput = new File(generatedDocsDir, "producer_metrics.html").newOutputStream()
}
- task siteDocsTar(dependsOn: ['genProtocolErrorDocs', 'genProtocolTypesDocs', 'genProtocolApiKeyDocs', 'genProtocolMessageDocs',
- 'genAdminClientConfigDocs', 'genProducerConfigDocs', 'genConsumerConfigDocs',
- 'genKafkaConfigDocs', 'genTopicConfigDocs', 'genGroupConfigDocs',
- ':connect:runtime:genConnectConfigDocs', ':connect:runtime:genConnectTransformationDocs',
- ':connect:runtime:genConnectPredicateDocs',
- ':connect:runtime:genSinkConnectorConfigDocs', ':connect:runtime:genSourceConnectorConfigDocs',
- ':streams:genStreamsConfigDocs', 'genConsumerMetricsDocs', 'genProducerMetricsDocs',
- ':connect:runtime:genConnectMetricsDocs', ':connect:runtime:genConnectOpenAPIDocs',
- ':connect:mirror:genMirrorSourceConfigDocs', ':connect:mirror:genMirrorCheckpointConfigDocs',
- ':connect:mirror:genMirrorHeartbeatConfigDocs', ':connect:mirror:genMirrorConnectorConfigDocs',
- ':storage:genRemoteLogManagerConfigDoc', ':storage:genRemoteLogMetadataManagerConfigDoc'], type: Tar) {
+ tasks.register('siteDocsTar', Tar) {
+ dependsOn(['genProtocolErrorDocs', 'genProtocolTypesDocs', 'genProtocolApiKeyDocs', 'genProtocolMessageDocs',
Review Comment:
We have 3 instances of `dependsOn: [`. Here it's been converted to `dependsOn(`.
For the `testAll` and `jmh` tasks it's `dependsOn = [`
Should these be consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on code in PR #23016:
URL: https://github.com/apache/kafka/pull/23016#discussion_r3797158167
##########
build.gradle:
##########
@@ -769,7 +772,7 @@ kafkaPublicApiChecker {
task systemTestLibs(dependsOn: jar)
if (!sourceSets.test.allSource.isEmpty()) {
- task testJar(type: Jar) {
+ tasks.register('testJar', Jar) {
Review Comment:
No, that was accidentally skipped by me.
I found another one (and fix it also).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20882 Reduce build time: use `tasks.register` for Gradle tasks lazy creation (instead of `task` / `tasks.create`) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #23016:
URL: https://github.com/apache/kafka/pull/23016#issuecomment-5353294226
Gradle version in trunk was bumped from 9.6.1 to 9.7.1 but those changes are not related with this PR.
@mimaison if you want to be on a safe side I can rebase this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org