You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mikebridge (via GitHub)" <gi...@apache.org> on 2026/10/09 14:40:02 UTC
[PR] fix(explore): honor chart edit permissions for titles [superset]
mikebridge opened a new pull request, #45146:
URL: https://github.com/apache/superset/pull/45146
### SUMMARY
In Explore, the chart title used its own permission rule: the user had to be in the chart's explicit `editors` list or hold the store's `can_overwrite` grant. The chart's other edit actions use the shared `canOverwriteSlice` predicate: overwrite in the save modal, edit properties and version history. That predicate also allows administrators and editors granted through `extra_editors` (a deployment's `EXTRA_EDITORS_RESOLVER`). As a result, an admin or extra editor could save over a chart but could not rename it in the header. This affects every seeded or example chart, which has no explicit editors.
The title now calls `canOverwriteSlice` too, so one rule governs all of the chart's edit actions. Two title-specific conditions are kept:
- New, unsaved charts stay editable.
- The title stays read-only while a version preview is active.
The optional `extra_editors` field, which the API already returns, is added to the `Slice` type, and the Explore docs mention who can edit a chart's title.
Behavior by user:
| User | Before | After |
| --- | --- | --- |
| Admin, not an explicit editor | Title read-only | Title editable |
| Extra editor (via `EXTRA_EDITORS_RESOLVER`) | Title read-only | Title editable |
| Explicit editor, or user with the overwrite grant | Editable | Editable |
| Unrelated viewer | Read-only | Read-only |
| Any user on an externally managed chart | Editable with the overwrite grant | Read-only, matching the save modal and properties modal |
| Any user during a version preview | Read-only | Read-only |
| New, unsaved chart | Editable | Editable |
The only narrowing is the externally managed chart. Its title was the one place such a chart could still be edited, and the change there could not be saved over the chart anyway.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not captured: this is a permission-gate fix with no visual change. The table above describes the behavior before and after.
### TESTING INSTRUCTIONS
Automated:
```bash
cd superset-frontend && npm run test -- src/explore/components/ExploreChartHeader/ExploreChartHeader.test.tsx
```
The new cases cover each route to permission and each exclusion: admin, extra editor, owner subject, overwrite grant, unrelated viewer, externally managed chart, version preview and new chart. With the previous component, the admin, extra-editor and managed-chart cases fail. Changed-file pre-commit passed, including frontend type checking.
Manual:
1. As an admin, open an example chart with no explicit editors in Explore. The title is editable, and the rename saves through **Save → Overwrite**.
2. As a Gamma user who neither edits nor owns the chart, open it. The title is read-only.
3. On an externally managed chart, the title is read-only for everyone.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
@aminghadersohi @rebenitez1802
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): honor chart edit permissions for titles [superset]
Posted by "gabotorresruiz (via GitHub)" <gi...@apache.org>.
gabotorresruiz commented on code in PR #45146:
URL: https://github.com/apache/superset/pull/45146#discussion_r4251017247
##########
superset-frontend/src/explore/components/ExploreChartHeader/index.tsx:
##########
@@ -125,6 +125,21 @@ const ExploreChartHeader: FC<ExploreChartHeaderProps> = ({
metadata,
isSaveModalVisible,
}) => {
+ const slice = useMemo(
+ () =>
+ rawSlice
+ ? {
+ ...rawSlice,
+ editors: rawSlice.editors?.filter(Number.isInteger),
Review Comment:
Thanks for both of these, and the read-only extra editor case is a good addition. One thing I want to flag before this lands though: the guard is a locally derived value inside this component, so it never reaches the store. `state.explore.slice.editors` is still `[undefined]` after a properties save, and three other callers read it straight from Redux rather than through this memo: `ExploreVersionHistory.tsx:78` and `ChartVersionPreview.tsx:76` both `useSelector(state => state.explore?.slice)` before calling `canOverwriteSlice`, and `SaveModal` gets it via `mapStateToProps` at `:935` and calls the predicate at `:230`. So the title and the additional actions menu are covered here (the menu reads the sanitized value at line 225), but those three still throw on the same shape, and `SaveModal` is the one a user reaches straight after renaming.
None of that is caused by your diff, so I am not asking you to fix it here. But it does mean the properties-save crash is not closed, and the deferred reducer change is the thing that would close it everywhere at once. Could that one go in first, or alongside? `(editor.value ?? editor.id)` in `getEditorId` would let this guard become belt and braces rather than the only thing holding it.
Smaller note: `malformed editors after properties save` asserts `granted: false`, so an explicit non-admin editor now silently loses the rename until reload where it used to throw. Better, clearly, but it does bake the degraded behaviour into the test rather than the fixed behaviour.
##########
superset-frontend/src/explore/components/ExploreChartHeader/index.tsx:
##########
@@ -291,30 +306,30 @@ const ExploreChartHeader: FC<ExploreChartHeaderProps> = ({
}
}, [showUnsavedChangesModal, shouldForceCloseModal]);
- const userSubjects = useMemo(
- () => new Set(getBootstrapData()?.common?.user_subjects ?? []),
- [],
- );
-
const editableTitleProps = useMemo(
() => ({
title: sliceName ?? '',
canEdit:
!isVersionPreviewActive &&
(!slice ||
- canOverwrite ||
- Boolean(slice?.editors?.some(editor => userSubjects.has(editor)))),
+ (canWriteChart &&
Review Comment:
This matches `canEditProperties`, which is what I asked about, so the dead end I described is gone for the title. It does leave the pair inconsistent in the other direction though: `SaveModal` still gates Overwrite on `canOverwriteSlice` alone (`:230`, button at `:736`) with no `can_add`, so a read-only extra editor now gets a read-only title next to an enabled **Overwrite** button, and that is still the 403 I was worried about, just reached from a different control.
Worth either ANDing `can_add` into `SaveModal`'s predicate too, or folding it into `canOverwriteSlice` so there is one answer. Happy either way, I just would not want the two to drift.
Also the description still lists extra editors as able to edit the title unconditionally, which this commit changes. The docs are updated but the PR body table is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): honor chart edit permissions for titles [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45146:
URL: https://github.com/apache/superset/pull/45146#issuecomment-6085659432
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45146?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.80%. Comparing base ([`1b35374`](https://app.codecov.io/gh/apache/superset/commit/1b35374fecb176206a8810f2ec1da90e67ba113a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c2722d1`](https://app.codecov.io/gh/apache/superset/commit/c2722d1343ce0120ebafb6b4c6513e8709e96c47?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #45146 +/- ##
==========================================
- Coverage 82.80% 82.80% -0.01%
==========================================
Files 3016 3016
Lines 192521 192519 -2
Branches 44842 44841 -1
==========================================
- Hits 159409 159407 -2
Misses 30079 30079
Partials 3033 3033
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/45146/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/45146/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.53% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45146?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): honor chart edit permissions for titles [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on code in PR #45146:
URL: https://github.com/apache/superset/pull/45146#discussion_r4252592403
##########
superset-frontend/src/explore/components/ExploreChartHeader/index.tsx:
##########
@@ -125,6 +125,21 @@ const ExploreChartHeader: FC<ExploreChartHeaderProps> = ({
metadata,
isSaveModalVisible,
}) => {
+ const slice = useMemo(
+ () =>
+ rawSlice
+ ? {
+ ...rawSlice,
+ editors: rawSlice.editors?.filter(Number.isInteger),
Review Comment:
Codex fixed the reducer in a71d9301d5280c1eb3cdd84e1bca854e2b7d9eb2; Claude independently reviewed the final change. You were right that the header-only guard did not repair the Redux value. `SLICE_UPDATED` now normalizes API `{id, label}` editors, select `{value, label}` editors and numeric subject IDs before any store consumer sees them.
- The regression drives the real reducer into the real `canOverwriteSlice` predicate for a non-admin subject. Before the fix, the API shape throws on `undefined.id`; afterwards it retains `[8]` and editorship. The select and numeric forms remain supported.
- This fixes the stored shape read by SaveModal, ExploreVersionHistory and ChartVersionPreview. The header guard remains defensive; its invalid-ID case is renamed so it no longer describes the normal properties-save response.
- All 153 focused tests across seven suites and the branch-file hooks, including TypeScript, pass.
A separate pre-existing issue remains on the version-restore actions: they check editorship without Chart write permission. That is not the editor-ID crash and is not changed here; read-only history visibility is preserved.
##########
superset-frontend/src/explore/components/ExploreChartHeader/index.tsx:
##########
@@ -291,30 +306,30 @@ const ExploreChartHeader: FC<ExploreChartHeaderProps> = ({
}
}, [showUnsavedChangesModal, shouldForceCloseModal]);
- const userSubjects = useMemo(
- () => new Set(getBootstrapData()?.common?.user_subjects ?? []),
- [],
- );
-
const editableTitleProps = useMemo(
() => ({
title: sliceName ?? '',
canEdit:
!isVersionPreviewActive &&
(!slice ||
- canOverwrite ||
- Boolean(slice?.editors?.some(editor => userSubjects.has(editor)))),
+ (canWriteChart &&
Review Comment:
Codex addressed the SaveModal asymmetry in a71d9301d5280c1eb3cdd84e1bca854e2b7d9eb2; Claude independently reviewed the final change. Overwrite now requires `explore.can_add` as well as `canOverwriteSlice`, matching the title and properties-save controls. The shared predicate remains editorship-only because it also governs read-only version-history visibility.
- Explicit and extra editors with write permission retain enabled Overwrite; both read-only cases now get disabled Overwrite and the appropriate permission message. These cases failed before the fix.
- The current PR table already had the Chart-write qualifiers when I rechecked it; the description and test instructions now also explain the reducer normalization and SaveModal gate.
- Final checks: 153 tests across seven suites, frontend type checking and branch-file hooks passed.
The pre-existing version-restore action gates still need a separate write-permission follow-up; this change does not claim to fix those actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): honor chart edit permissions for titles [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on code in PR #45146:
URL: https://github.com/apache/superset/pull/45146#discussion_r4235496399
##########
docs/docs/using-superset/exploring-data.mdx:
##########
@@ -128,6 +128,10 @@ To save the visualization, click on **Save** in the top left of the screen. In t
- Select **Add To Dashboard** and enter
Tutorial Dashboard. Finally, select **Save & Go To Dashboard**.
+For an existing chart, chart editors (including extra editors and administrators)
+can edit its title in Explore and save the change. Externally managed charts and
Review Comment:
Matched the properties editor: saved-chart titles now require both editorship and Chart write permission (`can_add`). The docs say so, and a regression test covers an extra editor with read-only permission.
##########
superset-frontend/src/explore/components/ExploreChartHeader/index.tsx:
##########
@@ -291,19 +291,17 @@ const ExploreChartHeader: FC<ExploreChartHeaderProps> = ({
}
}, [showUnsavedChangesModal, shouldForceCloseModal]);
- const userSubjects = useMemo(
- () => new Set(getBootstrapData()?.common?.user_subjects ?? []),
- [],
- );
-
const editableTitleProps = useMemo(
() => ({
title: sliceName ?? '',
canEdit:
!isVersionPreviewActive &&
(!slice ||
- canOverwrite ||
- Boolean(slice?.editors?.some(editor => userSubjects.has(editor)))),
+ canOverwriteSlice({
Review Comment:
Added a small guard at the header boundary that removes malformed editor IDs before the title and additional-actions predicates run. The `[null]` properties-save shape now renders without throwing, while valid extra-editor grants still work. The underlying reducer conversion can be handled separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): honor chart edit permissions for titles [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on code in PR #45146:
URL: https://github.com/apache/superset/pull/45146#discussion_r4252595659
##########
superset-frontend/src/explore/components/ExploreChartHeader/index.tsx:
##########
@@ -291,19 +291,17 @@ const ExploreChartHeader: FC<ExploreChartHeaderProps> = ({
}
}, [showUnsavedChangesModal, shouldForceCloseModal]);
- const userSubjects = useMemo(
- () => new Set(getBootstrapData()?.common?.user_subjects ?? []),
- [],
- );
-
const editableTitleProps = useMemo(
() => ({
title: sliceName ?? '',
canEdit:
!isVersionPreviewActive &&
(!slice ||
- canOverwrite ||
- Boolean(slice?.editors?.some(editor => userSubjects.has(editor)))),
+ canOverwriteSlice({
Review Comment:
Codex now addressed the deferred reducer change, with independent Claude review. API id/label editors are normalized to numeric IDs in Redux, preserving editorship for all consumers rather than only the header. The real reducer/predicate regression fails before the fix and passes afterwards. Full details and checks: https://github.com/apache/superset/pull/45146#discussion_r4252592403.
##########
docs/docs/using-superset/exploring-data.mdx:
##########
@@ -128,6 +128,10 @@ To save the visualization, click on **Save** in the top left of the screen. In t
- Select **Add To Dashboard** and enter
Tutorial Dashboard. Finally, select **Save & Go To Dashboard**.
+For an existing chart, chart editors (including extra editors and administrators)
+can edit its title in Explore and save the change. Externally managed charts and
Review Comment:
Codex completed the corresponding SaveModal write-permission gate, with independent Claude review. Title, properties-save and Overwrite now require Chart write permission as well as editorship; explicit/extra-editor read-only and write-enabled cases are tested. Full details and the separate inherited version-restore follow-up: https://github.com/apache/superset/pull/45146#discussion_r4252592586.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): honor chart edit permissions for titles [superset]
Posted by "gabotorresruiz (via GitHub)" <gi...@apache.org>.
gabotorresruiz commented on code in PR #45146:
URL: https://github.com/apache/superset/pull/45146#discussion_r4233086484
##########
superset-frontend/src/explore/components/ExploreChartHeader/index.tsx:
##########
@@ -291,19 +291,17 @@ const ExploreChartHeader: FC<ExploreChartHeaderProps> = ({
}
}, [showUnsavedChangesModal, shouldForceCloseModal]);
- const userSubjects = useMemo(
- () => new Set(getBootstrapData()?.common?.user_subjects ?? []),
- [],
- );
-
const editableTitleProps = useMemo(
() => ({
title: sliceName ?? '',
canEdit:
!isVersionPreviewActive &&
(!slice ||
- canOverwrite ||
- Boolean(slice?.editors?.some(editor => userSubjects.has(editor)))),
+ canOverwriteSlice({
Review Comment:
Not a blocker, and not caused by your diff, but `canEdit` now runs through a predicate that can throw. After **Edit chart properties** saves, `PropertiesModal` hands `onSave` the raw `GET /api/v1/chart/<pk>` body, where `editors` is a list of `SubjectResponseSchema` objects keyed `id`. `exploreReducer`'s `SLICE_UPDATED` maps that list with `editor.value`, so `explore.slice.editors` becomes `[null]`, and `subjectId` in `permissionUtils` then reads `.id` off the `null`. Driving the real reducer into the real predicate gives `Cannot read properties of null (reading 'id')`, and rendering this header with `editors: [null]` throws the same on your branch and on its parent, since `canModifySlice` in `useExploreAdditionalActionsMenu` already calls `canOverwriteSlice` with the same slice. Pre-existing, then, but cheap to close while you are in here:
```ts
const getEditorId = (editor: EditorItem): number =>
typeof editor === 'number' ? editor : (editor.value ?? editor.id);
```
or a `subject == null` short circuit in `subjectId`. A `SLICE_UPDATED` case asserting that a `[{ id: 8, label: 'Alice' }]` payload leaves `slice.editors` as `[8]` would pin it.
##########
docs/docs/using-superset/exploring-data.mdx:
##########
@@ -128,6 +128,10 @@ To save the visualization, click on **Save** in the top left of the screen. In t
- Select **Add To Dashboard** and enter
Tutorial Dashboard. Finally, select **Save & Go To Dashboard**.
+For an existing chart, chart editors (including extra editors and administrators)
+can edit its title in Explore and save the change. Externally managed charts and
Review Comment:
Small question on "and save the change": an extra editor whose role carries only `can_read` on `Chart` gets an editable title here, but the rename is persisted by the overwrite `PUT /api/v1/chart/<pk>`, and `put` maps to `write` in `MODEL_API_RW_METHOD_PERMISSION_MAP`, so it would come back 403. `canEditProperties` in `useExploreAdditionalActionsMenu` ANDs `can_add` (the `can_write` on `Chart` lookup) for exactly that reason. Is matching `SaveModal`, which also gates on `canOverwriteSlice` alone, the intent? I might be missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): honor chart edit permissions for titles [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45146:
URL: https://github.com/apache/superset/pull/45146#issuecomment-6083168287
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | c8a1b9b7c539cb8254c78383428ca70c3bab0457 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ac8fcc31787e000089d24e2 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45146--superset-docs-preview.netlify.app](https://deploy-preview-45146--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcrBDYAgDEDRXXqWRFAB3cAxsNRAgkKwF2LcXf7pH94LpearMGwAAxzV3Rj6PyikXIyWAoOrLDhyIkE-sjtiitw69lRSbrvvXDu0J-IkjTU09uzq1UwKvh8) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-45146--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): honor chart edit permissions for titles [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45146:
URL: https://github.com/apache/superset/pull/45146#issuecomment-6085918218
## CodeAnt PR Risk: Low Risk
- The PR appears safe to merge; chart title editing now uses shared overwrite authorization, while version previews remain read-only.
- Tests cover admins, chart editors, extra editors, overwrite grants, externally managed charts, previews, and new charts.
**Assessed commit:** `c2722d1343ce`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): honor chart edit permissions for titles [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi merged PR #45146:
URL: https://github.com/apache/superset/pull/45146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org