You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/04/07 20:26:52 UTC
Review Request 45884: GEODE-1194: Improve Gradle build so that
IntelliJ can correctly use test code in module dependencies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45884/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Repository: geode
Description
-------
GEODE-1194: Improve Gradle build so that IntelliJ can correctly use test code in module dependencies
Diffs
-----
extensions/geode-modules-tomcat7/build.gradle 07619e86bfb4126fe79874ac0115b7f41bef32a0
extensions/geode-modules/build.gradle e007bca503d80371feceb49866afccfe79a11b43
geode-assembly/build.gradle 7e61d1d9c7ba44ecff4c4322151a9ea715f8976a
geode-cq/build.gradle 081f903318b9f582ee8e66f4fd0c33526da396c8
geode-lucene/build.gradle c1eeb2eeb8bb21e382a069d34316f4023a698cdc
geode-wan/build.gradle 081f903318b9f582ee8e66f4fd0c33526da396c8
Diff: https://reviews.apache.org/r/45884/diff/
Testing
-------
Ran `test` task.
Thanks,
Jens Deppe
Re: Review Request 45884: GEODE-1194: Improve Gradle build so that
IntelliJ can correctly use test code in module dependencies
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45884/#review127666
-----------------------------------------------------------
Ship it!
Looks good! It would probably be good to verify that this doesn't screw up the task dependency in gradle. In other words, can you do this and see if it correctly compiles the geode-core test code before the lucene test code?
git clean
git geode-lucene:compileTestJava
Also, it would be good to verify this doesn't screw up the generated eclipse projects. Just do ./gradlew geode-lucene:eclipse and look at the generated geode-lucene/.classpath file to make sure no gradle output directories show up in there.
- Dan Smith
On April 7, 2016, 6:26 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45884/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 6:26 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1194: Improve Gradle build so that IntelliJ can correctly use test code in module dependencies
>
>
> Diffs
> -----
>
> extensions/geode-modules-tomcat7/build.gradle 07619e86bfb4126fe79874ac0115b7f41bef32a0
> extensions/geode-modules/build.gradle e007bca503d80371feceb49866afccfe79a11b43
> geode-assembly/build.gradle 7e61d1d9c7ba44ecff4c4322151a9ea715f8976a
> geode-cq/build.gradle 081f903318b9f582ee8e66f4fd0c33526da396c8
> geode-lucene/build.gradle c1eeb2eeb8bb21e382a069d34316f4023a698cdc
> geode-wan/build.gradle 081f903318b9f582ee8e66f4fd0c33526da396c8
>
> Diff: https://reviews.apache.org/r/45884/diff/
>
>
> Testing
> -------
>
> Ran `test` task.
>
>
> Thanks,
>
> Jens Deppe
>
>