You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Yangfisher1 (via GitHub)" <gi...@apache.org> on 2023/07/24 07:13:48 UTC
[GitHub] [skywalking-kubernetes] Yangfisher1 opened a new pull request, #127: Adding support for zipkin UI
Yangfisher1 opened a new pull request, #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127
Marking the variable `SW_ZIPKIN_ADDRESS` explicitly for deploying the zipkin UI more easily on k8s cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on a diff in pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on code in PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#discussion_r1272914882
##########
chart/skywalking/templates/oap-deployment.yaml:
##########
@@ -122,6 +122,17 @@ spec:
- containerPort: {{ $value }}
name: {{ $key }}
{{- end }}
+
+{{- if eq .Values.oap.env.SW_RECEIVER_ZIPKIN "default" }}
+ - containerPort: 9411
+ name: "zipkin"
+{{- end }}
+
+{{- if eq .Values.oap.env.SW_QUERY_ZIPKIN "default" }}
+ - containerPort: 9412
+ name: "zipkin-ui"
Review Comment:
@wu-sheng I think it's the original [Zipkin](https://skywalking.apache.org/docs/main/next/en/setup/backend/zipkin-trace/) bounded in Skywalking OAP Server. We just configure the deployment, making it easier to use Zipkin trace in Skywalking on k8s cluster since I find there're some issues about the configuration of Zipkin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649421217
@innerpeacez My bad. It's the restriction of Kubernetes as `a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #127: Adding support for zipkin UI
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649452691
> @innerpeacez My bad. It's the restriction of Kubernetes as `a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')`
Oooops! For more convenience. Named `zkreceiver` `zkquery`, to avoid using gotemplate `index` function. You think? @Yangfisher1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1647870286
@kezhenxu94
> Conditionally add the exposed port 9412 in the OAP service: when the SW_QUERY_ZIPKIN is set to default, add the port 9412 to service OAP, otherwise, don't add the port.
I think this idea is better.
> Always add the SW_ZIPKIN_ADDRESS, there is no side effect for this env var to be set no matter Zipkin plugin is enabled or disabled.
However, there's one side effect for this env var to be set without setting the port. The UI pod will throw an error complaining about the missing port when initializing. I think we should use the env var `SW_QUERY_ZIPKIN` to control whether the `SW_ZIPKIN_ADDRESS` is set or not. Is it a good idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649612979
@kezhenxu94 @innerpeacez
Renaming is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] wu-sheng commented on a diff in pull request #127: Adding support for zipkin UI
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#discussion_r1272395545
##########
chart/skywalking/templates/oap-deployment.yaml:
##########
@@ -122,6 +122,17 @@ spec:
- containerPort: {{ $value }}
name: {{ $key }}
{{- end }}
+
+{{- if eq .Values.oap.env.SW_RECEIVER_ZIPKIN "default" }}
+ - containerPort: 9411
+ name: "zipkin"
+{{- end }}
+
+{{- if eq .Values.oap.env.SW_QUERY_ZIPKIN "default" }}
+ - containerPort: 9412
+ name: "zipkin-ui"
Review Comment:
FYI @jcchavezs Another new Zipkin is being added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1647872152
> However, there's one side effect for this env var to be set without setting the port. The UI pod will throw an error complaining about the missing port when initializing. I think we should use the env var `SW_QUERY_ZIPKIN` to control whether the `SW_ZIPKIN_ADDRESS` is set or not. Is it a good idea?
Right I missed that, that's better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #127: Adding support for zipkin UI
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649411959
> Since helm only supports lowercase letters so I rename these ports.
Camel-Case is supported, let's keep it. ref to https://helm.sh/zh/docs/chart_best_practices/values/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #127: Adding support for zipkin UI
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649566565
> > @innerpeacez
> >
> > I'm ok with this. But I'm concerned that using `zk` instead of `zipkin` might be confusing. Using 'index' would ensure the readability of these ports.
>
> We can use zipkinreceiver or zipkinquery?
It's better. I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649552633
> @innerpeacez
>
> I'm ok with this. But I'm concerned that using `zk` instead of `zipkin` might be confusing. Using 'index' would ensure the readability of these ports.
We can use zipkinreceiver or zipkinquery?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #127: Adding support for zipkin UI
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#discussion_r1271871462
##########
chart/skywalking/values.yaml:
##########
@@ -41,6 +41,7 @@ oap:
# zabbix: 10051
grpc: 11800
rest: 12800
+ zipkinUI: 9412
Review Comment:
I think this should not be enabled by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on a diff in pull request #127: Adding support for zipkin UI
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on code in PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#discussion_r1273172925
##########
chart/skywalking/templates/oap-deployment.yaml:
##########
@@ -127,6 +127,18 @@ spec:
{{ toYaml .Values.oap.resources | indent 10 }}
{{- end }}
env:
+{{- if .Values.oap.ports.zipkinReceiver }}
+ - name: SW_RECEIVER_ZIPKIN
+ value: default
+ - name: SW_RECEIVER_ZIPKIN_REST_PORT
+ value: {{ .Values.oap.ports.zipkinReceiver }}
Review Comment:
```suggestion
value: "{{ .Values.oap.ports.zipkinReceiver }}"
```
##########
chart/skywalking/templates/oap-deployment.yaml:
##########
@@ -127,6 +127,18 @@ spec:
{{ toYaml .Values.oap.resources | indent 10 }}
{{- end }}
env:
+{{- if .Values.oap.ports.zipkinReceiver }}
+ - name: SW_RECEIVER_ZIPKIN
+ value: default
+ - name: SW_RECEIVER_ZIPKIN_REST_PORT
+ value: {{ .Values.oap.ports.zipkinReceiver }}
+{{- end }}
+{{- if .Values.oap.ports.zipkinQuery }}
+ - name: SW_QUERY_ZIPKIN
+ value: default
+ - name: SW_QUERY_ZIPKIN_REST_PORT
+ value: {{ .Values.oap.ports.zipkinQuery }}
Review Comment:
```suggestion
value: "{{ .Values.oap.ports.zipkinQuery }}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649387845
@innerpeacez @kezhenxu94
I tested it on my k8s cluster and it worked well. Since helm only supports lowercase letters so I rename these ports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1647387180
I think using these variables in Chart template is easier especially for those who are not familiar with Helm. But at least adding some guide about how to deploy the zipkin UI on k8s cluster is needed. It took me a lot of time to find out the variable `SW_ZIPKIN_ADDRESS` should be set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on a diff in pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on code in PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#discussion_r1271895056
##########
chart/skywalking/values.yaml:
##########
@@ -41,6 +41,7 @@ oap:
# zabbix: 10051
grpc: 11800
rest: 12800
+ zipkinUI: 9412
Review Comment:
Ok. Maybe I should `if` to create a conditional block in `ui-deployment.yaml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez merged pull request #127: Adding support for zipkin UI
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez merged PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] wu-sheng commented on pull request #127: Adding support for zipkin UI
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649884412
Congrats @Yangfisher1 to be 800th GitHub contributor of SkyWalking.
Welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649920667
@kezhenxu94 @innerpeacez @wu-sheng Thank you for your help! This is a wonderful community and everyone is kind🤩
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649254933
@innerpeacez @kezhenxu94 It works for me, making it more convenient and graceful. Users only need to configure these two ports to enable zipkin trace and they can choose any port they want.
I'd like to make these changes and add these ports into `README.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1647831560
Use ` ui.zipkin.enabled` and `oap.port.zipkinui` to control whether set the variable `SW_ZIPKIN_ADDRESS` or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649523540
@innerpeacez
I'm ok with this. But I'm concerned that using `zk` instead of `zipkin` might be confusing. Using 'index' would ensure the readability of these ports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1648077991
@kezhenxu94
It works well now. But I think directly hardcoding the port number(like `9141` and `9142`) in the file is not very graceful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] wu-sheng commented on a diff in pull request #127: Adding support for zipkin UI
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#discussion_r1272957764
##########
chart/skywalking/templates/oap-deployment.yaml:
##########
@@ -122,6 +122,17 @@ spec:
- containerPort: {{ $value }}
name: {{ $key }}
{{- end }}
+
+{{- if eq .Values.oap.env.SW_RECEIVER_ZIPKIN "default" }}
+ - containerPort: 9411
+ name: "zipkin"
+{{- end }}
+
+{{- if eq .Values.oap.env.SW_QUERY_ZIPKIN "default" }}
+ - containerPort: 9412
+ name: "zipkin-ui"
Review Comment:
Yes, but it was not exposed I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #127: Adding support for zipkin UI
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#discussion_r1273002169
##########
chart/skywalking/templates/oap-deployment.yaml:
##########
@@ -122,6 +122,17 @@ spec:
- containerPort: {{ $value }}
name: {{ $key }}
{{- end }}
+
+{{- if eq .Values.oap.env.SW_RECEIVER_ZIPKIN "default" }}
+ - containerPort: 9411
+ name: "zipkin"
+{{- end }}
+
+{{- if eq .Values.oap.env.SW_QUERY_ZIPKIN "default" }}
+ - containerPort: 9412
+ name: "zipkin-ui"
Review Comment:
This is for the sake of convenience, nothing new is added, nothing old was blocked without this changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649133355
> @kezhenxu94
>
> It works well now. But I think directly hardcoding the port number(like `9141` and `9142`) in the file is not very graceful.
I agree, but I don't thin we have a more graceful way to do this, do you have any better idea, I'm open to discuss?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649213683
> values.yaml
>
> ```
> oap:
> ports:
> # add more ports here if you need, for example
> # zabbix: 10051
> grpc: 11800
> rest: 12800
> # zipkinReceiver: 9411
> # zipkinQuery: 9412
> ```
>
> oap-deployment.yaml
>
> ```
> env:
> {{- if .Values.oap.ports.zipkinReceiver }}
> - name: SW_RECEIVER_ZIPKIN
> value: "default"
> {{- end }}
> {{- if .Values.oap.ports.zipkinQuery }}
> - name: SW_QUERY_ZIPKIN
> value: "default"
> {{- end }}
> ```
>
> ui-deployment.yaml
>
> ```
> env:
> {{- if .Values.oap.ports.zipkinQuery }}
> - name: SW_ZIPKIN_ADDRESS
> value: "http://{{ template "skywalking.oap.fullname" . }}:{{ .Values.oap.ports.zipkinQuery }}"
> {{- end }}
> ```
>
> I think it might be more convenient. What do you think? @kezhenxu94 @Yangfisher1
This works for me too, another good point is that we can also set `SW_QUERY_ZIPKIN_REST_PORT` to `.Values.ports.zipkinQuery`, @Yangfisher1 in that case users can set Zipin port to arbitrary port, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #127: Adding support for zipkin UI
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649208747
values.yaml
```
oap:
ports:
# add more ports here if you need, for example
# zabbix: 10051
grpc: 11800
rest: 12800
# zipkinReceiver: 9411
# zipkinQuery: 9412
```
oap-deployment.yaml
```
env:
{{- if .Values.oap.ports.zipkinReceiver }}
- name: SW_RECEIVER_ZIPKIN
value: "default"
{{- end }}
{{- if .Values.oap.ports.zipkinQuery }}
- name: SW_QUERY_ZIPKIN
value: "default"
{{- end }}
```
ui-deployment.yaml
```
env:
{{- if .Values.oap.ports.zipkinQuery }}
- name: SW_ZIPKIN_ADDRESS
value: "http://{{ template "skywalking.oap.fullname" . }}:{{ .Values.oap.ports.zipkinQuery }}"
{{- end }}
```
I think it might be more convenient. What do you think? @kezhenxu94 @Yangfisher1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI
Posted by "Yangfisher1 (via GitHub)" <gi...@apache.org>.
Yangfisher1 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649561819
@kezhenxu94
> We can use zipkinreceiver or zipkinquery?
I'm ok with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #127:
URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649551697
I vote for not to use `index` function, using `.` is also friendly for completion in IDEs。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org