[jira] [Commented] (HADOOP-12469) distcp should not ignore the ignoreFailures option

["Jing Zhao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269816#comment-15269816 ] 

Jing Zhao commented on HADOOP-12469:
------------------------------------

Instead of replacing the old unit test (which deletes some source files to generate failures), maybe we can add a new unit test. +1 after addressing the comment.

> distcp should not ignore the ignoreFailures option
> --------------------------------------------------
>
>                 Key: HADOOP-12469
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12469
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools/distcp
>    Affects Versions: 2.7.1
>            Reporter: Gera Shegalov
>            Assignee: Mingliang Liu
>            Priority: Critical
>         Attachments: HADOOP-12469.000.patch, HADOOP-12469.001.patch, HADOOP-12469.002.patch, HADOOP-12469.003.patch, HADOOP-12469.004.patch, HADOOP-12469.005.patch, HADOOP-12469.005.patch
>
>
> {{RetriableFileCopyCommand.CopyReadException}} is double-wrapped via
> # via {{RetriableCommand::execute}}
> # via {{CopyMapper#copyFileWithRetry}}
> before {{CopyMapper::handleFailure}} tests 
> {code}
> if (ignoreFailures && exception.getCause() instanceof
>             RetriableFileCopyCommand.CopyReadException
> {code}
> which is always false.
> Orthogonally, ignoring failures should be mutually exclusive with the atomic option otherwise an incomplete dir is eligible for commit defeating the purpose.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org