You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/18 11:03:15 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #14873: Fix broken endpoints due to dagrun id being quoted in url path
ephraimbuddy opened a new pull request #14873:
URL: https://github.com/apache/airflow/pull/14873
The endpoints accepting dag_run_id are broken when you make a call
against them using tools like postman.
This is because the dagrun id is being quoted in the url.
A dagrun id "manual__2021-03-12T09:40:00.745000+00:00" changes to
"manual__2021-03-12T09:40:00.745000%252B00:00" on the url and then
we cannot find the dagrun that has the ID.
This started recently and I can't pin it to any library.
This commit resolves this issue by unquoting it. Tests were also modified
to have quoted dagrun id in the url
Would appreciate a suggestion on a better way to resolve this
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #14873: Fix broken endpoints due to dagrun id being quoted in url path
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #14873:
URL: https://github.com/apache/airflow/pull/14873#issuecomment-802217392
Closing because this error was from my postman. After restarting the postman, everything started working fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy closed pull request #14873: Fix broken endpoints due to dagrun id being quoted in url path
Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed pull request #14873:
URL: https://github.com/apache/airflow/pull/14873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org