You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:14:55 UTC
[GitHub] [flink] zhuxiaoshang opened a new pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
zhuxiaoshang opened a new pull request #13907:
URL: https://github.com/apache/flink/pull/13907
## What is the purpose of the change
*Support sink parallelism configuration to JDBC connector*
## Brief change log
- *Support sink parallelism configuration to JDBC connector*
## Verifying this change
This change added tests and can be verified as follows:
- *JdbcDynamicTableFactoryTest#testJDBCSinkWithParallelism*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539033397
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -55,6 +61,10 @@ public int getMaxRetries() {
return maxRetries;
}
+ public Integer getParallelism() {
+ return parallelism;
+ }
+
@Override
public boolean equals(Object o) {
if (this == o) {
Review comment:
Yes you are right @zhisheng17 ,I ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] V1ncentzzZ commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
V1ncentzzZ commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539042698
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -66,12 +76,13 @@ public boolean equals(Object o) {
JdbcExecutionOptions that = (JdbcExecutionOptions) o;
return batchIntervalMs == that.batchIntervalMs &&
batchSize == that.batchSize &&
- maxRetries == that.maxRetries;
+ maxRetries == that.maxRetries &&
+ parallelism == that.parallelism;
Review comment:
My suggestion is that use `equals()` instead of `==` beacause of the `==` will return false when parallelism's value more than 128.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "7137b6fcfa8f92478118215f47042927c49f4752",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10805",
"triggerID" : "7137b6fcfa8f92478118215f47042927c49f4752",
"triggerType" : "PUSH"
}, {
"hash" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810",
"triggerID" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"triggerType" : "PUSH"
}, {
"hash" : "9341091a00aaf73556b7e6c5f9bc319a9512dd5a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11093",
"triggerID" : "9341091a00aaf73556b7e6c5f9bc319a9512dd5a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 9341091a00aaf73556b7e6c5f9bc319a9512dd5a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11093)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49181d26aa6a07bc289544ad0d55929fd2c89377 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695)
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] V1ncentzzZ commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
V1ncentzzZ commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539042698
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -66,12 +76,13 @@ public boolean equals(Object o) {
JdbcExecutionOptions that = (JdbcExecutionOptions) o;
return batchIntervalMs == that.batchIntervalMs &&
batchSize == that.batchSize &&
- maxRetries == that.maxRetries;
+ maxRetries == that.maxRetries &&
+ parallelism == that.parallelism;
Review comment:
My suggestion is that use `equals()` instead of `==` beacause `==` will return false when parallelism's vlue more than 128.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f034600ded37284e626caf3784e783c5ae67a8eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539145192
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/OutputFormatProvider.java
##########
@@ -36,6 +38,23 @@ static OutputFormatProvider of(OutputFormat<RowData> outputFormat) {
return () -> outputFormat;
Review comment:
@fsk119 I have rebased to master,but push failed.What should I do next.
MacBook-Pro:flink admin$ git rebase master
当前分支 FLINK-19942 是最新的。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49181d26aa6a07bc289544ad0d55929fd2c89377 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695)
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* a20a54634b452b7a9fbc28e3a292196376602b3f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f034600ded37284e626caf3784e783c5ae67a8eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960)
* 49181d26aa6a07bc289544ad0d55929fd2c89377 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49181d26aa6a07bc289544ad0d55929fd2c89377 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695)
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* a20a54634b452b7a9fbc28e3a292196376602b3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692)
* 5ba8c4410ef2616561f46462d1000056949e8c6b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "7137b6fcfa8f92478118215f47042927c49f4752",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10805",
"triggerID" : "7137b6fcfa8f92478118215f47042927c49f4752",
"triggerType" : "PUSH"
}, {
"hash" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810",
"triggerID" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539145192
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/OutputFormatProvider.java
##########
@@ -36,6 +38,23 @@ static OutputFormatProvider of(OutputFormat<RowData> outputFormat) {
return () -> outputFormat;
Review comment:
@fsk119 I have rebased to master,but push failed.What should I do next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r540811448
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/OutputFormatProvider.java
##########
@@ -23,17 +23,29 @@
import org.apache.flink.table.connector.ParallelismProvider;
import org.apache.flink.table.data.RowData;
+import java.util.Optional;
+
/**
* Provider of an {@link OutputFormat} instance as a runtime implementation for {@link DynamicTableSink}.
*/
@PublicEvolving
public interface OutputFormatProvider extends DynamicTableSink.SinkRuntimeProvider, ParallelismProvider {
/**
- * Helper method for creating a static provider.
+ * Helper method for creating a static provider with a provided sink parallelism.
*/
- static OutputFormatProvider of(OutputFormat<RowData> outputFormat) {
- return () -> outputFormat;
+ static OutputFormatProvider of(OutputFormat<RowData> outputFormat, Integer sinkParallelism) {
Review comment:
ok，got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r540804324
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/OutputFormatProvider.java
##########
@@ -23,17 +23,29 @@
import org.apache.flink.table.connector.ParallelismProvider;
import org.apache.flink.table.data.RowData;
+import java.util.Optional;
+
/**
* Provider of an {@link OutputFormat} instance as a runtime implementation for {@link DynamicTableSink}.
*/
@PublicEvolving
public interface OutputFormatProvider extends DynamicTableSink.SinkRuntimeProvider, ParallelismProvider {
/**
- * Helper method for creating a static provider.
+ * Helper method for creating a static provider with a provided sink parallelism.
*/
- static OutputFormatProvider of(OutputFormat<RowData> outputFormat) {
- return () -> outputFormat;
+ static OutputFormatProvider of(OutputFormat<RowData> outputFormat, Integer sinkParallelism) {
Review comment:
This is a public API. We don't know whether it is used by external projects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-749309407
The failed test is not related to this PR, it has been tracked by FLINK-20433. Will merge this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539043341
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -66,12 +76,13 @@ public boolean equals(Object o) {
JdbcExecutionOptions that = (JdbcExecutionOptions) o;
return batchIntervalMs == that.batchIntervalMs &&
batchSize == that.batchSize &&
- maxRetries == that.maxRetries;
+ maxRetries == that.maxRetries &&
+ parallelism == that.parallelism;
Review comment:
ok,I have changed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhisheng17 commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhisheng17 commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r535869471
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -55,6 +61,10 @@ public int getMaxRetries() {
return maxRetries;
}
+ public Integer getParallelism() {
+ return parallelism;
+ }
+
@Override
public boolean equals(Object o) {
if (this == o) {
Review comment:
does the equals and hash function need to be modify? @zhuxiaoshang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 5ba8c4410ef2616561f46462d1000056949e8c6b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* a20a54634b452b7a9fbc28e3a292196376602b3f Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692)
* 5ba8c4410ef2616561f46462d1000056949e8c6b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "7137b6fcfa8f92478118215f47042927c49f4752",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10805",
"triggerID" : "7137b6fcfa8f92478118215f47042927c49f4752",
"triggerType" : "PUSH"
}, {
"hash" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810",
"triggerID" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"triggerType" : "PUSH"
}, {
"hash" : "9341091a00aaf73556b7e6c5f9bc319a9512dd5a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9341091a00aaf73556b7e6c5f9bc319a9512dd5a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810)
* 9341091a00aaf73556b7e6c5f9bc319a9512dd5a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
fsk119 commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539088462
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/OutputFormatProvider.java
##########
@@ -36,6 +38,23 @@ static OutputFormatProvider of(OutputFormat<RowData> outputFormat) {
return () -> outputFormat;
Review comment:
It's seem this method is useless now? If no one uses it, please delete it. Otherwise, we can just treat this method as
`of(outputFormat, null)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49181d26aa6a07bc289544ad0d55929fd2c89377 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695)
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* a20a54634b452b7a9fbc28e3a292196376602b3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1df51c117b6d0b9e831875ef96dea8eec684b3ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
fsk119 commented on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-742297048
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] V1ncentzzZ commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
V1ncentzzZ commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539042698
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -66,12 +76,13 @@ public boolean equals(Object o) {
JdbcExecutionOptions that = (JdbcExecutionOptions) o;
return batchIntervalMs == that.batchIntervalMs &&
batchSize == that.batchSize &&
- maxRetries == that.maxRetries;
+ maxRetries == that.maxRetries &&
+ parallelism == that.parallelism;
Review comment:
My suggestion is that use `equals()` instead of `==` beacause the `==` will return false when parallelism's value more than 128.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 5ba8c4410ef2616561f46462d1000056949e8c6b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "7137b6fcfa8f92478118215f47042927c49f4752",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10805",
"triggerID" : "7137b6fcfa8f92478118215f47042927c49f4752",
"triggerType" : "PUSH"
}, {
"hash" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810",
"triggerID" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"triggerType" : "PUSH"
}, {
"hash" : "9341091a00aaf73556b7e6c5f9bc319a9512dd5a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11093",
"triggerID" : "9341091a00aaf73556b7e6c5f9bc319a9512dd5a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810)
* 9341091a00aaf73556b7e6c5f9bc319a9512dd5a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11093)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "7137b6fcfa8f92478118215f47042927c49f4752",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10805",
"triggerID" : "7137b6fcfa8f92478118215f47042927c49f4752",
"triggerType" : "PUSH"
}, {
"hash" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810",
"triggerID" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 5ba8c4410ef2616561f46462d1000056949e8c6b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705)
* 7137b6fcfa8f92478118215f47042927c49f4752 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10805)
* 6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49181d26aa6a07bc289544ad0d55929fd2c89377 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695)
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* a20a54634b452b7a9fbc28e3a292196376602b3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692)
* 5ba8c4410ef2616561f46462d1000056949e8c6b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r540788857
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/OutputFormatProvider.java
##########
@@ -23,17 +23,29 @@
import org.apache.flink.table.connector.ParallelismProvider;
import org.apache.flink.table.data.RowData;
+import java.util.Optional;
+
/**
* Provider of an {@link OutputFormat} instance as a runtime implementation for {@link DynamicTableSink}.
*/
@PublicEvolving
public interface OutputFormatProvider extends DynamicTableSink.SinkRuntimeProvider, ParallelismProvider {
/**
- * Helper method for creating a static provider.
+ * Helper method for creating a static provider with a provided sink parallelism.
*/
- static OutputFormatProvider of(OutputFormat<RowData> outputFormat) {
- return () -> outputFormat;
+ static OutputFormatProvider of(OutputFormat<RowData> outputFormat, Integer sinkParallelism) {
Review comment:
According to @fsk119 's suggestion,I removed the old method because it is never used.
If not i can get it back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539145192
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/OutputFormatProvider.java
##########
@@ -36,6 +38,23 @@ static OutputFormatProvider of(OutputFormat<RowData> outputFormat) {
return () -> outputFormat;
Review comment:
@fsk119 I have rebased to master,but push failed.What should I do next.
MacBook-Pro:flink admin$ git rebase master
当前分支 FLINK-19942 是最新的。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 5ba8c4410ef2616561f46462d1000056949e8c6b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1df51c117b6d0b9e831875ef96dea8eec684b3ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945)
* f034600ded37284e626caf3784e783c5ae67a8eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-741541002
cc @fsk119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "7137b6fcfa8f92478118215f47042927c49f4752",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7137b6fcfa8f92478118215f47042927c49f4752",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 5ba8c4410ef2616561f46462d1000056949e8c6b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705)
* 7137b6fcfa8f92478118215f47042927c49f4752 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-728811786
cc @JingsongLi @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "7137b6fcfa8f92478118215f47042927c49f4752",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10805",
"triggerID" : "7137b6fcfa8f92478118215f47042927c49f4752",
"triggerType" : "PUSH"
}, {
"hash" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810",
"triggerID" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 7137b6fcfa8f92478118215f47042927c49f4752 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10805)
* 6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10810)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721092368
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f6a4af31d07c0dca46b3493a1fb968626cd0c05e (Tue Nov 03 12:40:53 UTC 2020)
**Warnings:**
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19942).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r540754136
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/OutputFormatProvider.java
##########
@@ -23,17 +23,29 @@
import org.apache.flink.table.connector.ParallelismProvider;
import org.apache.flink.table.data.RowData;
+import java.util.Optional;
+
/**
* Provider of an {@link OutputFormat} instance as a runtime implementation for {@link DynamicTableSink}.
*/
@PublicEvolving
public interface OutputFormatProvider extends DynamicTableSink.SinkRuntimeProvider, ParallelismProvider {
/**
- * Helper method for creating a static provider.
+ * Helper method for creating a static provider with a provided sink parallelism.
*/
- static OutputFormatProvider of(OutputFormat<RowData> outputFormat) {
- return () -> outputFormat;
+ static OutputFormatProvider of(OutputFormat<RowData> outputFormat, Integer sinkParallelism) {
Review comment:
This is a public API. Please add a new method instead of changing the existing one, otherwise, it's not API compatible.
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -35,12 +35,18 @@
private final long batchIntervalMs;
private final int batchSize;
private final int maxRetries;
+ private final Integer parallelism;
- private JdbcExecutionOptions(long batchIntervalMs, int batchSize, int maxRetries) {
+ private JdbcExecutionOptions(
+ long batchIntervalMs,
+ int batchSize,
+ int maxRetries,
+ Integer parallelism) {
Review comment:
I'm not sure about adding this to `JdbcExecutionOptions`, because `JdbcExecutionOptions` is an public API for `JdbcSink`. For `JdbcSink#sink`, this may looks weird because the configured parallelism doesn't work as the returned object is `SinkFunction`.
Another option is adding the parallelism to `JdbcDmlOption` or `JdbcOption`, they are both internal class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1df51c117b6d0b9e831875ef96dea8eec684b3ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945)
* f034600ded37284e626caf3784e783c5ae67a8eb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6a4af31d07c0dca46b3493a1fb968626cd0c05e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6a4af31d07c0dca46b3493a1fb968626cd0c05e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 5ba8c4410ef2616561f46462d1000056949e8c6b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49181d26aa6a07bc289544ad0d55929fd2c89377 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6a4af31d07c0dca46b3493a1fb968626cd0c05e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539039936
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -66,12 +76,13 @@ public boolean equals(Object o) {
JdbcExecutionOptions that = (JdbcExecutionOptions) o;
return batchIntervalMs == that.batchIntervalMs &&
batchSize == that.batchSize &&
- maxRetries == that.maxRetries;
+ maxRetries == that.maxRetries &&
+ parallelism == that.parallelism;
Review comment:
Maybe the framework will check whether the parallelism > max parallelism limit.
Moreover where do you get the 128?IIRC,128 is the limit of max keyGroup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f034600ded37284e626caf3784e783c5ae67a8eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960)
* 49181d26aa6a07bc289544ad0d55929fd2c89377 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6a4af31d07c0dca46b3493a1fb968626cd0c05e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905)
* 1df51c117b6d0b9e831875ef96dea8eec684b3ad UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhisheng17 commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
zhisheng17 commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539038786
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -66,12 +76,13 @@ public boolean equals(Object o) {
JdbcExecutionOptions that = (JdbcExecutionOptions) o;
return batchIntervalMs == that.batchIntervalMs &&
batchSize == that.batchSize &&
- maxRetries == that.maxRetries;
+ maxRetries == that.maxRetries &&
+ parallelism == that.parallelism;
Review comment:
@zhuxiaoshang maybe, idea will recommend to use `equals()` instead of `==`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13907:
URL: https://github.com/apache/flink/pull/13907#issuecomment-721230727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8905",
"triggerID" : "f6a4af31d07c0dca46b3493a1fb968626cd0c05e",
"triggerType" : "PUSH"
}, {
"hash" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8945",
"triggerID" : "1df51c117b6d0b9e831875ef96dea8eec684b3ad",
"triggerType" : "PUSH"
}, {
"hash" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8960",
"triggerID" : "f034600ded37284e626caf3784e783c5ae67a8eb",
"triggerType" : "PUSH"
}, {
"hash" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9695",
"triggerID" : "49181d26aa6a07bc289544ad0d55929fd2c89377",
"triggerType" : "PUSH"
}, {
"hash" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4f1cf14d4d413c4c87881516215c7ffffd5be64",
"triggerType" : "PUSH"
}, {
"hash" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10692",
"triggerID" : "a20a54634b452b7a9fbc28e3a292196376602b3f",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"triggerType" : "PUSH"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "5ba8c4410ef2616561f46462d1000056949e8c6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705",
"triggerID" : "742297048",
"triggerType" : "MANUAL"
}, {
"hash" : "7137b6fcfa8f92478118215f47042927c49f4752",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10805",
"triggerID" : "7137b6fcfa8f92478118215f47042927c49f4752",
"triggerType" : "PUSH"
}, {
"hash" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4f1cf14d4d413c4c87881516215c7ffffd5be64 UNKNOWN
* 5ba8c4410ef2616561f46462d1000056949e8c6b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10745) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10705)
* 7137b6fcfa8f92478118215f47042927c49f4752 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10805)
* 6acdd717e9e7a4f23bf7d798e72b8e50c5ff4e83 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] V1ncentzzZ commented on a change in pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
V1ncentzzZ commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539037013
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -66,12 +76,13 @@ public boolean equals(Object o) {
JdbcExecutionOptions that = (JdbcExecutionOptions) o;
return batchIntervalMs == that.batchIntervalMs &&
batchSize == that.batchSize &&
- maxRetries == that.maxRetries;
+ maxRetries == that.maxRetries &&
+ parallelism == that.parallelism;
Review comment:
Will return false when parallelism > 128?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #13907: [FLINK-19942][Connectors / JDBC]Support sink parallelism configuration to JDBC connector
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13907:
URL: https://github.com/apache/flink/pull/13907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org