You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/04 10:18:27 UTC

[GitHub] [flink] wuchong commented on pull request #17933: [FLINK-24948][jdbc] Fix bug that special character in column names breaks JDBC statement parsing

wuchong commented on pull request #17933:
URL: https://github.com/apache/flink/pull/17933#issuecomment-1059028730


   Thanks @link3280 for the contribution and sorry for the late reviewing. 
   
   The fixing looks good to me. But could you add one IT case for it? For example, add a SELECT case in `JdbcDynamicTableSourceITCase` to read a table with the special characters in column names. 
   
   Besides, please also rebase branch to latest master. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org