[GitHub] [hive] deniskuzZ commented on a diff in pull request #3372: HIVE-26177: Amendment: Initialize datanucleus compaction pool only on HMS Leader & pool sizing

[GitBox <gi...@apache.org>]

deniskuzZ commented on code in PR #3372:
URL: https://github.com/apache/hive/pull/3372#discussion_r897628576


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java:
##########
@@ -160,14 +162,14 @@ public static void updatePmfProperties(Configuration conf) {
     boolean readLockAcquired = true;
     try {
       // if pmf properties change, need to update, release read lock and take write lock
-      if (prop == null || pmf == null || !propsFromConf.equals(prop)) {
+      if (pmf == null || !propsFromConf.equals(prop)) {

Review Comment:
   unnecessary null check, `!propsFromConf.equals(prop)` covers it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org