You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2010/08/19 17:07:47 UTC

[jira] Created: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
---------------------------------------------------------------------------------------

                 Key: CAMEL-3065
                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
             Project: Apache Camel
          Issue Type: Improvement
          Components: camel-netty
    Affects Versions: 2.4.0
            Reporter: Claus Ibsen
            Priority: Minor
             Fix For: 2.5.0


See nabble
http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-3065:
-------------------------------

    Fix Version/s: 3.0.0
                       (was: 2.5.0)

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Priority: Minor
>             Fix For: 3.0.0
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-3065:
-------------------------------

    Fix Version/s: 3.0.0
                       (was: 2.5.0)
      Component/s: camel-mina

Do the same fix on camel-mina as well, when implement this ticket.

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-mina, camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61628#action_61628 ] 

Claus Ibsen commented on CAMEL-3065:
------------------------------------

Ashwin the patch will affect current logic, as they don't consider the MEP at all.

So we should wait until Camel 3.0 to change this. Then we can alter both camel-netty and camel-mina to use the new behavior.


> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 2.5.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61598#action_61598 ] 

Hadrian Zbarcea edited comment on CAMEL-3065 at 9/1/10 5:26 PM:
----------------------------------------------------------------

@Ashwin, 
Thanks for the patch, it is indeed straightforward. Two comments though:
1. i think {{sendReply}} is equally confusing (in a different way) and my preference would be {{inOut}}. Since this is what happens anyway, the exchange will be InOut, it is imho clearer what the semantics of this option is.
2. You are now a committer, so please free to commit the code unless you have doubts in which case attaching a patch or adding a link to a git branch is ok. I doubt you had doubts in this case :).

One more thing. I am not sure if this is necessary, camel-netty being fairly new, but if you want to just deprecate @sync, you can mark isSync() and setSync as @deprecated and have them get/set {{inOut}} (assuming you will use that instead of {{sendReply}}).

      was (Author: hadrian):
    @Ashwin, 
Thanks for the patch, it is indeed straightforward. Two comments though:
1. i think {{sendReply}} is equally confusing (in a different way) and my preference would be {{inOut}}. Since this is what happens anyway, the exchange will be InOut, it is imho clearer what the semantics of this option is.
2. You are now a committer, so please free to commit the code unless you have doubts in which case attaching a patch or adding a link to a git branch is ok. I doubt you had doubts in this case :).
  
> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe reassigned CAMEL-3065:
-----------------------------------

    Assignee: Ashwin Karpe

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 3.0.0
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61633#action_61633 ] 

Ashwin Karpe commented on CAMEL-3065:
-------------------------------------

Sure Claus.

I will make this fix on Netty and Mina in version 3.0.

Cheers,

Ashwin...

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-mina, camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61607#action_61607 ] 

Claus Ibsen commented on CAMEL-3065:
------------------------------------

Actually I think we should change this for Camel 3.0, to keep the old behavior in the 2.x.
Because both camel-netty and camel-mina have the {{sync}} option.

In Camel 3.0 we can change that to check the MEP of the Exchange being InOut and then automatic expect a reply.
Hence I would like to wait with this for Camel 3.0, and also update camel-mina as well.

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 2.5.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea updated CAMEL-3065:
-----------------------------------

    Fix Version/s: 2.5.0
                       (was: 3.0.0)

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 2.5.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61598#action_61598 ] 

Hadrian Zbarcea edited comment on CAMEL-3065 at 9/1/10 8:06 PM:
----------------------------------------------------------------

@Ashwin, 
Thanks for the patch, it is indeed straightforward. Two comments though:
1. i think {{sendReply}} is equally confusing (in a different way) and my preference would be {{inOut}}. Since this is what happens anyway, the exchange will be InOut, it is imho clearer what the semantics of this option is. Or, if you want, you can have it as a String instead of boolean and call it {{mep}} (better then just {{pattern}} I guess, with possible values inOnly or inOut with the former being the default). 
2. You are now a committer, so please free to commit the code unless you have doubts in which case attaching a patch or adding a link to a git branch is ok. I doubt you had doubts in this case :).

One more thing. I am not sure if this is necessary, camel-netty being fairly new, but if you want to just deprecate @sync, you can mark isSync() and setSync as @deprecated and have them get/set {{inOut}} (assuming you will use that instead of {{sendReply}}).

      was (Author: hadrian):
    @Ashwin, 
Thanks for the patch, it is indeed straightforward. Two comments though:
1. i think {{sendReply}} is equally confusing (in a different way) and my preference would be {{inOut}}. Since this is what happens anyway, the exchange will be InOut, it is imho clearer what the semantics of this option is.
2. You are now a committer, so please free to commit the code unless you have doubts in which case attaching a patch or adding a link to a git branch is ok. I doubt you had doubts in this case :).

One more thing. I am not sure if this is necessary, camel-netty being fairly new, but if you want to just deprecate @sync, you can mark isSync() and setSync as @deprecated and have them get/set {{inOut}} (assuming you will use that instead of {{sendReply}}).
  
> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61297#action_61297 ] 

Claus Ibsen commented on CAMEL-3065:
------------------------------------

The consumer needs to have a sync option.

So we may want to rename it to {{sendReply=true|false}} so its more obvious what it does.
Then the producer side uses the MEP of the Exchange to decide if it should wait for a reply or not. So the option only apply for the consumer.

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.5.0
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61318#action_61318 ] 

Claus Ibsen commented on CAMEL-3065:
------------------------------------

However the sync option was inspired from the camel-mina component which has this option.

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.5.0
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-3065 started by Ashwin Karpe.

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 3.0.0
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe updated CAMEL-3065:
--------------------------------

    Attachment: CAMEL-3065-fix.diff

Hi Claus,

I have fixed this rather straightforward issue and attached a diff file for your review.

It is a very simple change for changing sync to sendReply along with its getter/setter. I did have to fix a whole lot of tests to use sendReply instead of sync.

Can you please let me know what you think. I will check it in following your +1.

Cheers,

Ashwin...

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61624#action_61624 ] 

Ashwin Karpe commented on CAMEL-3065:
-------------------------------------

Hi Hadrian & Claus,

I will change the code to use inOut instead of sendReply. I will attach and commit a fresh patch.

Claus, would you rather this fix go in 3.x or would you prefer that I mark sync as deprecated and introduce a new inOut as an option. This will not break anybody in 2.x but will create the necessary capability for future adopters.

Please let me know.

Cheers,

Ashwin...   

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 2.5.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61598#action_61598 ] 

Hadrian Zbarcea commented on CAMEL-3065:
----------------------------------------

@Ashwin, 
Thanks for the patch, it is indeed straightforward. Two comments though:
1. i think {{sendReply}} is equally confusing (in a different way) and my preference would be {{inOut}}. Since this is what happens anyway, the exchange will be InOut, it is imho clearer what the semantics of this option is.
2. You are now a committer, so please free to commit the code unless you have doubts in which case attaching a patch or adding a link to a git branch is ok. I doubt you had doubts in this case :).

> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CAMEL-3065) Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61596#action_61596 ] 

Ashwin Karpe edited comment on CAMEL-3065 at 9/1/10 3:41 PM:
-------------------------------------------------------------

Hi Claus,

I have fixed this rather straightforward issue and attached a diff file for your review.

It is a very simple change for changing sync to sendReply along with its getter/setter. I did have to fix a whole lot of tests along with some netty classes that looked up sync to use sendReply instead of sync.

Can you please let me know what you think. I will check it in following your +1.

Cheers,

Ashwin...

      was (Author: akarpe):
    Hi Claus,

I have fixed this rather straightforward issue and attached a diff file for your review.

It is a very simple change for changing sync to sendReply along with its getter/setter. I did have to fix a whole lot of tests to use sendReply instead of sync.

Can you please let me know what you think. I will check it in following your +1.

Cheers,

Ashwin...
  
> Netty - @deprecated sync option and let it use the MEP to decide if its InOnly or InOut
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3065
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-3065
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-netty
>    Affects Versions: 2.4.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.