You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/06/09 10:36:38 UTC
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2829: Make secret id static and remove thrift protocol from RPC handles
codecov-commenter commented on PR #2829:
URL: https://github.com/apache/incubator-kyuubi/pull/2829#issuecomment-1150957683
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2829](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb63997) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/ead33d79771ca422319032f32f93fe5f1f264f49?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ead33d7) will **decrease** coverage by `0.04%`.
> The diff coverage is `91.86%`.
```diff
@@ Coverage Diff @@
## master #2829 +/- ##
============================================
- Coverage 63.37% 63.32% -0.05%
- Complexity 203 205 +2
============================================
Files 485 485
Lines 21731 21683 -48
Branches 2864 2857 -7
============================================
- Hits 13771 13731 -40
+ Misses 6659 6655 -4
+ Partials 1301 1297 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...uubi/engine/flink/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `47.94% <ø> (+0.32%)` | :arrow_up: |
| [...kyuubi/engine/flink/session/FlinkSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9zZXNzaW9uL0ZsaW5rU2Vzc2lvbkltcGwuc2NhbGE=) | `82.35% <ø> (-0.99%)` | :arrow_down: |
| [...g/apache/kyuubi/client/api/v1/dto/SessionData.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vU2Vzc2lvbkRhdGEuamF2YQ==) | `42.10% <40.00%> (ø)` | |
| [...apache/kyuubi/client/api/v1/dto/SessionHandle.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vU2Vzc2lvbkhhbmRsZS5qYXZh) | `58.33% <66.66%> (-13.10%)` | :arrow_down: |
| [...cala/org/apache/kyuubi/session/SessionHandle.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25IYW5kbGUuc2NhbGE=) | `81.25% <85.71%> (-4.47%)` | :arrow_down: |
| [.../org/apache/kyuubi/operation/OperationHandle.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vT3BlcmF0aW9uSGFuZGxlLnNjYWxh) | `90.69% <92.30%> (ø)` | |
| [...kyuubi/engine/flink/operation/FlinkOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9vcGVyYXRpb24vRmxpbmtPcGVyYXRpb24uc2NhbGE=) | `70.17% <100.00%> (-0.52%)` | :arrow_down: |
| [.../src/main/scala/org/apache/kyuubi/cli/Handle.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGkvSGFuZGxlLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...e/kyuubi/server/KyuubiTBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpVEJpbmFyeUZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `84.84% <100.00%> (ø)` | |
| [.../apache/kyuubi/server/api/v1/BatchesResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0JhdGNoZXNSZXNvdXJjZS5zY2FsYQ==) | `86.36% <100.00%> (+0.23%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ead33d7...eb63997](https://codecov.io/gh/apache/incubator-kyuubi/pull/2829?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org