You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "david1859168 (via GitHub)" <gi...@apache.org> on 2024/01/05 06:36:53 UTC

[PR] HDDS-9650. Remove dead code using getRequestType via reflections [ozone]

david1859168 opened a new pull request, #5927:
URL: https://github.com/apache/ozone/pull/5927

   ## What changes were proposed in this pull request?
   Removed the dead method "getRequestType". 
   
   Please describe your PR in detail:
   Removed the getRequestType method from the following classes. There is some leftover usage of this method via reflection. Such code is dead (tests are disabled, and production code is unused.)
   
   https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMLayoutVersionManager.java#L130-L157
   
   https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOMVersionManager.java#L108-L141
   
   https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOmVersionManagerRequestFactory.java#L104-L106
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-9650
   
   ## How was this patch tested?
   Ran unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-9650. Remove dead code using getRequestType via reflections [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5927:
URL: https://github.com/apache/ozone/pull/5927


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org