[GitHub] ptaube opened a new pull request #3417: Allow tabs for indentation in go code

[GitBox <gi...@apache.org>]

ptaube opened a new pull request #3417: Allow tabs for indentation in go code
URL: https://github.com/apache/incubator-openwhisk/pull/3417
 
 
   ## Description
   
   Right now scanCode.cfg contains following line
   *.go=has_block_license, no_tabs, no_trailing_spaces, eol_at_eof
   which causes any go code which contains tabs to be rejected in builds. Actually it's standard in go to use tabs and gofmt - the standard formatting tool in go - reformats all go code to use tabs for indentation.
   
   In order to get go code be accepted according go coding standards
   *.go=has_block_license, no_tabs, no_trailing_spaces, eol_at_eof
   has to be changed to
   *.go=has_block_license, no_trailing_spaces, eol_at_eof
   
   ## Related issue and scope
   
   This PR adresses https://github.com/apache/incubator-openwhisk/issues/3403
   - [x] I opened an issue to propose and discuss this change 
   
   Build and tests were executed in PD1#2698.  One test `whisk.core.admin.WskAdminTests.Wsk Admin CLI should block and unblock a user respectively` failed but is not related to the cfg change.
   
   ## My changes affect the following components
   
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [x] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   The change just allows go source code to contain tabs according go standard.
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services