You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2023/05/24 06:40:58 UTC
[maven-surefire] 02/02: fix SAX bug
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch backport
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
commit d9d63c93c6d12a500fc159cc6f897f0e046ccb3f
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Mon May 22 19:06:39 2023 +0200
fix SAX bug
---
.../apache/maven/plugins/surefire/report/TestSuiteXmlParser.java | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java b/surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java
index 95b31623b..eabe10046 100644
--- a/surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java
+++ b/surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java
@@ -124,6 +124,8 @@ public final class TestSuiteXmlParser extends DefaultHandler {
classesToSuitesIndex.put(defaultSuite.getFullClassName(), suites.size() - 1);
break;
case "testcase":
+ // Although this element does not contain any text, this line must be retained because the
+ // nested elements do have text content.
currentElement = new StringBuilder();
testCase = new ReportTestCase().setName(attributes.getValue("name"));
@@ -154,10 +156,14 @@ public final class TestSuiteXmlParser extends DefaultHandler {
}
break;
case "failure":
+ currentElement = new StringBuilder();
+
testCase.setFailure(attributes.getValue("message"), attributes.getValue("type"));
currentSuite.incrementNumberOfFailures();
break;
case "error":
+ currentElement = new StringBuilder();
+
testCase.setError(attributes.getValue("message"), attributes.getValue("type"));
currentSuite.incrementNumberOfErrors();
break;
@@ -173,6 +179,9 @@ public final class TestSuiteXmlParser extends DefaultHandler {
case "failsafe-summary":
valid = false;
break;
+ case "time":
+ currentElement = new StringBuilder();
+ break;
default:
break;
}