You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/29 15:57:00 UTC
[jira] [Commented] (ARROW-1600) [C++] Zero-copy Buffer constructor
from std::string
[ https://issues.apache.org/jira/browse/ARROW-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186016#comment-16186016 ]
ASF GitHub Bot commented on ARROW-1600:
---------------------------------------
GitHub user wesm opened a pull request:
https://github.com/apache/arrow/pull/1147
ARROW-1600: [C++] Add Buffer constructor that wraps std::string
Many other libraries interchange binary data with `std::string`. This makes it easy to wrap such data in an `arrow::Buffer``.
It may be worth adding a function that creates a buffer from a string, but owns its memory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wesm/arrow ARROW-1600
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1147.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1147
----
commit 644bf2b75ded36c5be7100067e332cb42ff05d18
Author: Wes McKinney <we...@twosigma.com>
Date: 2017-09-29T15:53:47Z
Add Buffer ctor that wraps std::string
Change-Id: Ic41686a276f35c61f4fa0aca9f79f2b4c3e91482
----
> [C++] Zero-copy Buffer constructor from std::string
> ---------------------------------------------------
>
> Key: ARROW-1600
> URL: https://issues.apache.org/jira/browse/ARROW-1600
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> There are instances where we may process an Arrow stream stored in an {{std::string}}, and there's a bit of typing to construct a {{io::BufferReader}} from an {{std::string}}, so we can make this simpler
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)