[GitHub] [doris] yiguolei commented on a diff in pull request #21239: [improvement](olap) filter the whole segment by dictionary

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #21239:
URL: https://github.com/apache/doris/pull/21239#discussion_r1243497498


##########
be/src/olap/block_column_predicate.h:
##########
@@ -81,6 +81,12 @@ class BlockColumnPredicate {
         LOG(FATAL) << "should not reach here";
         return true;
     }
+
+    virtual bool evaluate_and(const StringRef* dict_words, const size_t dict_num) const {

Review Comment:
   why not pass in std::vector<StringRef>&



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org