You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hughhhh (via GitHub)" <gi...@apache.org> on 2023/05/02 18:36:34 UTC

[GitHub] [superset] hughhhh opened a new pull request, #23909: fix: remove feature flag for tags on Dashboard API for `Tags`

hughhhh opened a new pull request, #23909:
URL: https://github.com/apache/superset/pull/23909

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Dashboard Tags don't appear on Dashboard CRUD View for superset, here's a PR to allow the columns to be exposed but the client will manage whether they appear
   
   ![Clipboard 2023-13-04 at 4 40 01 PM](https://user-images.githubusercontent.com/27827808/235755250-8541ec45-804e-42f2-965f-a22b20ba9733.png)
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] hughhhh merged pull request #23909: fix: remove feature flag for tags on Dashboard API for `Tags`

Posted by "hughhhh (via GitHub)" <gi...@apache.org>.
hughhhh merged PR #23909:
URL: https://github.com/apache/superset/pull/23909


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #23909: fix: remove feature flag for tags on Dashboard API for `Tags`

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23909:
URL: https://github.com/apache/superset/pull/23909#issuecomment-1531989552

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/23909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23909](https://app.codecov.io/gh/apache/superset/pull/23909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be37c6b) into [master](https://app.codecov.io/gh/apache/superset/commit/a8e02cd85181f415b48a9bc79c4c2e4a8c8b7737?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8e02cd) will **decrease** coverage by `0.83%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head be37c6b differs from pull request most recent head 383482b. Consider uploading reports for the commit 383482b to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #23909      +/-   ##
   ==========================================
   - Coverage   68.07%   67.25%   -0.83%     
   ==========================================
     Files        1939     1939              
     Lines       75012    75008       -4     
     Branches     8154     8154              
   ==========================================
   - Hits        51068    50447     -621     
   - Misses      21861    22478     +617     
     Partials     2083     2083              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `80.92% <ø> (-1.71%)` | :arrow_down: |
   | sqlite | `77.40% <ø> (+<0.01%)` | :arrow_up: |
   | unit | `52.82% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/23909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/dashboards/api.py](https://app.codecov.io/gh/apache/superset/pull/23909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `92.54% <ø> (+0.43%)` | :arrow_up: |
   
   ... and [40 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/23909/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org