[GitHub] bosschaert commented on issue #19: SLING-8174 - New MOJO implementation which creates a bundle for each api-region containing related APIs

[GitBox <gi...@apache.org>]

bosschaert commented on issue #19: SLING-8174 - New MOJO implementation which creates a bundle for each api-region containing related APIs
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/19#issuecomment-447310307
 
 
   Thanks for the tests @simonetripodi - I've merged you're PR :)
   Looking at the code it seems to me that it should be possible to create pure unit tests for the new Mojo, it would probably require using Mock objects.
   Personally I find junit tests easier when I need to debug or understand the code. And they run a lot faster which is nice too. 
   It might be an idea to try and add some pure unit tests afterwards for this new mojo, to see if it's possible to do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services