You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/08/25 20:43:10 UTC
[kudu-CR] dist test: honor EXTRA GRADLE FLAGS
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11329
Change subject: dist_test: honor EXTRA_GRADLE_FLAGS
......................................................................
dist_test: honor EXTRA_GRADLE_FLAGS
build-and-test.sh generates a list of flags with which configure gradle.
Unless these configurations are `export`ed, they won't be visible in
other processes, e.g. when running dist_test.py.
I didn't test the fix explicitly, but I ran the following to verify the
fix should work:
$ echo "import os
os.getenv('TEST_VAR')" > test.py
$ TEST_VAR=3
$ python test.py
$ export TEST_VAR=5
$ python test.py
5
Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/11329/1
--
To view, visit http://gerrit.cloudera.org:8080/11329
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
Gerrit-Change-Number: 11329
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] dist test: honor EXTRA GRADLE FLAGS
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11329 )
Change subject: dist_test: honor EXTRA_GRADLE_FLAGS
......................................................................
Patch Set 1:
The flags shouldn't be too critical since we don't use gradle to run the tests in dist-test, but this is still good for consistency.
--
To view, visit http://gerrit.cloudera.org:8080/11329
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
Gerrit-Change-Number: 11329
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 25 Aug 2018 20:50:26 +0000
Gerrit-HasComments: No
[kudu-CR] dist test: honor EXTRA GRADLE FLAGS
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11329 )
Change subject: dist_test: honor EXTRA_GRADLE_FLAGS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11329
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
Gerrit-Change-Number: 11329
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 25 Aug 2018 20:49:20 +0000
Gerrit-HasComments: No
[kudu-CR] build-and-test: export EXTRA GRADLE FLAGS
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11329 )
Change subject: build-and-test: export EXTRA_GRADLE_FLAGS
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11329
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
Gerrit-Change-Number: 11329
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 25 Aug 2018 21:02:08 +0000
Gerrit-HasComments: No
[kudu-CR] build-and-test: export EXTRA GRADLE FLAGS
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11329 )
Change subject: build-and-test: export EXTRA_GRADLE_FLAGS
......................................................................
build-and-test: export EXTRA_GRADLE_FLAGS
build-and-test.sh generates a list of flags with which to configure
gradle. Unless these configurations are `export`ed, they won't be
visible in other processes, e.g. when running dist_test.py.
Notably, this would result in dist_test.py calling gradlew with Scala
formatting (which breaks some builds), even though it was expected to be
disabled.
I didn't test the fix explicitly, but I ran the following to verify the
fix should work:
$ echo "import os
print os.getenv('TEST_VAR', '')" > test.py
$ TEST_VAR=3
$ python test.py
$ export TEST_VAR=5
$ python test.py
5
Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
Reviewed-on: http://gerrit.cloudera.org:8080/11329
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11329
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
Gerrit-Change-Number: 11329
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] build-and-test: export EXTRA GRADLE FLAGS
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11329
to look at the new patch set (#2).
Change subject: build-and-test: export EXTRA_GRADLE_FLAGS
......................................................................
build-and-test: export EXTRA_GRADLE_FLAGS
build-and-test.sh generates a list of flags with which to configure
gradle. Unless these configurations are `export`ed, they won't be
visible in other processes, e.g. when running dist_test.py.
Notably, this would result in dist_test.py calling gradlew with Scala
formatting (which breaks some builds), even though it was expected to be
disabled.
I didn't test the fix explicitly, but I ran the following to verify the
fix should work:
$ echo "import os
print os.getenv('TEST_VAR', '')" > test.py
$ TEST_VAR=3
$ python test.py
$ export TEST_VAR=5
$ python test.py
5
Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/11329/2
--
To view, visit http://gerrit.cloudera.org:8080/11329
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
Gerrit-Change-Number: 11329
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] build-and-test: export EXTRA GRADLE FLAGS
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11329 )
Change subject: build-and-test: export EXTRA_GRADLE_FLAGS
......................................................................
Patch Set 2:
> Patch Set 1:
>
> The flags shouldn't be too critical since we don't use gradle to run the tests in dist-test, but this is still good for consistency.
Ah, realized it wasn't clear why this is important. We'd end up running gradlew without -DskipFormat, and since KUDU-2524 is still open, that breaks some builds. Added that to the commit message
--
To view, visit http://gerrit.cloudera.org:8080/11329
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
Gerrit-Change-Number: 11329
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 25 Aug 2018 21:00:45 +0000
Gerrit-HasComments: No