You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-scm@portals.apache.org by as...@apache.org on 2017/11/22 19:53:21 UTC
portals-pluto git commit: PLUTO-667 TCK: Contesting
V2ResponseTests_MimeResponse_ApiRender_setContentType4 and
V2ResponseTests_RenderResponse_ApiRender_setContentType2
Repository: portals-pluto
Updated Branches:
refs/heads/master 33cdbe2cf -> 280e27344
PLUTO-667 TCK: Contesting V2ResponseTests_MimeResponse_ApiRender_setContentType4 and V2ResponseTests_RenderResponse_ApiRender_setContentType2
Project: http://git-wip-us.apache.org/repos/asf/portals-pluto/repo
Commit: http://git-wip-us.apache.org/repos/asf/portals-pluto/commit/280e2734
Tree: http://git-wip-us.apache.org/repos/asf/portals-pluto/tree/280e2734
Diff: http://git-wip-us.apache.org/repos/asf/portals-pluto/diff/280e2734
Branch: refs/heads/master
Commit: 280e27344b78c9ac514296b47e21a22855f7a6bd
Parents: 33cdbe2
Author: Neil Griffin <ne...@gmail.com>
Authored: Wed Nov 22 14:52:47 2017 -0500
Committer: Neil Griffin <ne...@gmail.com>
Committed: Wed Nov 22 14:52:47 2017 -0500
----------------------------------------------------------------------
.../ResponseTests_MimeResponse_ApiRender.java | 29 ++++++++++----------
.../ResponseTests_RenderResponse_ApiRender.java | 29 ++++++++++----------
2 files changed, 28 insertions(+), 30 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/portals-pluto/blob/280e2734/portlet-tck_3.0/V2ResponseTests/src/main/java/javax/portlet/tck/portlets/ResponseTests_MimeResponse_ApiRender.java
----------------------------------------------------------------------
diff --git a/portlet-tck_3.0/V2ResponseTests/src/main/java/javax/portlet/tck/portlets/ResponseTests_MimeResponse_ApiRender.java b/portlet-tck_3.0/V2ResponseTests/src/main/java/javax/portlet/tck/portlets/ResponseTests_MimeResponse_ApiRender.java
index cf2258f..6ceb707 100644
--- a/portlet-tck_3.0/V2ResponseTests/src/main/java/javax/portlet/tck/portlets/ResponseTests_MimeResponse_ApiRender.java
+++ b/portlet-tck_3.0/V2ResponseTests/src/main/java/javax/portlet/tck/portlets/ResponseTests_MimeResponse_ApiRender.java
@@ -109,10 +109,22 @@ public class ResponseTests_MimeResponse_ApiRender implements Portlet {
long tid = Thread.currentThread().getId();
portletReq.setAttribute(THREADID_ATTR, tid);
- PrintWriter writer = portletResp.getWriter();
-
JSR286ApiTestCaseDetails tcd = new JSR286ApiTestCaseDetails();
+ /* TestCase: V2ResponseTests_MimeResponse_ApiRender_setContentType4 */
+ /* Details: "Method setContentType(String): Throws */
+ /* IllegalArgumentException if the specified MIME type is invalid" */
+ TestResult tr11 = tcd.getTestResultFailed(
+ V2RESPONSETESTS_MIMERESPONSE_APIRENDER_SETCONTENTTYPE4);
+ try {
+ portletResp.setContentType("Invalid");
+ tr11.appendTcDetail("Method did not throw Exception");
+ } catch (IllegalArgumentException iae) {
+ tr11.setTcSuccess(true);
+ }
+ PrintWriter writer = portletResp.getWriter();
+ tr11.writeTo(writer);
+
// Create result objects for the tests
ClassChecker cc = new ClassChecker(portletResp.getClass());
@@ -265,19 +277,6 @@ public class ResponseTests_MimeResponse_ApiRender implements Portlet {
}
tr10.writeTo(writer);
- /* TestCase: V2ResponseTests_MimeResponse_ApiRender_setContentType4 */
- /* Details: "Method setContentType(String): Throws */
- /* IllegalArgumentException if the specified MIME type is invalid" */
- TestResult tr11 = tcd.getTestResultFailed(
- V2RESPONSETESTS_MIMERESPONSE_APIRENDER_SETCONTENTTYPE4);
- try {
- portletResp.setContentType("Invalid");
- tr11.appendTcDetail("Method did not throw Exception");
- } catch (IllegalArgumentException iae) {
- tr11.setTcSuccess(true);
- }
- tr11.writeTo(writer);
-
/*
* TestCase: V2ResponseTests_MimeResponse_ApiRender_getCharacterEncoding
*/
http://git-wip-us.apache.org/repos/asf/portals-pluto/blob/280e2734/portlet-tck_3.0/V2ResponseTests/src/main/java/javax/portlet/tck/portlets/ResponseTests_RenderResponse_ApiRender.java
----------------------------------------------------------------------
diff --git a/portlet-tck_3.0/V2ResponseTests/src/main/java/javax/portlet/tck/portlets/ResponseTests_RenderResponse_ApiRender.java b/portlet-tck_3.0/V2ResponseTests/src/main/java/javax/portlet/tck/portlets/ResponseTests_RenderResponse_ApiRender.java
index 1f174fd..dcc8d04 100644
--- a/portlet-tck_3.0/V2ResponseTests/src/main/java/javax/portlet/tck/portlets/ResponseTests_RenderResponse_ApiRender.java
+++ b/portlet-tck_3.0/V2ResponseTests/src/main/java/javax/portlet/tck/portlets/ResponseTests_RenderResponse_ApiRender.java
@@ -77,10 +77,22 @@ public class ResponseTests_RenderResponse_ApiRender implements Portlet {
long tid = Thread.currentThread().getId();
portletReq.setAttribute(THREADID_ATTR, tid);
- PrintWriter writer = portletResp.getWriter();
-
JSR286ApiTestCaseDetails tcd = new JSR286ApiTestCaseDetails();
+ /* TestCase: V2ResponseTests_RenderResponse_ApiRender_setContentType2 */
+ /* Details: "Method setContentType(String): Throws */
+ /* IllegalArgumentException if the content type is not valid" */
+ TestResult tr3 = tcd.getTestResultFailed(
+ V2RESPONSETESTS_RENDERRESPONSE_APIRENDER_SETCONTENTTYPE2);
+ try {
+ portletResp.setContentType("Invalid");
+ tr3.appendTcDetail("Method did not throw Exception");
+ } catch (IllegalArgumentException iae) {
+ tr3.setTcSuccess(true);
+ }
+ PrintWriter writer = portletResp.getWriter();
+ tr3.writeTo(writer);
+
// Create result objects for the tests
/* TestCase: V2ResponseTests_RenderResponse_ApiRender_setTitle2 */
@@ -112,19 +124,6 @@ public class ResponseTests_RenderResponse_ApiRender implements Portlet {
tr2.setTcSuccess(true);
tr2.writeTo(writer);
- /* TestCase: V2ResponseTests_RenderResponse_ApiRender_setContentType2 */
- /* Details: "Method setContentType(String): Throws */
- /* IllegalArgumentException if the content type is not valid" */
- TestResult tr3 = tcd.getTestResultFailed(
- V2RESPONSETESTS_RENDERRESPONSE_APIRENDER_SETCONTENTTYPE2);
- try {
- portletResp.setContentType("Invalid");
- tr3.appendTcDetail("Method did not throw Exception");
- } catch (IllegalArgumentException iae) {
- tr3.setTcSuccess(true);
- }
- tr3.writeTo(writer);
-
}
}