You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sirona.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2015/12/21 16:24:33 UTC

change in collector data store

Hi guys,

what did motivate
https://github.com/apache/sirona/commit/09bb8587dabbfa9cd877b6ae1fd981847042f351
change in collector data store factory?

Now it doesnt work by default anymore.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>

Re: change in collector data store

Posted by Romain Manni-Bucau <rm...@gmail.com>.
So which one would be good enough as a default? Basically a DataStoreFactory
needs to not rely on IoCs at all - but once again we can create multiple
depending the user (you as well ;)) needs.


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>

2015-12-24 3:52 GMT+01:00 Olivier Lamy <ol...@apache.org>:

> my main concerns was
>
> https://github.com/apache/sirona/commit/09bb8587dabbfa9cd877b6ae1fd981847042f351#diff-56628ef28db3ae28cacd09188d85102cL30
>
> As I work in a very constraint environment I didn't want to use the default
> InMemoryCounterDataStore which create some collections etc..
>
>
> On 23 December 2015 at 10:25, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Not sure I follow but if you find few time to try to find the reason
> before
> > next release ut would be very appreciated. Goal of factory was to make
> > defaults autoconfigured and easy to start.
> >
> > Here we broke it a bit and I d like to fix it without breaking the case
> you
> > meet.
> >
> > Side note: happy to get more factories if it helps.
> > Le 23 déc. 2015 00:11, "Olivier Lamy" <ol...@apache.org> a écrit :
> >
> > > I don't remember exactly all the details.
> > > But I was chasing memory usage. And as I remember all of this was
> > included
> > > in core and some services were even if I wanted to use only the agent.
> > > So a waste memory.
> > >
> > > On 22 December 2015 at 22:47, Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > > wrote:
> > >
> > > > Then the jar should be there by default in the webapp. My only
> concern
> > is
> > > > "should work OOTB" even if it uses a limited in memory storage.
> > > >
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > <http://www.tomitribe.com>
> > > >
> > > > 2015-12-22 12:44 GMT+01:00 Olivier Lamy <ol...@apache.org>:
> > > >
> > > > > Hi,
> > > > > Separation Of Concerns.
> > > > > If you add the memory store jar that shouldn't be a problem?
> > > > >
> > > > >
> > > > >
> > > > > On 22 December 2015 at 02:31, Romain Manni-Bucau <
> > > rmannibucau@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > PS: now to setup the collector instead of just configuration the
> > > > factory
> > > > > I
> > > > > > have to set all of these (nothing is redundant!):
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> <org.apache.sirona.store.DataStoreFactory>org.apache.sirona.store.CollectorDataStoreFactory</org.apache.sirona.store.DataStoreFactory>
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> <org.apache.sirona.store.counter.CollectorCounterStore>org.apache.sirona.store.memory.counter.InMemoryCollectorCounterStore</org.apache.sirona.store.counter.CollectorCounterStore>
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> <org.apache.sirona.store.counter.CounterDataStore>org.apache.sirona.store.memory.counter.InMemoryCounterDataStore</org.apache.sirona.store.counter.CounterDataStore>
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> <org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>org.apache.sirona.store.tracking.DelegatedCollectorPathTrackingDataStore</org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>
> > > > > >
> > > > > >
> > > > > >
> > > > > > Romain Manni-Bucau
> > > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > > > https://github.com/rmannibucau> |
> > > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > > > <http://www.tomitribe.com>
> > > > > >
> > > > > > 2015-12-21 16:24 GMT+01:00 Romain Manni-Bucau <
> > rmannibucau@gmail.com
> > > >:
> > > > > >
> > > > > > > Hi guys,
> > > > > > >
> > > > > > > what did motivate
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/sirona/commit/09bb8587dabbfa9cd877b6ae1fd981847042f351
> > > > > > > change in collector data store factory?
> > > > > > >
> > > > > > > Now it doesnt work by default anymore.
> > > > > > >
> > > > > > > Romain Manni-Bucau
> > > > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > > > <http://rmannibucau.wordpress.com> | Github
> > > > > > > <https://github.com/rmannibucau> | LinkedIn
> > > > > > > <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > > > > <http://www.tomitribe.com>
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Olivier Lamy
> > > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Olivier Lamy
> > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>

Re: change in collector data store

Posted by Olivier Lamy <ol...@apache.org>.
my main concerns was
https://github.com/apache/sirona/commit/09bb8587dabbfa9cd877b6ae1fd981847042f351#diff-56628ef28db3ae28cacd09188d85102cL30

As I work in a very constraint environment I didn't want to use the default
InMemoryCounterDataStore which create some collections etc..


On 23 December 2015 at 10:25, Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Not sure I follow but if you find few time to try to find the reason before
> next release ut would be very appreciated. Goal of factory was to make
> defaults autoconfigured and easy to start.
>
> Here we broke it a bit and I d like to fix it without breaking the case you
> meet.
>
> Side note: happy to get more factories if it helps.
> Le 23 déc. 2015 00:11, "Olivier Lamy" <ol...@apache.org> a écrit :
>
> > I don't remember exactly all the details.
> > But I was chasing memory usage. And as I remember all of this was
> included
> > in core and some services were even if I wanted to use only the agent.
> > So a waste memory.
> >
> > On 22 December 2015 at 22:47, Romain Manni-Bucau <rm...@gmail.com>
> > wrote:
> >
> > > Then the jar should be there by default in the webapp. My only concern
> is
> > > "should work OOTB" even if it uses a limited in memory storage.
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > <http://www.tomitribe.com>
> > >
> > > 2015-12-22 12:44 GMT+01:00 Olivier Lamy <ol...@apache.org>:
> > >
> > > > Hi,
> > > > Separation Of Concerns.
> > > > If you add the memory store jar that shouldn't be a problem?
> > > >
> > > >
> > > >
> > > > On 22 December 2015 at 02:31, Romain Manni-Bucau <
> > rmannibucau@gmail.com>
> > > > wrote:
> > > >
> > > > > PS: now to setup the collector instead of just configuration the
> > > factory
> > > > I
> > > > > have to set all of these (nothing is redundant!):
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> <org.apache.sirona.store.DataStoreFactory>org.apache.sirona.store.CollectorDataStoreFactory</org.apache.sirona.store.DataStoreFactory>
> > > > >
> > > > >
> > > >
> > >
> >
> <org.apache.sirona.store.counter.CollectorCounterStore>org.apache.sirona.store.memory.counter.InMemoryCollectorCounterStore</org.apache.sirona.store.counter.CollectorCounterStore>
> > > > >
> > > > >
> > > >
> > >
> >
> <org.apache.sirona.store.counter.CounterDataStore>org.apache.sirona.store.memory.counter.InMemoryCounterDataStore</org.apache.sirona.store.counter.CounterDataStore>
> > > > >
> > > > >
> > > >
> > >
> >
> <org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>org.apache.sirona.store.tracking.DelegatedCollectorPathTrackingDataStore</org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>
> > > > >
> > > > >
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > > <http://www.tomitribe.com>
> > > > >
> > > > > 2015-12-21 16:24 GMT+01:00 Romain Manni-Bucau <
> rmannibucau@gmail.com
> > >:
> > > > >
> > > > > > Hi guys,
> > > > > >
> > > > > > what did motivate
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/sirona/commit/09bb8587dabbfa9cd877b6ae1fd981847042f351
> > > > > > change in collector data store factory?
> > > > > >
> > > > > > Now it doesnt work by default anymore.
> > > > > >
> > > > > > Romain Manni-Bucau
> > > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > > <http://rmannibucau.wordpress.com> | Github
> > > > > > <https://github.com/rmannibucau> | LinkedIn
> > > > > > <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > > > <http://www.tomitribe.com>
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Olivier Lamy
> > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >
> > >
> >
> >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>



-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: change in collector data store

Posted by Romain Manni-Bucau <rm...@gmail.com>.
Not sure I follow but if you find few time to try to find the reason before
next release ut would be very appreciated. Goal of factory was to make
defaults autoconfigured and easy to start.

Here we broke it a bit and I d like to fix it without breaking the case you
meet.

Side note: happy to get more factories if it helps.
Le 23 déc. 2015 00:11, "Olivier Lamy" <ol...@apache.org> a écrit :

> I don't remember exactly all the details.
> But I was chasing memory usage. And as I remember all of this was included
> in core and some services were even if I wanted to use only the agent.
> So a waste memory.
>
> On 22 December 2015 at 22:47, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Then the jar should be there by default in the webapp. My only concern is
> > "should work OOTB" even if it uses a limited in memory storage.
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com>
> >
> > 2015-12-22 12:44 GMT+01:00 Olivier Lamy <ol...@apache.org>:
> >
> > > Hi,
> > > Separation Of Concerns.
> > > If you add the memory store jar that shouldn't be a problem?
> > >
> > >
> > >
> > > On 22 December 2015 at 02:31, Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > > wrote:
> > >
> > > > PS: now to setup the collector instead of just configuration the
> > factory
> > > I
> > > > have to set all of these (nothing is redundant!):
> > > >
> > > >
> > > >
> > >
> >
> <org.apache.sirona.store.DataStoreFactory>org.apache.sirona.store.CollectorDataStoreFactory</org.apache.sirona.store.DataStoreFactory>
> > > >
> > > >
> > >
> >
> <org.apache.sirona.store.counter.CollectorCounterStore>org.apache.sirona.store.memory.counter.InMemoryCollectorCounterStore</org.apache.sirona.store.counter.CollectorCounterStore>
> > > >
> > > >
> > >
> >
> <org.apache.sirona.store.counter.CounterDataStore>org.apache.sirona.store.memory.counter.InMemoryCounterDataStore</org.apache.sirona.store.counter.CounterDataStore>
> > > >
> > > >
> > >
> >
> <org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>org.apache.sirona.store.tracking.DelegatedCollectorPathTrackingDataStore</org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>
> > > >
> > > >
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > <http://www.tomitribe.com>
> > > >
> > > > 2015-12-21 16:24 GMT+01:00 Romain Manni-Bucau <rmannibucau@gmail.com
> >:
> > > >
> > > > > Hi guys,
> > > > >
> > > > > what did motivate
> > > > >
> > > >
> > >
> >
> https://github.com/apache/sirona/commit/09bb8587dabbfa9cd877b6ae1fd981847042f351
> > > > > change in collector data store factory?
> > > > >
> > > > > Now it doesnt work by default anymore.
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > <http://rmannibucau.wordpress.com> | Github
> > > > > <https://github.com/rmannibucau> | LinkedIn
> > > > > <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > > <http://www.tomitribe.com>
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Olivier Lamy
> > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>

Re: change in collector data store

Posted by Olivier Lamy <ol...@apache.org>.
I don't remember exactly all the details.
But I was chasing memory usage. And as I remember all of this was included
in core and some services were even if I wanted to use only the agent.
So a waste memory.

On 22 December 2015 at 22:47, Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Then the jar should be there by default in the webapp. My only concern is
> "should work OOTB" even if it uses a limited in memory storage.
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>
> 2015-12-22 12:44 GMT+01:00 Olivier Lamy <ol...@apache.org>:
>
> > Hi,
> > Separation Of Concerns.
> > If you add the memory store jar that shouldn't be a problem?
> >
> >
> >
> > On 22 December 2015 at 02:31, Romain Manni-Bucau <rm...@gmail.com>
> > wrote:
> >
> > > PS: now to setup the collector instead of just configuration the
> factory
> > I
> > > have to set all of these (nothing is redundant!):
> > >
> > >
> > >
> >
> <org.apache.sirona.store.DataStoreFactory>org.apache.sirona.store.CollectorDataStoreFactory</org.apache.sirona.store.DataStoreFactory>
> > >
> > >
> >
> <org.apache.sirona.store.counter.CollectorCounterStore>org.apache.sirona.store.memory.counter.InMemoryCollectorCounterStore</org.apache.sirona.store.counter.CollectorCounterStore>
> > >
> > >
> >
> <org.apache.sirona.store.counter.CounterDataStore>org.apache.sirona.store.memory.counter.InMemoryCounterDataStore</org.apache.sirona.store.counter.CounterDataStore>
> > >
> > >
> >
> <org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>org.apache.sirona.store.tracking.DelegatedCollectorPathTrackingDataStore</org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>
> > >
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > <http://www.tomitribe.com>
> > >
> > > 2015-12-21 16:24 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
> > >
> > > > Hi guys,
> > > >
> > > > what did motivate
> > > >
> > >
> >
> https://github.com/apache/sirona/commit/09bb8587dabbfa9cd877b6ae1fd981847042f351
> > > > change in collector data store factory?
> > > >
> > > > Now it doesnt work by default anymore.
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > <http://rmannibucau.wordpress.com> | Github
> > > > <https://github.com/rmannibucau> | LinkedIn
> > > > <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > <http://www.tomitribe.com>
> > > >
> > >
> >
> >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>



-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: change in collector data store

Posted by Romain Manni-Bucau <rm...@gmail.com>.
Then the jar should be there by default in the webapp. My only concern is
"should work OOTB" even if it uses a limited in memory storage.


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>

2015-12-22 12:44 GMT+01:00 Olivier Lamy <ol...@apache.org>:

> Hi,
> Separation Of Concerns.
> If you add the memory store jar that shouldn't be a problem?
>
>
>
> On 22 December 2015 at 02:31, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > PS: now to setup the collector instead of just configuration the factory
> I
> > have to set all of these (nothing is redundant!):
> >
> >
> >
> <org.apache.sirona.store.DataStoreFactory>org.apache.sirona.store.CollectorDataStoreFactory</org.apache.sirona.store.DataStoreFactory>
> >
> >
> <org.apache.sirona.store.counter.CollectorCounterStore>org.apache.sirona.store.memory.counter.InMemoryCollectorCounterStore</org.apache.sirona.store.counter.CollectorCounterStore>
> >
> >
> <org.apache.sirona.store.counter.CounterDataStore>org.apache.sirona.store.memory.counter.InMemoryCounterDataStore</org.apache.sirona.store.counter.CounterDataStore>
> >
> >
> <org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>org.apache.sirona.store.tracking.DelegatedCollectorPathTrackingDataStore</org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>
> >
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com>
> >
> > 2015-12-21 16:24 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
> >
> > > Hi guys,
> > >
> > > what did motivate
> > >
> >
> https://github.com/apache/sirona/commit/09bb8587dabbfa9cd877b6ae1fd981847042f351
> > > change in collector data store factory?
> > >
> > > Now it doesnt work by default anymore.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <http://rmannibucau.wordpress.com> | Github
> > > <https://github.com/rmannibucau> | LinkedIn
> > > <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > <http://www.tomitribe.com>
> > >
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>

Re: change in collector data store

Posted by Olivier Lamy <ol...@apache.org>.
Hi,
Separation Of Concerns.
If you add the memory store jar that shouldn't be a problem?



On 22 December 2015 at 02:31, Romain Manni-Bucau <rm...@gmail.com>
wrote:

> PS: now to setup the collector instead of just configuration the factory I
> have to set all of these (nothing is redundant!):
>
>
> <org.apache.sirona.store.DataStoreFactory>org.apache.sirona.store.CollectorDataStoreFactory</org.apache.sirona.store.DataStoreFactory>
>
> <org.apache.sirona.store.counter.CollectorCounterStore>org.apache.sirona.store.memory.counter.InMemoryCollectorCounterStore</org.apache.sirona.store.counter.CollectorCounterStore>
>
> <org.apache.sirona.store.counter.CounterDataStore>org.apache.sirona.store.memory.counter.InMemoryCounterDataStore</org.apache.sirona.store.counter.CounterDataStore>
>
> <org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>org.apache.sirona.store.tracking.DelegatedCollectorPathTrackingDataStore</org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>
>
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>
> 2015-12-21 16:24 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
>
> > Hi guys,
> >
> > what did motivate
> >
> https://github.com/apache/sirona/commit/09bb8587dabbfa9cd877b6ae1fd981847042f351
> > change in collector data store factory?
> >
> > Now it doesnt work by default anymore.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <http://rmannibucau.wordpress.com> | Github
> > <https://github.com/rmannibucau> | LinkedIn
> > <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com>
> >
>



-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: change in collector data store

Posted by Romain Manni-Bucau <rm...@gmail.com>.
PS: now to setup the collector instead of just configuration the factory I
have to set all of these (nothing is redundant!):

<org.apache.sirona.store.DataStoreFactory>org.apache.sirona.store.CollectorDataStoreFactory</org.apache.sirona.store.DataStoreFactory>
<org.apache.sirona.store.counter.CollectorCounterStore>org.apache.sirona.store.memory.counter.InMemoryCollectorCounterStore</org.apache.sirona.store.counter.CollectorCounterStore>
<org.apache.sirona.store.counter.CounterDataStore>org.apache.sirona.store.memory.counter.InMemoryCounterDataStore</org.apache.sirona.store.counter.CounterDataStore>
<org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>org.apache.sirona.store.tracking.DelegatedCollectorPathTrackingDataStore</org.apache.sirona.store.tracking.CollectorPathTrackingDataStore>



Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>

2015-12-21 16:24 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:

> Hi guys,
>
> what did motivate
> https://github.com/apache/sirona/commit/09bb8587dabbfa9cd877b6ae1fd981847042f351
> change in collector data store factory?
>
> Now it doesnt work by default anymore.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>