You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2020/10/16 03:56:00 UTC
[jira] [Comment Edited] (CASSANDRA-16210) Synchronize Keyspace
instance store/clear
[ https://issues.apache.org/jira/browse/CASSANDRA-16210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214734#comment-17214734 ]
Ekaterina Dimitrova edited comment on CASSANDRA-16210 at 10/16/20, 3:55 AM:
----------------------------------------------------------------------------
The issue is, it was possible to open a new Keyspace instance in the middle of Schema.dropKeyspace(). To see the problem the drop has to progress to the following [state|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/config/Schema.java#L657]: 1) Keyspace instance doesn't exist - it has been already removed.
2) KeyspaceMetadata still exists
Keyspace.open in this state creates a new Keyspace instance (with ColumnFamilyStore instances) and stores it in Schema.keyspaceInstances. This is an object leak.
[3.11 |https://github.com/ekaterinadimitrova2/cassandra/pull/59]
CI run:
[Java8 | https://jenkins-cm4.apache.org/job/Cassandra-devbranch/104/#showFailuresLink]
[4.0 | https://github.com/ekaterinadimitrova2/cassandra/pull/62]
CI run:
[Java 8 | https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/414/workflows/9d0905bd-6ca6-480a-862b-35d5842ed5ef] | [Java 11 | https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/414/workflows/9476a603-a494-4da3-bf69-9498d40ae29a]
was (Author: e.dimitrova):
It turned out the issue is already solved for 4.0 with CASSANDRA-9425
Posting patch for [3.11 | https://github.com/ekaterinadimitrova2/cassandra/pull/59]
CI run:
[Java8 | https://jenkins-cm4.apache.org/job/Cassandra-devbranch/104/#showFailuresLink]
> Synchronize Keyspace instance store/clear
> -----------------------------------------
>
> Key: CASSANDRA-16210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16210
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Schema
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 3.11.x
>
>
> DTest failure: dtest-large.repair_tests.repair_test.TestRepairDataSystemTable.test_repair_table (vnodes) - one random failure was reported which pointed to a race condition to be spotted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org