You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "arnoldmr01 (via GitHub)" <gi...@apache.org> on 2026/09/21 22:09:13 UTC
[PR] Add oauth callback function for MSK/Managed_Kafka [airflow]
arnoldmr01 opened a new pull request, #73507:
URL: https://github.com/apache/airflow/pull/73507
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
* related: https://github.com/apache/airflow/issues/52712
# What is this PR about?
This is a follow-up for https://github.com/apache/airflow/pull/69000.
So far, `KafkaBaseHook` will add oauth_cb in configuration automatically based on the bootstrap.servers (from MSK or Managed_Kafka). This PR
- add an oauth_cb callback function for user to explicit config oauth_cb.
- add document about how to set up oauth_cb function.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- [X] Generated-by: [Codex] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add oauth callback function for MSK/Managed_Kafka [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #73507:
URL: https://github.com/apache/airflow/pull/73507#discussion_r4128040214
##########
providers/amazon/docs/msk.rst:
##########
@@ -0,0 +1,44 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Amazon Managed Streaming for Apache Kafka
Review Comment:
A top level doc for MSK does not make sense, we don't do this for any other individual service. Can you please move this to `message-queues/index.rst`, thanks!
##########
providers/amazon/docs/msk.rst:
##########
@@ -0,0 +1,44 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Amazon Managed Streaming for Apache Kafka
+=========================================
+
+`Amazon MSK <https://aws.amazon.com/msk/>`_ is a managed Apache Kafka service. The Amazon
+provider's :class:`~airflow.providers.amazon.aws.hooks.msk.MskHook` provides a boto3 client for
+managing MSK clusters and can generate IAM authentication tokens for Kafka clients. The
+Apache Kafka provider handles producing and consuming topic messages.
+
+Trigger a Dag from an MSK topic
+-------------------------------
+
+Use :class:`~airflow.providers.apache.kafka.triggers.msg_queue.KafkaMessageQueueTrigger` with
+``AssetWatcher`` to trigger a Dag when a message arrives. Set the trigger's ``kafka_config_id``
+to a Kafka connection configured for the MSK brokers. There is no separate Amazon MSK message
+queue trigger; the standard Kafka trigger works with MSK because MSK uses the Kafka protocol.
+See the `Kafka message queue trigger guide
+<https://airflow.apache.org/docs/apache-airflow-providers-apache-kafka/stable/message-queues/index.html>`_
Review Comment:
You can use `:doc:` references to make these links, that has checks for dead links and when pages move, it's preferable. Here and throughout the rest of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add oauth callback function for MSK/Managed_Kafka [airflow]
Posted by "arnoldmr01 (via GitHub)" <gi...@apache.org>.
arnoldmr01 commented on code in PR #73507:
URL: https://github.com/apache/airflow/pull/73507#discussion_r4351093244
##########
providers/amazon/docs/msk.rst:
##########
@@ -0,0 +1,44 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Amazon Managed Streaming for Apache Kafka
Review Comment:
Thanks for the review. Will modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org